412409 - UTF-8 encoded subject fails at user registration confirming mail

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Localization, defect)

Description

[Masahiro YAMADA]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: 

When registering user by https://addons.mozilla.org/ja/firefox/users/register,
registration confirming mail from a.m.o. has invalid Subject header.
And it causes broken mail subject.


Reproducible: Always

Steps to Reproduce:
1.Register user at https://addons.mozilla.org/ja/firefox/users/register
2.Recieve register confirming mail
3.Check its subject
Actual Results:  
Its subject is 
Subject: =?UTF-8?B?RmlyZWZveCBBZGQtb25zIOOBuOOBlOeZu+mMsuOBhOOBn+OBoOOBjeOBguOC?= =?UTF-8?B?iuOBjOOBqOOBhuOBlOOBluOBhOOBvuOBmQ==?=

Decoded title is
Firefox Add-ons へご登録いただきあ��がとうございます 

Expected Results:  
It should be 
Subject: =?utf-8?b?RmlyZWZveCBBZGQtb25zIOOBuOOBlOeZu+mMsuOBhA==?=
=?utf-8?b?44Gf44Gg44GN44GC44KK44GM44Go44GG44GU44GW44GE44G+44GZIA==?=

Decoded title should be
Firefox Add-ons へご登録いただきありがとうございます 

It has two problems.
1.Length of First line of Subject is longer then 76characters.
  (It doesn't conform to RFC 2047.)

2.Single UTF-8 character is divided as two encoded parts
 (Some mail agent may not able to re-struct string correctly)

If you can read Japanaes please see also http://forums.firehacks.org/trans/viewtopic.php?t=3986

Comment 1

[Masahiro YAMADA]

See also RFC2047:

Section 2 (http://tools.ietf.org/html/rfc2047#section-2)
>   While there is no limit to the length of a multiple-line header
>   field, each line of a header field that contains one or more
>   'encoded-word's is limited to 76 characters.

Section 5 (3) - on page 8 (http://tools.ietf.org/html/rfc2047#page-8)
>   Each 'encoded-word' MUST represent an integral number of characters.
>   A multi-octet character may not be split across adjacent 'encoded-
>   word's.

Comment 2

[Fred Wenzel [:wenzel]]

I can confirm. It seems like an issue with the phpmailer library we use, so I filed bug 432493 to handle that specifically. I believe we need to push the bug up-stream, possibly providing a patch ourselves if it's relatively easy to figure out.

Comment 3

[Masahiro YAMADA]

I reported to PHPMailer bug tracker.
http://sourceforge.net/tracker/index.php?func=detail&aid=1959889&group_id=26031&atid=385707

And, I found same problem and workaround on XOOPS CUCBE's forum in Japan.

See also:
http://xoopscube.jp/modules/newbb/viewtopic.php?topic_id=6940&forum=11&post_id=35435
https://sourceforge.jp/tracker/?group_id=64&atid=325&func=detail&aid=6182
(They are written in Japanese)

Comment 4

[Masahiro YAMADA]

This issue is PHPMailer bug id=1190849
http://sourceforge.net/tracker/index.php?func=detail&aid=1190849&group_id=26031&atid=385707

Patches are here:
For 1.x:
http://sourceforge.net/tracker/index.php?func=detail&aid=1713510&group_id=26031&atid=385709
For 2.0.0:
http://sourceforge.net/tracker/index.php?func=detail&aid=1899080&group_id=26031&atid=385709

Comment 5

[Fred Wenzel [:wenzel]]

Masahiro: Thank you very much for pushing this bug upstream and finding a patch. Well done. I will try to put this in place soon.

Comment 6

[Fred Wenzel [:wenzel]]

I updated the phpmailer library we use to 2.0.0 including the patch from comment 4 (SVN r13091). In my tests, the Japanese confirmation email now has a working subject.

Marking push-needed, it will go online in production with the next push.

Stephend: For testing, you may want to register on Japanese preview so that you get a multibyte-character email: The subject line and the text should have proper Japanese symbols, and no garbled question marks.

Masahiro: Again thank you for your help.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of [ja] confirmation email

Masahiro-san; does the attached screenshot verify that this bug is fixed?

Thanks!

Comment 8

[Masahiro YAMADA]

(In reply to comment #7)
> Created an attachment (id=320850) [details]
> Screenshot of [ja] confirmation email
> 
> Masahiro-san; does the attached screenshot verify that this bug is fixed?
> 
> Thanks!
> 
Looks good. Thank you!
--> VERIFIED

Comment 9

[Fred Wenzel [:wenzel]]

(In reply to comment #7)
> Created an attachment (id=320850) [details]
> Screenshot of [ja] confirmation email
> 
> Masahiro-san; does the attached screenshot verify that this bug is fixed?

A screenshot with Steve Urkel on it is automatically verified! ;-)