412428 - ";" in URL of file name, directory name, extention should be encoded at directory list

Status: RESOLVED DUPLICATE of bug 448141

(Core Graveyard :: File Handling, defect)

Description

[Masahiro YAMADA]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: 

";" in URL of file/diorectory/extention name should be encoded as %3B in directory list.



Reproducible: Always

Steps to Reproduce:
1.Create file "a;b.html" to some direcotory
2.Show its directory list using file:// scheme
3.clink link to "a;b.html"

Actual Results:  
It does not work.

Expected Results:  
It should work.

It may not be needed to escape ";"  in other schemes (e.g. ftp, gopher, etc.).
But I cannot test on my PC.

Comment 1

[Masahiro YAMADA]

I think, at Windows, MacOSX, UNIX and OS2,  nsIndexedToHTML should replace ";" to "%3b" like net_GetURLSpecFromFile in nsURLHelperWin.cpp , nsURLHelperOSX.cpp , nsURLHelperUnix.cpp and  nsURLHelperOS2.cpp.

Comment 2

[Masahiro YAMADA]

Attachment: Patch rv 1.0 for Trunk

According to nsURLHelperXXXX.cpp (nsURLHeplerWin.cpp, nsURLHeplerOSX.cpp, nsURLHeplerUnix.cpp and nsURLHeplerOS2.cpp), Windows, MacOSX, Unix and OS2 requeres to escape ";".
But I don't know other OS need to escape ";" or not. (e.g. BeOS)

If All supported OS needs to escape ";"

+#if defined(XP_WIN) || defined(XP_MACOSX) || defined(XP_UNIX) || defined(XP_OS2)
+        semiColonEscapeNeeded = PR_TRUE;
+#endif

can be simplified to

+        semiColonEscapeNeeded = PR_TRUE;

Comment 3

[Boris Zbarsky [:bzbarsky]]

I'm not going to be able to review this until June.

Comment 4

[Masahiro YAMADA]

Attachment: Patch rv.1.1

1.Deleted escapedEllipsis (It is used in patch of bug 411854, not for this bug).
2.Renamed semiColonEscapeNeeded to mSemiColonEscapeNeeded (unify naming style)

Comment 5

[Sergei Dolgov]

> But I don't know other OS need to escape ";" or not. (e.g. BeOS)
> 
> If All supported OS needs to escape ";"
> 
Here is my attemt to test problem in BeOS:
http://community.livejournal.com/bezilla/279851.html?replyto=1427755

Comment 7

[Masahiro YAMADA]

Comment on attachment 311794 [details] [diff] [review]
Patch rv.1.1

this bug is already fixed by bug 448141.