412436 - gtk: when tab's close icon's size is 22x22, the tab isn't enlarged accordingly

Status: RESOLVED INACTIVE

(Core :: Widget: Gtk, defect, P5)

Description

[u294409]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b3pre) Gecko/2008011404 openSUSE/10.3 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b3pre) Gecko/2008011404 openSUSE/10.3 Minefield/3.0b3pre

I'm using modified Clearlooks theme with one feature:

gtk-icon-sizes="gtk-menu=22,22:"

Firefox uses this icon size for drawing tab's close button, but not menus (bug #412073).

Button looks nice, but it doesn't stretch the tab in a good way. It covers tab's part, which normally shouldn't be covered.

Reproducible: Always

Actual Results:  
button covers uncoverable tab's part

Expected Results:  
everything ok (as said by me many times :> )

Comment 1

[u294409]

ping

Comment 2

[Julien "_FrnchFrgg_" RIVAUD]

You should post a screenshot or explain more if you want your bug to be confirmed (without confirmation, you have a very low chance of it being worked on).

Do you mean that the close button grows, but that the tab doesn't grow to adapt ?

Comment 3

[u294409]

Attachment: screenshot

Comment 4

[Hussam Al-Tayeb]

(In reply to comment #3)
> Created an attachment (id=297765) [details]
> screenshot
> 

That's a bug in gtk-engines 2.13.x , please file a bug in gnome's bugzilla.

Comment 5

[u294409]

Who told you I'm using 2.13.x ?
I'm using 2.12.3 (RPM release no 3, Fedora 8).

Comment 6

[Hussam Al-Tayeb]

(In reply to comment #5)
> Who told you I'm using 2.13.x ?
> I'm using 2.12.3 (RPM release no 3, Fedora 8).
> 

Ok I'm sorry. 
I asked because there is a very similar bug in gtk-engines 2.13.x

Comment 7

[u294409]

No prob, Bob :P .

Comment 8

[Julien "_FrnchFrgg_" RIVAUD]

Jakub: I don't see the bug. The tab is correctly enlarged on my build. Could you try with latest nightly and a fresh profile ?

Comment 9

[u294409]

I'm still using Trunk and I have fresh profile, because I had some problems with old (bottom borders of notebook widget as example).

Comment 10

[u294409]

It works only when two or more tabs are opened.
Also, when I close tab to make only one visible, its jumpy (size of tabbar is increased).

Comment 11

[u294409]

Attachment: one tab opened

Comment 12

[u294409]

Attachment: two tabs opened

Comment 13

[u294409]

Measure size of tabbar in both two screenshots.
There's difference of 1/2 pixels (I didn't measure it, I just guess).

Comment 14

[Julien "_FrnchFrgg_" RIVAUD]

OK, I see that the tabs haven't the same size, but here it doesn't overlap the border of the tab.

So your pb is that minimal tab height is not big enough, but when there are more than one tab, the selected tab is 2px taller than this minimal size (which is applied to the unselected tabs), so it makes for it and the bug is hidden.
One thing I notice is that the blue feature of selected tabs is taller on your screenshot than on my clearlooks... Does your theme correctly advertize that to us ? It could simply be that (and sadly we wouldn't have a lot of things we could do).

At least we can make a single selected tab as high as when there are unselected tabs. This would be a new bug though (which may already exist). I'll probably try to file it (or find it if it exists), but since I might have not enough time for a few days, I'd like if you did that for me (search if a bug exists about the selected tab being smaller when it is alone, and if not file it), and CC me then.

Comment 15

[u294409]

The problem still exists. Don't know why we don't use same notebook widget as in Preferences.

Our current main window's notebook widget doesn't even have borders and paddings...

Comment 16

[u294409]

Should I file similiar bug for close button in sidebar?

Here tab looks strange, when button's size is increased, while in sidebar button is stretched down vertically...

Comment 17

[u294409]

I know what can cause this.
Button kinda fits the tabstrip when only one tab shown or then tab "scrollerbuttons" are shown.

Comment 18

[u294409]

May be related to bug 419284

Comment 19

[u294409]

I noticed that with 16x16 bug appears too, but only with Clearlooks-based themes.

Comment 20

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1552613

Comment 21

[Sylvestre Ledru [:Sylvestre]]

no activity for years, closing.
Feel free to reopen if this is still occurring