412478 - Lightning removes Open Saved Message... command from File menu

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/2008011404 Thunderbird/2.0.0.12pre with

Steps To Reproduce:
1. Start Thunderbird
2. Run File -> Open Saved Message... to open e.g. a locally stored .eml file
3. Install Lightning.
4. In Mail Mode run File -> Open Saved Message...

Actual Results:
The menu entry is gone.

Expected Results:
The menu entry is still available.

Additional Information:
After searching for some time I finally found the command hidden in Calendar Mode in menu File -> Open -> Saved Message... This is highly counterintuitive. The command is related to mail messages and therefore should be available in Mail Mode in the known location.

Comment 1

[Philipp Kewisch [:Fallen][☁️📆]]

While I do see what you mean, it doesn't quite fit in that there is an item "Open Saved Message" and an Item "Open Saved Calendar". It sounds natural to me, that an "Open"  menu is needed. Maybe we want to file a thunderbird bug to make that thing a menu? Although with thunderbird alone it doesnt make sense, since that menu would only have one item.

Christian, what do you say?

Comment 2

[Stefan Sitter [:ssitter]]

I could imagine the following solutions:

A) in Mail Mode restore the File -> Open Saved Message... menu entry

B) in Mail Mode hide the File -> Open Saved Message... menu entry and add the same File -> Open sub-menu that is shown in the Calendar Mode.

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Oh, now I actually see what the problem is. I assumed the problem was that the menuitem moved to the open menu, but now I see that is actually missing in mail mode.

I'd go for solution (A), since that is the way it was intended to be in bug 379204. In that sense this is actually a regression.

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Berend, can you look into this?

Comment 5

[Sven Giermann]

Attachment: Return of "Open Saved Message..."

Since the new way disables this menu item automatically in Calendar and Task mode, it is not necessary to hide it in Mail mode anymore... (as introduced by Philipp with Attachment #283899 [details] [diff])

Comment 6

[Berend Cornelius]

Comment on attachment 298428 [details] [diff] [review]
Return of "Open Saved Message..."

The patch works as advertised. Thank you!;r=berend.

Comment 7

[Sven Giermann]

Berend, could you please check this one in?

Comment 8

[Berend Cornelius]

patch checked in on trunk and MOZILLA_1_8_BRANCH. 
=> fixed.
I am sorry the issue went off my radar.

Comment 9

[Daniel Boelzle [:dbo]]

FIXED

Comment 10

[Stefan Sitter [:ssitter]]

Verified using Lightning 0.8pre (2008012710) with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/2008012703 Thunderbird/2.0.0.12pre.

Comment 11

[Lars Wohlfahrt (thetux)]

It's fixed.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/2008012703
Thunderbird/2.0.0.9 Lightning 0.8pre (2008012710)