Closed Bug 412660 Opened 18 years ago Closed 17 years ago

Need to better handle case where an adr contains only an extended-address

Categories

(Toolkit Graveyard :: Microformats, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file, 1 obsolete file)

In the microformats code, I attempt to create a title for a given microformat. In the adr case, I do not use "extended-address" at all, but there are cases now where extended-address is the only thing specified.
Attached patch Fix for problem (obsolete) — Splinter Review
If there is an extended-address, use it when creating the label of the microformat.
Attachment #297393 - Flags: review?
Attachment #297393 - Flags: review? → review?(sayrer)
Needs a test.
Fix that includes unit test to cover this case in adr
Attachment #297393 - Attachment is obsolete: true
Attachment #301511 - Flags: review?(sayrer)
Attachment #297393 - Flags: review?(sayrer)
Attachment #301511 - Flags: review?(sayrer) → review+
Attachment #301511 - Flags: approval1.9?
Comment on attachment 301511 [details] [diff] [review] Fix for problem with test Thnx for the tests.
Attachment #301511 - Flags: approval1.9? → approval1.9+
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: