412851 - /names command duplicates the channel user list

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Adam Hardy]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11

Whenever i /names in a channel, the channels user list in the left hand panel duplicates. Doing it again adds another set of duplicates. Three screenshot shows what happens after i did it twice.

Otherwise, the /names function works as expected.

Reproducible: Always

Steps to Reproduce:
1.Type /names in a channel.

Comment 1

[:Gijs (he/him)]

Bah. :-(

Comment 2

[:Gijs (he/him)]

A quick look seems to indicate this is because on353 in irc.js ( http://mxr.mozilla.org/seamonkey/source/extensions/irc/js/lib/irc.js#1754 ) erases the channel users (and so also their links with the userlist objects (but they still exists because the view has a hold of them, of course)) and then it creates new channel users. This is not only lousy, I also expect it to leak the crap out of stuff. :-(

Comment 3

[James Ross]

We should be able to process either on353 or on366 for the channel in handlers.js and remove the entries no longer in this.users. (Since we do the other work in on366, probably good to do it there also.)

Comment 4

[:Gijs (he/him)]

Attachment: Patch

This works. Yay. I'm not sure how to make it play nicely with the add/removeUsers API though. Silver, ideas?

Comment 6

[James Ross]

Since that API takes an array, why not (inside the while) push _userObj into updates and then call this.removeUsers(updates), before resetting updates to an empty array for the additions in the existing code?

Comment 7

[:Gijs (he/him)]

Attachment: Better Patch

Haven't tested this, but, like this?

Comment 8

[James Ross]

Comment on attachment 299336 [details] [diff] [review]
Better Patch

Yes. Like that. :)

Comment 9

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/handlers.js;
/cvsroot/mozilla/extensions/irc/xul/content/handlers.js,v  <--  handlers.js
new revision: 1.168; previous revision: 1.167
done