412902 - Remove support for unused events

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[Aaron Leventhal]

Currently we do not fire the table events for IA2 and ATK/AT-SPI.

We're apparently firing something else when rows are deleted from a tree grid.

Are these events even used? Are they expected?

- table rows removed
- table rows inserted
- table columns removed
- table columns inserted

Comment 1

[Aaron Leventhal]

If it is decided that these events will not be used, we should remove nsIAccessibleTableChangeEvent from the code. Currently it's in there so that it *could* be used, but nothing creates one.

http://lxr.mozilla.org/seamonkey/source/accessible/public/nsIAccessibleEvent.idl#573

Comment 2

[alexander :surkov (:asurkov)]

we have bug 385317 for this, Willie said they aren't currently used.  Willie have something changed?

Though I think it should be easy enough to fire row inserted/deleted events for html:table.

Also we have one more bug 368535. Do we need it?

Comment 3

[Willie Walker]

I don't believe Orca makes use of these events at all.  But, Jambu or GOK might -- Steve Lee and David Bolter would be good folks to ask.

Comment 4

[alexander :surkov (:asurkov)]

steve, david any thoughts?

Comment 5

[Michael Curran]

(In reply to comment #4)
> steve, david any thoughts?
For NVDA's part, it does not use these events either. That's not to say we won't in the future, but definitely for Firefox 3.0 support I have no plans to look in to this.

Comment 6

[Steve Lee]

(In reply to comment #4)
> steve, david any thoughts?
> 
I don't need these specific events but do need to know that any contained children I am excited about have changed so that it can refresh the model it has of interactive nodes. Do you know if that happens, even in only for the document? Obviously the higher up it is the more work has to be done to refresh. Seems I need to test dynamic tables.

Comment 7

[Marco Zehe (:MarcoZ)]

Has this situation gotten better for treegrid implementations since bug 472662 was fixed?

Comment 8

[alexander :surkov (:asurkov)]

(In reply to comment #7)
> Has this situation gotten better for treegrid implementations since bug 472662
> was fixed?

Marco, I think this bug and bug 472662 aren't related, this bug is about to fire table specific events when row/col is changed. For example, IA2 has event IA2_EVENT_TABLE_MODEL_CHANGED we don't fire. I think something similar there is on ATK side.

Comment 9

[alexander :surkov (:asurkov)]

out of box until we have evidence somebody needs them

Comment 10

[James Teh [:Jamie]]

If no one has asked for these in 15 years, I think we should just remove them.

Comment 11

[James Teh [:Jamie]]

EVENT_SECTION_CHANGED is also unused.

Comment 12

[James Teh [:Jamie]]

Also other EVENT_TABLE_* events for captions, etc. and EVENT_HYPER*.

Actually, there are a bunch of other unused events as well. I think we're going to have to go through the whole list. :(

Comment 13

[James Teh [:Jamie]]

Attachment: Bug 412902: Remove unused accessibility events.

This removes the unused AccTableChangeEvent class, as well as the following unused event constants:

• EVENT_ACTIVE_DECENDENT_CHANGED
• EVENT_LOCATION_CHANGE
• EVENT_HELP_CHANGE
• EVENT_DEFACTION_CHANGE
• EVENT_ACTION_CHANGE
• EVENT_ACCELERATOR_CHANGE
• EVENT_FOREGROUND
• EVENT_CAPTURE_START
• EVENT_CAPTURE_END
• EVENT_MOVESIZE_START
• EVENT_MOVESIZE_END
• EVENT_CONTEXTHELP_START
• EVENT_CONTEXTHELP_END
• EVENT_DRAGDROP_END
• EVENT_DIALOG_START
• EVENT_DIALOG_END
• EVENT_MINIMIZE_START
• EVENT_MINIMIZE_END
• EVENT_DOCUMENT_ATTRIBUTES_CHANGED
• EVENT_DOCUMENT_CONTENT_CHANGED
• EVENT_PROPERTY_CHANGED
• EVENT_PAGE_CHANGED
• EVENT_TEXT_CHANGED
• EVENT_TEXT_UPDATED
• EVENT_VISIBLE_DATA_CHANGED
• EVENT_TEXT_COLUMN_CHANGED
• EVENT_SECTION_CHANGED
• EVENT_TABLE_CAPTION_CHANGED
• EVENT_TABLE_MODEL_CHANGED
• EVENT_TABLE_SUMMARY_CHANGED
• EVENT_TABLE_ROW_DESCRIPTION_CHANGED
• EVENT_TABLE_ROW_HEADER_CHANGED
• EVENT_TABLE_ROW_INSERT
• EVENT_TABLE_ROW_DELETE
• EVENT_TABLE_ROW_REORDER
• EVENT_TABLE_COLUMN_DESCRIPTION_CHANGED
• EVENT_TABLE_COLUMN_HEADER_CHANGED
• EVENT_TABLE_COLUMN_INSERT
• EVENT_TABLE_COLUMN_DELETE
• EVENT_TABLE_COLUMN_REORDER
• EVENT_WINDOW_CREATE
• EVENT_WINDOW_DESTROY
• EVENT_WINDOW_RESIZE
• EVENT_HYPERLINK_END_INDEX_CHANGED
• EVENT_HYPERLINK_NUMBER_OF_ANCHORS_CHANGED
• EVENT_HYPERLINK_SELECTED_LINK_CHANGED
• EVENT_HYPERTEXT_LINK_ACTIVATED
• EVENT_HYPERTEXT_LINK_SELECTED
• EVENT_HYPERLINK_START_INDEX_CHANGED
• EVENT_HYPERTEXT_CHANGED
• EVENT_HYPERTEXT_NLINKS_CHANGED

Comment 14

[Joanmarie Diggs]

Jamie: Orca pays attention to row and column reorder events. I think those would be potentially useful in sortable ARIA grids. Granted if no spec states it needs doing, implementations probably won't do it.... Anyhoo, for what it's worth.

Comment 15

[James Teh [:Jamie]]

Thanks Joanie. We could certainly look at implementing this with appropriate spec guidance/browser consensus. That said, I don't think it serves us to have events in the code base for 15 years which have never been used. :) I'm going to leave this as is, but I'm certainly not suggesting we wouldn't add one or two of these back if they actually turn out to be useful and specified.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1eed4a8f47c5
Remove unused accessibility events. r=eeejay

Comment 17

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1eed4a8f47c5