Closed
Bug 412990
Opened 18 years ago
Closed 18 years ago
Sherlock conversion code fails to add icon
Categories
(Firefox :: Search, defect, P1)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 3 beta3
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.09 KB,
patch
|
asaf
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
Bug 363512 removed the b64 function in favor of the built-in btoa(), but forgot to update a caller. Unfortunately the caller is in a try/catch block so its failure was hard to miss.
Flags: blocking-firefox3?
|
Assignee | |
Comment 1•18 years ago
|
||
"oops" :(
|
|
Assignee | |
Updated•18 years ago
|
Priority: -- → P1
Target Milestone: --- → Firefox 3 M11
|
||
Comment 2•18 years ago
|
||
Comment on attachment 297817 [details] [diff] [review]
patch
r=mano
Attachment #297817 -
Flags: review?(mano) → review+
|
|
Assignee | |
Updated•18 years ago
|
Attachment #297817 -
Flags: approval1.9?
|
||
Updated•18 years ago
|
Attachment #297817 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Updated•18 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•18 years ago
|
||
mozilla/browser/components/search/nsSearchService.js 1.107
|
|
||
Updated•18 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
You need to log in
before you can comment on or make changes to this bug.
Description
•