413067 - Bookmark Contextual Dialog: Rounded corners

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

The contextual dialog should have rounded corners with a 4px radius on Vista, and an 8px radius on XP.

Mockup available at: http://people.mozilla.com/~faaborg/files/granParadisoUI/places_NewBookmarkDialog_i9.png

Comment 1

[Ryan A. C.]

I was just doing some quick testing with userchrome, and I found that for some reason setting -moz-border-radius on the editBookmarkPanel loses the drop shadow...

Comment 2

[Victor Bielawski]

On Vista, one can use -moz-appearance: tooltip to automatically give it the style shown in the mockup.

Comment 3

[Ryan A. C.]

-moz-appearance: tooltip on vista works, but it has a few shortcomings:

1) the gradient is not very smooth when stretched out to the size of something like that
2) it turns yellow on classic mode (not necessarily a problem, I believe this was one of the proposed mockups)
3) if we are ever to add the tab-like appearance then we'll have to match our own gradient against the system gradient.
4) there's a strange thing in the bottom-right corner. I think it's supposed to be the arrow that points to the object that's popping the tooltip, it can be gotten rid of with -moz-border-radius though. If we can figure out how to use this arrow it might be to our advantage, maybe tooltip-pop out of the star.

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

This was fixed during the development of Firefox 3.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is not fixed. There are no rounded corners for the contextual dialog with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.2pre) Gecko/2008071506 GranParadiso/3.0.2pre ID:2008071506

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: No rounded corners

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

Two things leading to confusion include that this was addressed in a variety of other bugs, and that we have three different styles for Vista, XP and OS X:

Vista: tooltip appearance
XP: menu appearance
OS X: transparent HUD window

So everything is correct, just poorly documented.  Switching the resolution to invalid.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Vista with rounded but not transparent corners

Alex, WFM looks more reasonable here. We have rounded corners on Vista and OS X. Just a question to the former one, can you have a look at the attachment? The corners aren't transparent so it looks ugly with that white dot. Is there an already filed bug about?

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

I think that is covered by bug 376408, although it seems like they are now white while the reporter of that bug has screenshots of them being black.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks Alex. I commented to that bug.

I think we can close this bug now. Let's mark it as WFM.

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv