413159 - Changing calendar for tasks via context menu doesn't work

Status: VERIFIED FIXED

(Calendar :: Tasks, defect)

Description

[Omar Bajraszewski]

When you right click on task there is an option to change a calendar for it. But it doesn't work.

Comment 1

[Omar Bajraszewski]

Lt 2008011911/Tb 2.0.0.9

Comment 2

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/2008020521 Calendar/0.8pre

Fails for me when changing from storage to ics calendar and vice versa.

Works for me when changing from storage to storage calendar. 
In this case I see the following warning in Venkman:

Warning "reference to undefined property this.todoPromotedProps[name]'' [-s] in file "file:///E:/sunbird/js/calTodo.js'', line 238, character 0.

Comment 3

[Simon Paquet [:sipaq]]

This does not block the 0.8 release.

Comment 4

[Berend Cornelius]

Apart from the described behaviouur I am myself not content with the implementation of that context menu because it offers calendars that are not writable for the user unlike in the calendar-event-dialog.

Comment 5

[Berend Cornelius]

Attachment: patch v. 1

This patch should improve the situation. In this patch I consolidated the sourcecode from the sun-calendar-event-dialog and filled up the menu only with writable calendars.

Comment 6

[Berend Cornelius]

Attachment: patch v. 1

This patch should improve the situation. In this patch I consolidated the sourcecode from the sun-calendar-event-dialog and filled up the menu only with writable calendars.

Comment 7

[Berend Cornelius]

Attachment: patch v. #2

I added a small change because I saw that I was not comparing calendars by their ids. This new patch also fixes bug 416584 on the way. I hope it's Ok when I set the other issue - that occured because the calendar was not set at the item - to 'duplicate' to this one.

Comment 8

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 303052 [details] [diff] [review]
patch v. #2


>+        var selIndex = appendCalendarItems(tasks[0], calendarMenuPopup, "contextChangeTaskCalendar(event);"); //, command);
>+        if (isPropertyValueSame(tasks, "calendar") && (selIndex > -1)) {
>+            calendarMenuPopup.childNodes[selIndex].setAttribute("checked", "true");
>+        }
Remove the //, command comment. 


>  * Contributor(s):
>+ *                 Berend Cornelius <[e-mail]>
Please align your name under the n of Contributors



>+/** checks if an item is supported by a Calendar
>+* @param aCalendar the calendar
>+* @param aItem the item either a task or an event
>+* @return true or false
>+*/
It would be great if you could format the comments as in the other files we have them: Newline after /**, Empty line after description, and aligned parameter descriptions. Example follows. Please fix here and elsewhere.

/**
 * Checks if an item is supported by a calendar
 *
 * @param aCalendar    The Calendar
 * @param aItem        the item, either a task or an event. This
 *                       would happen if the description needs
 *                       to be wrapped.
 * @return             True if the item is supported
 */


>Index: prototypes/wcap/sun-calendar-event-dialog.js
>===================================================================
Why do you undo the capabilities changes in this file? I think this is not intended? While



r=philipp with comments addressed

Comment 9

[Berend Cornelius]

I checked in the patch on trunk and MOZILLA_1_8_BRANCH. I adressed the issues of philipp.
>Why do you undo the capabilities changes in this file? I think this is not
>intended? While
I don't quite understand what you mean as I did not undo these changes. I just shifted them to calUtils.js. Before I set the issue to "Fixed" we should probably get clear on that.

Comment 10

[Stefan Sitter [:ssitter]]

This checkin broke the event/task dialog, see Bug 417508.

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

I see what you mean. Setting this to fixed since I have a patch attached to the regression fix bug.

Comment 12

[Andreas Treumann]

Checked in nightly build 2008022018 -> task is fixed and verified.