413208 - About Firefox dialog should use 'Close' instead of 'Ok' button

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[u294409]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b3pre) Gecko/2008011904 Fedora/8 (Moonshine) Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b3pre) Gecko/2008011904 Fedora/8 (Moonshine) Minefield/3.0b3pre

"ok" button indicates saving changes and closing window.
about dialog has no changes to do, so "close" button should be used instead of "ok".

Reproducible: Always

Actual Results:  
wrong button used

Expected Results:  
everything ok

Comment 1

[u294409]

Hey, now it's inconsistent.
Bug about "About Firefox dialog" in Firefox/Menus.

dialog !== menu

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

"OK" is what's used on Windows. Is this a Linux-specific bug?

Comment 3

[u88484]

Mike that is what this bug is about, the button should be 'Close' instead of 
'Ok'. 

Comment 4

[Jonathan Haas]

Attachment: GNOME uses "&Close" for the button and "r" for the Credits accesskey

GNOME generally uses "&Close" for the "OK"-Button and "C&redits" for the "Credits"-Button. (& means accesskey)

This patch makes Firefox to use these standardized labels under Unix without affecting Windows and other OS.

This is my second patch, so please tell me, if there's something wrong with it.

Comment 5

[Jonathan Haas]

Attachment: Added space

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 333151 [details] [diff] [review]
Added space


>+<!ENTITY closeCmd.labelGNOME        "Close">  
>+<!ENTITY closeCmd.accesskeyGNOME    "C">

please rename these to closeCmdGNOME.label and closeCmdGNOME.accesskey, the suffixes are used by some translation tools.  Otherwise r=me

Comment 7

[Jonathan Haas]

Attachment: Fixed comment

I don't have to request superreview, have I?

Comment 8

[Jonathan Haas]

Attachment: Accidently killed space again

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 334451 [details] [diff] [review]
Accidently killed space again

>+<!ENTITY copyright.accesskeyGNOME   "r">

this is still wrong (copyright.accesskeyGNOME vs. copyrightGNOME.accesskey)

Comment 10

[Jonathan Haas]

(In reply to comment #9)
> (From update of attachment 334451 [details] [diff] [review])
> >+<!ENTITY copyright.accesskeyGNOME   "r">
> 
> this is still wrong (copyright.accesskeyGNOME vs. copyrightGNOME.accesskey)

I think Connor wanted me to change only the two entities. copyright.accesskeyGNOME has a version without "GNOME" as in preferences.dtd

Otherwise, I can change this, too, of course.

Comment 11

[Jonathan Haas]

Attachment: patch with copyrightGNOME.accesskey

Changed copyright.accesskeyGNOME to copyrightGNOME.accesskey

Comment 12

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/04157a97d3f1

Comment 13

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b1pre) Gecko/20081001 Minefield/3.1b1pre.