364360 - Focus issue with Help -> About

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Bill Gianopoulos [:WG9s]]

There are several issues related to keyboard focus on the Help -> About page.

1.  When the User Agent textbox has keyboard focus, the focus ring is on the OK button and not on the textbox.

2.  When the User Agent textbox has focus, a text cursor appears even though no data input is possible in the filed.  I suppose this could be useful if you want to use the keyboard to select just a portion of the string.

3.  When you first open Help -> About the User Agent textbox has focus rather than the OK button.  This in itself would not be an issue except for issue number 2 being present.  The resultant sate of these 2 things in combination results in the User Agent string displayed when you go to Help -> About appearing to have a '|' at the end of the string.  This could be misread by a user as a '1' resulting in confusion over version numbers etc.

So, I think problem number one needs to be fixed in either case, and for the other problem, either the text cursor needs to be removed or the window should open with focus on the OK button as it does in Firefox 2.

Comment 1

[Bill Gianopoulos [:WG9s]]

OK.  It has been brought to my attention that the OK button does not have a focus ring when the textbox has focus.  What it does have is a blue outline that indicates that it designated the action to be performed when you press the enter key.  The focus ring is actually a thin line of dots that is just inside the blue ring which indicates that the button indicates the action to be performed when you press the space bar.

So, the 3 issues here are that in the latest nightly the UA string looks like it says " ... Minefield/3.0a2prel", there is no focus ring displayed when the UA string is focused and (in my opinion) there is not enough visual difference between the default button and the focused button.

Comment 2

[Brian Polidoro]

The focus ring visibility problem is that it needs to invert the color that it's shown over. (Bug 359497)  Otherwise the focus ring is the same as is done with native windows apps.  

Comment 3

[Bill Gianopoulos [:WG9s]]

OK.  Ignoring the issue of the visual distinction of the focus ring (which iI have determined is only in Luna, looks fine in Windows classic), the initial focus is definitely a bug.

This was previously fixed in Bug 216722 - Initial focus in Help|About Mozilla Firefox should be "OK".

A quick look at the source indicates that the JS code still specifies that initial focus be on the "OK" (or "accept") button.

http://lxr.mozilla.org/seamonkey/source/browser/base/content/aboutDialog.js#50

Comment 4

[pal-moz]

regression range, 2006101804-2006101905.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> regression range, 2006101804-2006101905.

Probably a regression from bug 354089, then.

Comment 6

[-fullmetaljacket-]

status -> FIXED(?)

i can no longer reproduce this.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007101622 Minefield/3.0a9pre ID:2007101622

Comment 7

[pal-moz]

Attachment: screenshot

(In reply to comment #6)
> status -> FIXED(?)
> 
> i can no longer reproduce this.
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007101622
> Minefield/3.0a9pre ID:2007101622
> 

I can reproduce.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007101800 Minefield/3.0a9pre ID:2007101800

Comment 8

[Masahiro YAMADA]

It this still reproduced? 
I cannot reproduce this bug with recent trunk.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081105 Minefield/3.1b2pre

Comment 9

[Masahiro YAMADA]

Patch for bug 413208 contains setting focus to acceptButton.

http://hg.mozilla.org/mozilla-central/rev/04157a97d3f1

I think this bug is fixed by it.

Comment 10

[Bill Gianopoulos [:WG9s]]

Indeed it is.

Comment 11

[Wayne Mery (:wsmwk)]

bug 413208 didn't change this, but I'd like to find the bug that did because there is a regression - Bug 464033 - help|about gets lost. 

Behavior on windows changed 2008-10-11 (and in thunderbird on 2008-10-1) but 413208 landed much earlier, in september. Also, 413208 is stated to be a linux-only bug.

bug 446098 is probable dupe

Comment 12

[Wayne Mery (:wsmwk)]

aleksej, any idea what fixed this? 446098 a dupe?