413217 - Need an NS_ENSURE_SUCCESS that doesn't warn

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

It sometimes amazes me how long trivial problems are left unfixed.

I personally prefer the clarity of specifying returned errors inline, but it's existing style not to do so.  I erred on the side of over-providing no-warn variants, so feel free to say something if you don't think they're all needed.

Comment 1

[Benjamin Smedberg]

Comment on attachment 298104 [details] [diff] [review]
Patch

I don't want to do this... I prefer the explicit if() return pair if we don't want the warning, because it makes it easier to scan code and see exit points.