413430 - Nothing downloads. No saving pictures, no downloading files and etc.

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Kevin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2) Gecko/2007121120 Firefox/3.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2) Gecko/2007121120 Firefox/3.0b2

If you try to save a picture, it won't download. If you try to download a file or anything for that matter, won't do. If you try to change download preferences [download location, etc.], nothing works.

Reproducible: Always

Steps to Reproduce:
1.Find an image
2.Right click and press "Save image as..."
3.Nothing happens
or
1.Download something like a program setup
2.Nothing happens
or
1.Click "Tools"
2.Press "Options"
3.In the "General" tab under "Downloads", try to add or change a location
4.Nothing happens
Actual Results:  
Nothing happens

Expected Results:  
In first reproduction, it should've opened the "Save as..." window
In the second, it should've activated the Download Manager and started getting my file
In the third, it should've opened a browse box in order to select a place to automatically save my downloads

Comment 1

[Kevin]

This is Mozilla FireFox 3 Beta 2 in which this occurs

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Kevin: are there any download manager-related errors in the Error Console, in Tools?

Also, are you running any extensions?  If so, which ones?  Lastly, have you tried this in Safe Mode?

http://support.mozilla.com/kb/Safe+Mode

Comment 3

[Kevin]

I just went to try to save some random picture and got this in the Error Console

Error: uncaught exception: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: chrome://global/content/contentAreaUtils.js :: getTargetFile :: line 428"  data: no]

No extensions are being ran and yes, I just tried in Safe Mode and same error happens

Comment 4

[Marcia Knous [:marcia]]

I am not able to reproduce this using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008012204 Minefield/3.0b3pre. 

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Kevin: it probably didn't, but have you upgraded to Firefox 3 beta 3, and if so, did it fix this (or change the error message at all)?

Comment 6

[Kevin]

Same issues in FireFox 3 Beta 3

Error: uncaught exception: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: chrome://global/content/contentAreaUtils.js :: getTargetFile :: line 431"  data: no]

And now the Download Manager won't even open and I get this message

Error: uncaught exception: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: file:///C:/Program%20Files/Mozilla%20Firefox%203%20Beta%203/components/nsDownloadManagerUI.js :: show :: line 80"  data: no]

Comment 7

[Shawn Wilsher :sdwilsh]

This is starting to look a lot like bug 409179, but without the crash :/

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Kevin, can you attach your mimeTypes.rdf file?

Comment 9

[Kevin]

Here's the file itself if that's what you mean by attach

http://www.mediafire.com/?agdzjyydndo

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #9)
> Here's the file itself if that's what you mean by attach
> 
> http://www.mediafire.com/?agdzjyydndo

Thanks; I dropped your mimeTypes.rdf into my Mozilla profile on Vista, and can't reproduce the problem.  Sigh; Shawn, any idea what other files we'd need to use to reproduce the issue?

Comment 11

[Shawn Wilsher :sdwilsh]

downloads.sqlite is probably corrupted somehow :/

Comment 12

[Kevin]

I just uploaded it as well as the other download file if you want to take a look at it

http://www.mediafire.com/?dm4n0gh0uvz

Comment 13

[Michael Kamrath]

Duplicated bug (same error codes as Kevin) using Slackware Linux with kernel 2.6.21.5-smp, window manager: WindowMaker. FireFox 3 Beta 3

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

If you folks are fine with it, can you please attach your downloads.sqlite?  (We'll be able to see which files you've downloaded, so if you do attach/post a link to it, make sure you prune of any sensitive info.)

Comment 15

[Kevin]

Link in my last post to my downloads.sqlite

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Kevin: yes, thanks; I meant that if Michael could reproduce with his own downloads.sqlite, he could attach so we could try to ensure we caught all error conditions (I wasn't clear).

I *can* reproduce using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008030607 Minefield/3.0b5pre with your downloads.sqlite (but not your downloads.rdf) file dropped into my profile on Windows XP SP2.

Shawn, I'm starting to see an increasing number of these again, and it's worrisome; can we start looking at these soonish?

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+2]]

In my opinion in sounds really like bug 410680 but with better testcases. I could have a look at this issue later today.

Comment 18

[Mike Beltzner [:beltzner, not reading bugmail]]

Only two reporters and no confirmed STR means not blocking for now, but I encourage Henrik and Stephen to keep looking into it and others to watch for dupes.

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #18)
> Only two reporters and no confirmed STR means not blocking for now, but I
> encourage Henrik and Stephen to keep looking into it and others to watch for
> dupes.

https://bugzilla.mozilla.org/show_bug.cgi?id=413430#c16 is "confirmed STR".

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #19)
> https://bugzilla.mozilla.org/show_bug.cgi?id=413430#c16 is "confirmed STR".

Stephen, but it doesn't show what special action corrupts this downloads.sqlite file. We can only see the results. It would be juicy to get such STR.

Comment 22

[Stephen Donner [:stephend] Not actively reading bugmail]

Sure, but we've safe-guarded against DB corruption in the past with some success; we should try to bulletproof where we can.

Comment 23

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008030804 Minefield/3.0b5pre ID:2008030804

I copied the downloads.sqlite into my test profile and did some investigation.

The failure is within nsDownloadManager::Init() so we don't get a gDownloadManagerService instance. I stepped into the different functions. Here the examined stack:

#0  nsDownload::IsPaused (this=0x1e22d060) at /Shared/Mozilla/Trunk/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp:2602
#1  0x1484847d in nsDownload::Resume (this=0x1e22d060) at /Shared/Mozilla/Trunk/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp:2526
#2  0x14848fb4 in nsDownloadManager::ResumeRetry (this=0x1e77cf60, aDl=0x1e22d060) at /Shared/Mozilla/Trunk/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp:147
#3  0x148490d8 in nsDownloadManager::ResumeAllDownloads (this=0x1e77cf60, aResumeAll=0) at /Shared/Mozilla/Trunk/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp:202
#4  0x14849486 in nsDownloadManager::RestoreActiveDownloads (this=0x1e77cf60) at /Shared/Mozilla/Trunk/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp:772
#5  0x148499c1 in nsDownloadManager::Init (this=0x1e77cf60) at /Shared/Mozilla/Trunk/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp:897

Checking frame 0 gives following value:
(gdb) frame 0
#0  nsDownload::IsPaused (this=0x1e22d060) at /Shared/Mozilla/Trunk/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp:2602
2602	  return mDownloadState == nsIDownloadManager::DOWNLOAD_PAUSED;
(gdb) p mDownloadState
$12 = 5

Caller that will return NS_ERROR_UNEXPECTED:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp&rev=1.169&mark=2526-2527&#2523

Shawn, is this enough information for you to dig into?

Comment 24

[Shawn Wilsher :sdwilsh]

That looks a lot like a bug we already fixed - what is the build id of what you got those stack frames from?

Comment 25

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I'm still fetching the current source before running a debug session. The current build id is Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008030823 Minefield/3.0b5pre ID:2008030823

Comment 26

[Ed Lee :Mardak]

This should be fixed by bug 412360.

Comment 27

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008030904 Minefield/3.0b5pre ID:2008030904. It works perfectly now.

When copying the downloads.sqlite into the profile and trying to save a file an error dialog pop-up which tells that a download cannot be saved because the source file cannot be read. The appropriate download link is "javascript:topMenu.openClose();". The Error Console also shows an exception in retryDownload. I'll file a new bug about this issue if there is not already one.

Comment 28

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Filed bug 421818 for the remaining issue.