Status

()

Firefox
Theme
P2
normal
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: micmon, Assigned: Michael Ventnor)

Tracking

Trunk
Firefox 3 beta3
x86
Linux
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(15 attachments, 10 obsolete attachments)

55.03 KB, application/x-zip-compressed
Details
12.77 KB, patch
rflint
: review+
Details | Diff | Splinter Review
12.04 KB, image/png
Details
862 bytes, image/png
Details
840 bytes, image/png
Details
575 bytes, image/png
Details
4.08 KB, image/png
beltzner
: approval1.9b3+
Details
655 bytes, image/png
beltzner
: approval1.9b3+
Details
712 bytes, image/png
beltzner
: approval1.9b3+
Details
767 bytes, image/png
beltzner
: approval1.9b3+
Details
799 bytes, image/png
beltzner
: approval1.9b3+
Details
1.23 KB, image/png
beltzner
: approval1.9b3+
Details
2.60 KB, image/png
beltzner
: approval1.9b3+
Details
2.20 KB, image/png
beltzner
: approval1.9b3+
Details
979 bytes, patch
rflint
: review+
beltzner
: approval1.9b3+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
This is the current M1/M2 tango set (still waiting for approval for the actual artwork) applied to the current bitmaps. Some are drop-in replacements, but some require minor CSS patching:

browser/preferences/Options.png, browser/Go-arrow.png,
browser/Go-arrow-rtl.png, browser/Secure.png,
browser/Secure-broken.png: We only use the normal state now, so the rest has been removed. Hover/Active states referencing those images can be removed.

global/icons/find.png: Same as above, as we use the GTK arrows now an the button is not supposed to change between marked/unmarked anymore.

global/Filepicker.png: This is not officialy in the icon inventory anymore, but the folder-new part of it is still used in the legacy filepicker, so I included a tangofied version for this.

The rest just needs replacing of the image with the same name. Would be nice if someone could prepare the patch so that this can go in before beta 3 when the artwork is approved.
(Reporter)

Comment 1

11 years ago
There are a few more M2 icons we have, but I don't see them used in the UI yet:

always-ask (16), wrong-way (16, 64), key (24), popup-blocked (24x24)

I can provide those too, if someone knows where to insert them.

Flags: blocking-firefox3?
(Reporter)

Comment 2

11 years ago
Created attachment 298501 [details]
Icons
(Assignee)

Comment 3

11 years ago
Created attachment 298541 [details] [diff] [review]
Patch

I noticed that the 16x16 search button for the search bar is not included, is that not M2?
Assignee: nobody → ventnor.bugzilla
Status: NEW → ASSIGNED
Attachment #298541 - Flags: review?(rflint)
(Reporter)

Comment 4

11 years ago
Thanks Michael. The search icon is M2 according to the sheet Alex sent me... we have it ready though... so if you want to have it in for beta3, no big deal
(Reporter)

Comment 5

11 years ago
Created attachment 298549 [details]
Search (16x16)
(Assignee)

Comment 6

11 years ago
Created attachment 298551 [details] [diff] [review]
Patch 2

Thanks. Can you attach the RTL version as well? Those files' names are Search-glass.png and Search-glass-rtl.png
Attachment #298541 - Attachment is obsolete: true
Attachment #298551 - Flags: review?(rflint)
Attachment #298541 - Flags: review?(rflint)
(Reporter)

Comment 7

11 years ago
Created attachment 298552 [details]
Search RTL (16x16)
(Assignee)

Comment 8

11 years ago
Created attachment 298565 [details] [diff] [review]
Patch 3

Update the feed icons.
Attachment #298551 - Attachment is obsolete: true
Attachment #298565 - Flags: review?(rflint)
Attachment #298551 - Flags: review?(rflint)
(Assignee)

Comment 9

11 years ago
Created attachment 298576 [details] [diff] [review]
Patch 3.1

Missed a spot in Places.
Attachment #298565 - Attachment is obsolete: true
Attachment #298576 - Flags: review?(rflint)
Attachment #298565 - Flags: review?(rflint)
(Assignee)

Comment 10

11 years ago
Created attachment 298577 [details] [diff] [review]
Patch 3.2

Sorry, that patch had a bad jar.mn
Attachment #298576 - Attachment is obsolete: true
Attachment #298577 - Flags: review?(rflint)
Attachment #298576 - Flags: review?(rflint)
Land part one -- drop-in replacements

Checking in browser/themes/gnomestripe/browser/Toolbar-small.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Toolbar-small.png,v  <--  Toolbar-small.png
new revision: 1.8; previous revision: 1.7
done
Checking in browser/themes/gnomestripe/browser/Toolbar.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Toolbar.png,v  <--  Toolbar.png
new revision: 1.8; previous revision: 1.7
done
Checking in browser/themes/gnomestripe/browser/identity.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/identity.png,v  <--  identity.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/feeds/feedIcon.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/feeds/feedIcon.png,v  <--  feedIcon.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/gnomestripe/browser/feeds/feedIcon16.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/feeds/feedIcon16.png,v  <--  feedIcon16.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/places/pageStarred.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/pageStarred.png,v  <--  pageStarred.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/gnomestripe/browser/places/starPage.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/starPage.png,v  <--  starPage.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/tabbrowser/tabDragIndicator.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/tabbrowser/tabDragIndicator.png,v  <--  tabDragIndicator.png
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/gnomestripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/jar.mn,v  <--  jar.mn
new revision: 1.28; previous revision: 1.27
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/filepicker/Filepicker.png,v
done
Checking in toolkit/themes/gnomestripe/global/filepicker/Filepicker.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/filepicker/Filepicker.png,v  <--  Filepicker.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/find.png,v
done
Checking in toolkit/themes/gnomestripe/global/icons/find.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/find.png,v  <--  find.png
initial revision: 1.1
done
Checking in toolkit/themes/gnomestripe/global/icons/wrap.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/wrap.png,v  <--  wrap.png
new revision: 1.2; previous revision: 1.1
done
(In reply to comment #0)
> browser/preferences/Options.png, browser/Go-arrow.png,
> browser/Go-arrow-rtl.png, browser/Secure.png,
> browser/Secure-broken.png: We only use the normal state now, so the rest has
> been removed. Hover/Active states referencing those images can be removed.

Will land these when the CSS lands.

> global/icons/find.png: Same as above, as we use the GTK arrows now an the
> button is not supposed to change between marked/unmarked anymore.

Went ahead and landed this now, as it's not used.

> global/Filepicker.png: This is not officialy in the icon inventory anymore, but
> the folder-new part of it is still used in the legacy filepicker, so I included
> a tangofied version for this.

I went ahead and landed this, but since the CSS hasn't landed, the legacy filepicker is broken. Not really a problem, but the CSS needs to be fixed. Ventron, please add this to your patch?

> The rest just needs replacing of the image with the same name. Would be nice if
> someone could prepare the patch so that this can go in before beta 3 when the
> artwork is approved.

The rest are all landed, as far as I can tell. :)
(Assignee)

Comment 13

11 years ago
Created attachment 298753 [details] [diff] [review]
Patch 4

Adds filepicker CSS.
Attachment #298577 - Attachment is obsolete: true
Attachment #298753 - Flags: review?(rflint)
Attachment #298577 - Flags: review?(rflint)
(Reporter)

Comment 14

11 years ago
Created attachment 298948 [details]
Options icons, updated

Please use this Options.png, it has an updated Content icon featuring the same chinese character the other platforms will use.
(Reporter)

Comment 15

11 years ago
Created attachment 298950 [details]
Search (16x16) (updated)

Another small fix for the LTR search icon
Attachment #298549 - Attachment is obsolete: true
(Reporter)

Comment 16

11 years ago
Created attachment 298951 [details]
Search RTL (16x16) (updated)

Another small fix for the RTL search icon
Attachment #298552 - Attachment is obsolete: true
Attachment #298753 - Flags: review?(rflint) → review+
Attachment #298753 - Flags: approval1.9?

Comment 17

11 years ago
Moving to the blocking list so you don't have to get patch approvals
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Keywords: checkin-needed
Attachment #298753 - Flags: approval1.9?
Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.158; previous revision: 1.157
done
Checking in browser/themes/gnomestripe/browser/searchbar.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/searchbar.css,v  <--  searchbar.css
new revision: 1.24; previous revision: 1.23
done
Checking in browser/themes/gnomestripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/places.css,v  <--  places.css
new revision: 1.23; previous revision: 1.22
done
Checking in browser/themes/gnomestripe/browser/preferences/preferences.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/preferences.css,v  <--  preferences.css
new revision: 1.26; previous revision: 1.25
done
Checking in toolkit/themes/gnomestripe/global/filepicker.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/filepicker.css,v  <--  filepicker.css
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/themes/gnomestripe/global/findBar.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/findBar.css,v  <--  findBar.css
new revision: 1.3; previous revision: 1.2
done
Keywords: checkin-needed
Target Milestone: --- → Firefox 3 M11
Checking in browser/themes/gnomestripe/browser/Go-arrow-rtl.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Go-arrow-rtl.png,v  <--  Go-arrow-rtl.png
new revision: 1.6; previous revision: 1.5
done
Checking in browser/themes/gnomestripe/browser/Go-arrow.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Go-arrow.png,v  <--  Go-arrow.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/Search-glass-rtl.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Search-glass-rtl.png,v  <--  Search-glass-rtl.png
new revision: 1.4; previous revision: 1.3
done
Checking in browser/themes/gnomestripe/browser/Search-glass.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Search-glass.png,v  <--  Search-glass.png
new revision: 1.4; previous revision: 1.3
done
Checking in browser/themes/gnomestripe/browser/Secure.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Secure.png,v  <--  Secure.png
new revision: 1.5; previous revision: 1.4
done
Checking in browser/themes/gnomestripe/browser/Security-broken.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Security-broken.png,v  <--  Security-broken.png
new revision: 1.5; previous revision: 1.4
done
Checking in browser/themes/gnomestripe/browser/preferences/Options.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/Options.png,v  <--  Options.png
new revision: 1.8; previous revision: 1.7
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Was this in design that search button, rss icon and star icon (both two in location bar) have no hover indicator?

Same for preferences' icons.

Comment 21

11 years ago
/classic/browser/places/starPage.png needs to be white like before, not transparent, so that you can see it on secure pages.
Comment on attachment 298753 [details] [diff] [review]
Patch 4

>Index: toolkit/themes/gnomestripe/global/filepicker.css
>===================================================================
>RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/filepicker.css,v
>retrieving revision 1.1
>diff -u -8 -p -r1.1 filepicker.css
>--- toolkit/themes/gnomestripe/global/filepicker.css	14 Dec 2007 06:58:27 -0000	1.1
>+++ toolkit/themes/gnomestripe/global/filepicker.css	23 Jan 2008 19:47:36 -0000
>@@ -85,17 +85,11 @@ treechildren::-moz-tree-image(FilenameCo
>   list-style-image: url("moz-icon://stock/gtk-home?size=toolbar");
>   max-width: 36px;
> }
> 
> /* new-dir-button */
> 
> .new-dir-button {
>   list-style-image: url("chrome://global/skin/Filepicker.png");
>-  -moz-image-region: rect(0px 72px 24px 48px);
>   max-width: 36px;
> }

This portion of the patch would seem to require a new sepearate icon for new-dir.  None was checked in.  This has resulted in a very broken file-picker menu for the case where ui.allow_platform_file_picker is false.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 299594 [details] [diff] [review]
followup patch to fix filepicker
(Reporter)

Comment 24

11 years ago
(In reply to comment #21)
> /classic/browser/places/starPage.png needs to be white like before, not
> transparent, so that you can see it on secure pages.
> 

I only found folder-new referenced in CSS. What about the other icon(s) in the old bitmap (I think it had "go up one level"?). Anything else needed?
(Reporter)

Comment 25

11 years ago
(In reply to comment #20)
> Was this in design that search button, rss icon and star icon (both two in
> location bar) have no hover indicator? Same for preferences' icons.
> 

Sure! You, of all, should now best: GTK/GNOME does not use hover/active/pressed states ;)
(Reporter)

Comment 26

11 years ago
(In reply to comment #21)
> /classic/browser/places/starPage.png needs to be white like before, not
> transparent, so that you can see it on secure pages.
> 

Why that? It's totally visible this way.
(Reporter)

Comment 27

11 years ago
Created attachment 299612 [details]
Another M2 icon (always-ask)

This is a new icon, it is meant to be used for the "Always ask" action in the Applications preferences (currently this uses the generic application icon).

Comment 28

11 years ago
(In reply to comment #26)
> (In reply to comment #21)
> > /classic/browser/places/starPage.png needs to be white like before, not
> > transparent, so that you can see it on secure pages.
> > 
> 
> Why that? It's totally visible this way.
> 

Bug 392427.
Depends on: 409288
Comment on attachment 299594 [details] [diff] [review]
followup patch to fix filepicker

Not needed... I screwed the jar.mn change. :)

Fixed now.

Checking in jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/jar.mn,v  <--  jar.mn
new revision: 1.30; previous revision: 1.29
done
Attachment #299594 - Attachment is obsolete: true
RCS file: /cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/alwaysAsk.png,v
done
Checking in alwaysAsk.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/alwaysAsk.png,v  <--  alwaysAsk.png
initial revision: 1.1
done
(Reporter)

Comment 31

11 years ago
The alwaysAsk.png icon is in the .jar now, but it is still not being used in the UI.
(In reply to comment #31)
> The alwaysAsk.png icon is in the .jar now, but it is still not being used in
> the UI.

That's bug 398627.
(In reply to comment #25)
> (In reply to comment #20)
> > Was this in design that search button, rss icon and star icon (both two in
> > location bar) have no hover indicator? Same for preferences' icons.
> > 
> 
> Sure! You, of all, should now best: GTK/GNOME does not use hover/active/pressed
> states ;)
> 
This seems to be distro/theme dependent.
The Bluecurve theme which is the default for Redhat/fedora seems to use them.
(Reporter)

Comment 34

11 years ago
(In reply to comment #33)
> This seems to be distro/theme dependent.
no

> The Bluecurve theme which is the default for Redhat/fedora seems to use them.
For what exactly? GTK does not allow for something like this.

(In reply to comment #34)
> (In reply to comment #33)
> > This seems to be distro/theme dependent.
> no
> 
> > The Bluecurve theme which is the default for Redhat/fedora seems to use them.
> For what exactly? GTK does not allow for something like this.
> 
Well I guess you are right.  They are only used on the desktop itself.  None of the applications seem to use them.
> GTK does not allow for something like this.
Are you sure? Try out Aurora engine (you can find it on GNOME Look).

It's ugly, hacky, Murrina and Clearlooks based engine, which uses custom hover effect.
(Reporter)

Comment 37

11 years ago
(In reply to comment #36)
> > GTK does not allow for something like this.
> Are you sure? Try out Aurora engine (you can find it on GNOME Look).
I did. I don't know how aurora does this... but it is a "bug" (or missing feature) in Firefox's GTK style emulation. And if you have a look at the preferences window with aurora, you will notice that those images do not have another style for hover, as aurora only uses this hack for buttons.

> It's ugly, hacky, Murrina and Clearlooks based engine, which uses custom hover
> effect.
Parts of aurora look nice and fancy but it's really more like a hack than a usable engine, so this should really not be taken as a base to what a "native" look of firefox should be.
(In reply to comment #20)
> Was this in design that search button, rss icon and star icon (both two in
> location bar) have no hover indicator?
> 
> Same for preferences' icons.
> 
Well, if you want this you could add the following to your userChrome.css file:

#feed-button:hover {
  opacity: 0.6 !important;
}
#go-button:hover {
  opacity: 0.6 !important;
}
#star-button:hover {
  opacity: 0.6 !important;
}
.search-go-button:hover {
  opacity: 0.6 !important;
}
Oops! Forgot the preferences:

#feed-button:hover {
  opacity: 0.6 !important;
}
#go-button:hover {
  opacity: 0.6 !important;
}
#star-button:hover {
  opacity: 0.6 !important;
}
.search-go-button:hover {
  opacity: 0.6 !important;
}
#BrowserPreferences radio[pane]:hover {
  background-color: rgb(193,210,238);
}
(Reporter)

Comment 40

11 years ago
Created attachment 300157 [details]
Wrong-way (64x64)
(Reporter)

Comment 41

11 years ago
Created attachment 300158 [details]
Wrong-way (16x16)
Keywords: checkin-needed
We're missing a Tango-fied version of feedIcon16.png. I copied the new XP one for now, but it would be nice to use a Tango version. Basically, take feedIcon.png and make it 16x16 for feedIcon16.png. :)
Wrong-way icons...

Checking in browser/themes/gnomestripe/browser/safebrowsing/warning16x16.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/safebrowsing/warning16x16.png,v  <--  warning16x16.png
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/browser/themes/gnomestripe/browser/safebrowsing/warning64x64.png,v
done
Checking in browser/themes/gnomestripe/browser/safebrowsing/warning64x64.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/safebrowsing/warning64x64.png,v  <--  warning64x64.png
initial revision: 1.1
done
Keywords: checkin-needed
Created attachment 300323 [details] [diff] [review]
Use warning64x64.png for phishing/malware protection pages - v1

It would be nice to use the new warning64x64.png image instead of gtk-dialog-error for the malware/phishing protection notification page. The current icon is 48x48, but I think the 64x64 one will look ok...

monreal, what do you think?
Attachment #300323 - Flags: review?(rflint)
(Reporter)

Comment 45

11 years ago
Created attachment 300326 [details]
Key (16x16) as requested by Alex
(Reporter)

Comment 46

11 years ago
Created attachment 300490 [details]
Key (16x16) (final *g*)
Attachment #300326 - Attachment is obsolete: true
(Reporter)

Comment 47

11 years ago
Created attachment 300491 [details]
Popups-blocked (16x16) (update as requested)
(Reporter)

Comment 48

11 years ago
Created attachment 300492 [details]
RSS (16x16) (as requested)
(Reporter)

Comment 49

11 years ago
Created attachment 300496 [details]
Downloads notification icon (32x32)

The missing icon for the "downloads done" notification window.
So, I'd love to land these new Tango icons for b3 to go along with our super-uber-cool gnomestripe theme (which is obviously better than pinstripe or winstripe, of course!). They shouldn't cause any problems at all, and only make people wish they were using Linux instead of those other OSes. :)
Attachment #300490 - Flags: approval1.9b3?
Attachment #300491 - Flags: approval1.9b3?
Attachment #300492 - Flags: approval1.9b3?
Attachment #300496 - Flags: approval1.9b3?
(Reporter)

Comment 51

11 years ago
Created attachment 300507 [details]
Star (48x48)
Attachment #300507 - Flags: approval1.9b3?
(Reporter)

Comment 52

11 years ago
Created attachment 300511 [details]
Gray star (48x48)

This should finally complete the set for beta 3 with all the last minute changes. If someone can check the key, popups-blocked, rss and the stars icons in, this bug can be closed.
Attachment #300511 - Flags: approval1.9b3?
Attachment #300158 - Flags: approval1.9b3?
Attachment #300157 - Flags: approval1.9b3?
Comment on attachment 300323 [details] [diff] [review]
Use warning64x64.png for phishing/malware protection pages - v1

ugh. I landed this icon in the wrong place. New patch coming up.
Attachment #300323 - Attachment is obsolete: true
Attachment #300323 - Flags: review?(rflint)

Comment 54

11 years ago
a+ on everything for b3 - just land it (I'm not going to mark all the flags).

Oh - and Michael this work is awesome.
Comment on attachment 300157 [details]
Wrong-way (64x64)

a=beltzner for beta 3
Attachment #300157 - Flags: approval1.9b3? → approval1.9b3+
Comment on attachment 300158 [details]
Wrong-way (16x16)

a=beltzner for beta 3
Attachment #300158 - Flags: approval1.9b3? → approval1.9b3+
Comment on attachment 300490 [details]
Key (16x16) (final *g*)

a=beltzner for beta 3
Attachment #300490 - Flags: approval1.9b3? → approval1.9b3+
Comment on attachment 300491 [details]
Popups-blocked (16x16) (update as requested)

a=beltzner for beta 3
Attachment #300491 - Flags: approval1.9b3? → approval1.9b3+
Comment on attachment 300492 [details]
RSS (16x16) (as requested)

a=beltzner for beta 3
Attachment #300492 - Flags: approval1.9b3? → approval1.9b3+
Comment on attachment 300496 [details]
Downloads notification icon (32x32)

a=beltzner for beta 3
Attachment #300496 - Flags: approval1.9b3? → approval1.9b3+
Comment on attachment 300507 [details]
Star (48x48)

a=beltzner for beta 3
Attachment #300507 - Flags: approval1.9b3? → approval1.9b3+
Comment on attachment 300511 [details]
Gray star (48x48)

a=beltzner for beta 3
Attachment #300511 - Flags: approval1.9b3? → approval1.9b3+
Checking in browser/themes/gnomestripe/browser/Info.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Info.png,v  <--  Info.png
new revision: 1.5; previous revision: 1.4
done
Checking in browser/themes/gnomestripe/browser/feeds/audioFeedIcon16.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/feeds/audioFeedIcon16.png,v  <--  audioFeedIcon16.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/feeds/feedIcon16.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/feeds/feedIcon16.png,v  <--  feedIcon16.png
new revision: 1.5; previous revision: 1.4
done
Checking in browser/themes/gnomestripe/browser/feeds/videoFeedIcon16.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/feeds/videoFeedIcon16.png,v  <--  videoFeedIcon16.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/places/starred48.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/starred48.png,v  <--  starred48.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/gnomestripe/browser/places/unstarred48.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/unstarred48.png,v  <--  unstarred48.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/gnomestripe/browser/safebrowsing/warning16x16.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/safebrowsing/warning16x16.png,v  <--  warning16x16.png
new revision: 1.5; previous revision: 1.4
done
Removing browser/themes/gnomestripe/browser/safebrowsing/warning64x64.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/safebrowsing/warning64x64.png,v  <--  warning64x64.png
new revision: delete; previous revision: 1.1
done
Checking in toolkit/themes/gnomestripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/jar.mn,v  <--  jar.mn
new revision: 1.31; previous revision: 1.30
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/blacklist_favicon.png,v
done
Checking in toolkit/themes/gnomestripe/global/icons/blacklist_favicon.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/blacklist_favicon.png,v  <--  blacklist_favicon.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/blacklist_large.png,v
done
Checking in toolkit/themes/gnomestripe/global/icons/blacklist_large.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/blacklist_large.png,v  <--  blacklist_large.png
initial revision: 1.1
done
Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.7; previous revision: 1.6
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/downloads/downloadIcon.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/downloads/downloadIcon.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/downloads/downloadIcon.png,v  <--  downloadIcon.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/passwordmgr/key.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/passwordmgr/key.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/passwordmgr/key.png,v  <--  key.png
initial revision: 1.1
done
Created attachment 300615 [details] [diff] [review]
CSS for new blacklist_large.png

Change netError.css to use the new blacklist_large.png. This matches exactly what pinstripe and winstripe do.
Attachment #300615 - Flags: review?(rflint)
Attachment #300615 - Flags: review?(rflint) → review+
Comment on attachment 300615 [details] [diff] [review]
CSS for new blacklist_large.png

Super-simple patch to actually use one of the new icons. This matches exactly what winstripe and pinstripe currently do.
Attachment #300615 - Flags: approval1.9b3?
Component: OS Integration → Theme
QA Contact: os.integration → theme
Comment on attachment 300615 [details] [diff] [review]
CSS for new blacklist_large.png

a=beltzner for super-simple change :)
Attachment #300615 - Flags: approval1.9b3? → approval1.9b3+
Checking in toolkit/themes/gnomestripe/global/netError.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/netError.css,v  <--  netError.css
new revision: 1.2; previous revision: 1.1
done
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.