413471 - M2 Tango

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Michael Monreal [:micmon]]

This is the current M1/M2 tango set (still waiting for approval for the actual artwork) applied to the current bitmaps. Some are drop-in replacements, but some require minor CSS patching:

browser/preferences/Options.png, browser/Go-arrow.png,
browser/Go-arrow-rtl.png, browser/Secure.png,
browser/Secure-broken.png: We only use the normal state now, so the rest has been removed. Hover/Active states referencing those images can be removed.

global/icons/find.png: Same as above, as we use the GTK arrows now an the button is not supposed to change between marked/unmarked anymore.

global/Filepicker.png: This is not officialy in the icon inventory anymore, but the folder-new part of it is still used in the legacy filepicker, so I included a tangofied version for this.

The rest just needs replacing of the image with the same name. Would be nice if someone could prepare the patch so that this can go in before beta 3 when the artwork is approved.

Comment 1

[Michael Monreal [:micmon]]

There are a few more M2 icons we have, but I don't see them used in the UI yet:

always-ask (16), wrong-way (16, 64), key (24), popup-blocked (24x24)

I can provide those too, if someone knows where to insert them.

Comment 2

[Michael Monreal [:micmon]]

Attachment: Icons

Comment 3

[Michael Ventnor]

Attachment: Patch

I noticed that the 16x16 search button for the search bar is not included, is that not M2?

Comment 4

[Michael Monreal [:micmon]]

Thanks Michael. The search icon is M2 according to the sheet Alex sent me... we have it ready though... so if you want to have it in for beta3, no big deal

Comment 5

[Michael Monreal [:micmon]]

Attachment: Search (16x16)

Comment 6

[Michael Ventnor]

Attachment: Patch 2

Thanks. Can you attach the RTL version as well? Those files' names are Search-glass.png and Search-glass-rtl.png

Comment 7

[Michael Monreal [:micmon]]

Attachment: Search RTL (16x16)

Comment 8

[Michael Ventnor]

Attachment: Patch 3

Update the feed icons.

Comment 9

[Michael Ventnor]

Attachment: Patch 3.1

Missed a spot in Places.

Comment 10

[Michael Ventnor]

Attachment: Patch 3.2

Sorry, that patch had a bad jar.mn

Comment 11

[Reed Loden [:reed]]

Land part one -- drop-in replacements

Checking in browser/themes/gnomestripe/browser/Toolbar-small.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Toolbar-small.png,v  <--  Toolbar-small.png
new revision: 1.8; previous revision: 1.7
done
Checking in browser/themes/gnomestripe/browser/Toolbar.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Toolbar.png,v  <--  Toolbar.png
new revision: 1.8; previous revision: 1.7
done
Checking in browser/themes/gnomestripe/browser/identity.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/identity.png,v  <--  identity.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/feeds/feedIcon.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/feeds/feedIcon.png,v  <--  feedIcon.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/gnomestripe/browser/feeds/feedIcon16.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/feeds/feedIcon16.png,v  <--  feedIcon16.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/places/pageStarred.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/pageStarred.png,v  <--  pageStarred.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/gnomestripe/browser/places/starPage.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/starPage.png,v  <--  starPage.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/tabbrowser/tabDragIndicator.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/tabbrowser/tabDragIndicator.png,v  <--  tabDragIndicator.png
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/gnomestripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/jar.mn,v  <--  jar.mn
new revision: 1.28; previous revision: 1.27
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/filepicker/Filepicker.png,v
done
Checking in toolkit/themes/gnomestripe/global/filepicker/Filepicker.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/filepicker/Filepicker.png,v  <--  Filepicker.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/find.png,v
done
Checking in toolkit/themes/gnomestripe/global/icons/find.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/find.png,v  <--  find.png
initial revision: 1.1
done
Checking in toolkit/themes/gnomestripe/global/icons/wrap.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/wrap.png,v  <--  wrap.png
new revision: 1.2; previous revision: 1.1
done

Comment 12

[Reed Loden [:reed]]

(In reply to comment #0)
> browser/preferences/Options.png, browser/Go-arrow.png,
> browser/Go-arrow-rtl.png, browser/Secure.png,
> browser/Secure-broken.png: We only use the normal state now, so the rest has
> been removed. Hover/Active states referencing those images can be removed.

Will land these when the CSS lands.

> global/icons/find.png: Same as above, as we use the GTK arrows now an the
> button is not supposed to change between marked/unmarked anymore.

Went ahead and landed this now, as it's not used.

> global/Filepicker.png: This is not officialy in the icon inventory anymore, but
> the folder-new part of it is still used in the legacy filepicker, so I included
> a tangofied version for this.

I went ahead and landed this, but since the CSS hasn't landed, the legacy filepicker is broken. Not really a problem, but the CSS needs to be fixed. Ventron, please add this to your patch?

> The rest just needs replacing of the image with the same name. Would be nice if
> someone could prepare the patch so that this can go in before beta 3 when the
> artwork is approved.

The rest are all landed, as far as I can tell. :)

Comment 13

[Michael Ventnor]

Attachment: Patch 4

Adds filepicker CSS.

Comment 14

[Michael Monreal [:micmon]]

Attachment: Options icons, updated

Please use this Options.png, it has an updated Content icon featuring the same chinese character the other platforms will use.

Comment 15

[Michael Monreal [:micmon]]

Attachment: Search (16x16) (updated)

Another small fix for the LTR search icon

Comment 16

[Michael Monreal [:micmon]]

Attachment: Search RTL (16x16) (updated)

Another small fix for the RTL search icon

Comment 17

[Mike Schroepfer]

Moving to the blocking list so you don't have to get patch approvals

Comment 18

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.158; previous revision: 1.157
done
Checking in browser/themes/gnomestripe/browser/searchbar.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/searchbar.css,v  <--  searchbar.css
new revision: 1.24; previous revision: 1.23
done
Checking in browser/themes/gnomestripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/places.css,v  <--  places.css
new revision: 1.23; previous revision: 1.22
done
Checking in browser/themes/gnomestripe/browser/preferences/preferences.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/preferences.css,v  <--  preferences.css
new revision: 1.26; previous revision: 1.25
done
Checking in toolkit/themes/gnomestripe/global/filepicker.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/filepicker.css,v  <--  filepicker.css
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/themes/gnomestripe/global/findBar.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/findBar.css,v  <--  findBar.css
new revision: 1.3; previous revision: 1.2
done

Comment 19

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/Go-arrow-rtl.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Go-arrow-rtl.png,v  <--  Go-arrow-rtl.png
new revision: 1.6; previous revision: 1.5
done
Checking in browser/themes/gnomestripe/browser/Go-arrow.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Go-arrow.png,v  <--  Go-arrow.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/Search-glass-rtl.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Search-glass-rtl.png,v  <--  Search-glass-rtl.png
new revision: 1.4; previous revision: 1.3
done
Checking in browser/themes/gnomestripe/browser/Search-glass.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Search-glass.png,v  <--  Search-glass.png
new revision: 1.4; previous revision: 1.3
done
Checking in browser/themes/gnomestripe/browser/Secure.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Secure.png,v  <--  Secure.png
new revision: 1.5; previous revision: 1.4
done
Checking in browser/themes/gnomestripe/browser/Security-broken.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Security-broken.png,v  <--  Security-broken.png
new revision: 1.5; previous revision: 1.4
done
Checking in browser/themes/gnomestripe/browser/preferences/Options.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/Options.png,v  <--  Options.png
new revision: 1.8; previous revision: 1.7
done

Comment 20

[u294409]

Was this in design that search button, rss icon and star icon (both two in location bar) have no hover indicator?

Same for preferences' icons.

Comment 21

[Daniel C]

/classic/browser/places/starPage.png needs to be white like before, not transparent, so that you can see it on secure pages.

Comment 22

[Bill Gianopoulos [:WG9s]]

Comment on attachment 298753 [details] [diff] [review]
Patch 4

>Index: toolkit/themes/gnomestripe/global/filepicker.css
>===================================================================
>RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/filepicker.css,v
>retrieving revision 1.1
>diff -u -8 -p -r1.1 filepicker.css
>--- toolkit/themes/gnomestripe/global/filepicker.css	14 Dec 2007 06:58:27 -0000	1.1
>+++ toolkit/themes/gnomestripe/global/filepicker.css	23 Jan 2008 19:47:36 -0000
>@@ -85,17 +85,11 @@ treechildren::-moz-tree-image(FilenameCo
>   list-style-image: url("moz-icon://stock/gtk-home?size=toolbar");
>   max-width: 36px;
> }
> 
> /* new-dir-button */
> 
> .new-dir-button {
>   list-style-image: url("chrome://global/skin/Filepicker.png");
>-  -moz-image-region: rect(0px 72px 24px 48px);
>   max-width: 36px;
> }

This portion of the patch would seem to require a new sepearate icon for new-dir.  None was checked in.  This has resulted in a very broken file-picker menu for the case where ui.allow_platform_file_picker is false.

Comment 23

[Bill Gianopoulos [:WG9s]]

Attachment: followup patch to fix filepicker

Comment 24

[Michael Monreal [:micmon]]

(In reply to comment #21)
> /classic/browser/places/starPage.png needs to be white like before, not
> transparent, so that you can see it on secure pages.
> 

I only found folder-new referenced in CSS. What about the other icon(s) in the old bitmap (I think it had "go up one level"?). Anything else needed?

Comment 25

[Michael Monreal [:micmon]]

(In reply to comment #20)
> Was this in design that search button, rss icon and star icon (both two in
> location bar) have no hover indicator? Same for preferences' icons.
> 

Sure! You, of all, should now best: GTK/GNOME does not use hover/active/pressed states ;)

Comment 26

[Michael Monreal [:micmon]]

(In reply to comment #21)
> /classic/browser/places/starPage.png needs to be white like before, not
> transparent, so that you can see it on secure pages.
> 

Why that? It's totally visible this way.

Comment 27

[Michael Monreal [:micmon]]

Attachment: Another M2 icon (always-ask)

This is a new icon, it is meant to be used for the "Always ask" action in the Applications preferences (currently this uses the generic application icon).

Comment 28

[Daniel C]

(In reply to comment #26)
> (In reply to comment #21)
> > /classic/browser/places/starPage.png needs to be white like before, not
> > transparent, so that you can see it on secure pages.
> > 
> 
> Why that? It's totally visible this way.
> 

Bug 392427.

Comment 29

[Reed Loden [:reed]]

Comment on attachment 299594 [details] [diff] [review]
followup patch to fix filepicker

Not needed... I screwed the jar.mn change. :)

Fixed now.

Checking in jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/jar.mn,v  <--  jar.mn
new revision: 1.30; previous revision: 1.29
done

Comment 30

[Reed Loden [:reed]]

RCS file: /cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/alwaysAsk.png,v
done
Checking in alwaysAsk.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/alwaysAsk.png,v  <--  alwaysAsk.png
initial revision: 1.1
done

Comment 31

[Michael Monreal [:micmon]]

The alwaysAsk.png icon is in the .jar now, but it is still not being used in the UI.

Comment 32

[Reed Loden [:reed]]

(In reply to comment #31)
> The alwaysAsk.png icon is in the .jar now, but it is still not being used in
> the UI.

That's bug 398627.

Comment 33

[Bill Gianopoulos [:WG9s]]

(In reply to comment #25)
> (In reply to comment #20)
> > Was this in design that search button, rss icon and star icon (both two in
> > location bar) have no hover indicator? Same for preferences' icons.
> > 
> 
> Sure! You, of all, should now best: GTK/GNOME does not use hover/active/pressed
> states ;)
> 
This seems to be distro/theme dependent.
The Bluecurve theme which is the default for Redhat/fedora seems to use them.

Comment 34

[Michael Monreal [:micmon]]

(In reply to comment #33)
> This seems to be distro/theme dependent.
no

> The Bluecurve theme which is the default for Redhat/fedora seems to use them.
For what exactly? GTK does not allow for something like this.

Comment 35

[Bill Gianopoulos [:WG9s]]

(In reply to comment #34)
> (In reply to comment #33)
> > This seems to be distro/theme dependent.
> no
> 
> > The Bluecurve theme which is the default for Redhat/fedora seems to use them.
> For what exactly? GTK does not allow for something like this.
> 
Well I guess you are right.  They are only used on the desktop itself.  None of the applications seem to use them.

Comment 36

[u294409]

> GTK does not allow for something like this.
Are you sure? Try out Aurora engine (you can find it on GNOME Look).

It's ugly, hacky, Murrina and Clearlooks based engine, which uses custom hover effect.

Comment 37

[Michael Monreal [:micmon]]

(In reply to comment #36)
> > GTK does not allow for something like this.
> Are you sure? Try out Aurora engine (you can find it on GNOME Look).
I did. I don't know how aurora does this... but it is a "bug" (or missing feature) in Firefox's GTK style emulation. And if you have a look at the preferences window with aurora, you will notice that those images do not have another style for hover, as aurora only uses this hack for buttons.

> It's ugly, hacky, Murrina and Clearlooks based engine, which uses custom hover
> effect.
Parts of aurora look nice and fancy but it's really more like a hack than a usable engine, so this should really not be taken as a base to what a "native" look of firefox should be.

Comment 38

[Bill Gianopoulos [:WG9s]]

(In reply to comment #20)
> Was this in design that search button, rss icon and star icon (both two in
> location bar) have no hover indicator?
> 
> Same for preferences' icons.
> 
Well, if you want this you could add the following to your userChrome.css file:

#feed-button:hover {
  opacity: 0.6 !important;
}
#go-button:hover {
  opacity: 0.6 !important;
}
#star-button:hover {
  opacity: 0.6 !important;
}
.search-go-button:hover {
  opacity: 0.6 !important;
}

Comment 39

[Bill Gianopoulos [:WG9s]]

Oops! Forgot the preferences:

#feed-button:hover {
  opacity: 0.6 !important;
}
#go-button:hover {
  opacity: 0.6 !important;
}
#star-button:hover {
  opacity: 0.6 !important;
}
.search-go-button:hover {
  opacity: 0.6 !important;
}
#BrowserPreferences radio[pane]:hover {
  background-color: rgb(193,210,238);
}

Comment 40

[Michael Monreal [:micmon]]

Attachment: Wrong-way (64x64)

Comment 41

[Michael Monreal [:micmon]]

Attachment: Wrong-way (16x16)

Comment 42

[Reed Loden [:reed]]

We're missing a Tango-fied version of feedIcon16.png. I copied the new XP one for now, but it would be nice to use a Tango version. Basically, take feedIcon.png and make it 16x16 for feedIcon16.png. :)

Comment 43

[Reed Loden [:reed]]

Wrong-way icons...

Checking in browser/themes/gnomestripe/browser/safebrowsing/warning16x16.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/safebrowsing/warning16x16.png,v  <--  warning16x16.png
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/browser/themes/gnomestripe/browser/safebrowsing/warning64x64.png,v
done
Checking in browser/themes/gnomestripe/browser/safebrowsing/warning64x64.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/safebrowsing/warning64x64.png,v  <--  warning64x64.png
initial revision: 1.1
done

Comment 44

[Reed Loden [:reed]]

Attachment: Use warning64x64.png for phishing/malware protection pages - v1

It would be nice to use the new warning64x64.png image instead of gtk-dialog-error for the malware/phishing protection notification page. The current icon is 48x48, but I think the 64x64 one will look ok...

monreal, what do you think?

Comment 45

[Michael Monreal [:micmon]]

Attachment: Key (16x16) as requested by Alex

Comment 46

[Michael Monreal [:micmon]]

Attachment: Key (16x16) (final *g*)

Comment 47

[Michael Monreal [:micmon]]

Attachment: Popups-blocked (16x16) (update as requested)

Comment 48

[Michael Monreal [:micmon]]

Attachment: RSS (16x16) (as requested)

Comment 49

[Michael Monreal [:micmon]]

Attachment: Downloads notification icon (32x32)

The missing icon for the "downloads done" notification window.

Comment 50

[Reed Loden [:reed]]

So, I'd love to land these new Tango icons for b3 to go along with our super-uber-cool gnomestripe theme (which is obviously better than pinstripe or winstripe, of course!). They shouldn't cause any problems at all, and only make people wish they were using Linux instead of those other OSes. :)

Comment 51

[Michael Monreal [:micmon]]

Attachment: Star (48x48)

Comment 52

[Michael Monreal [:micmon]]

Attachment: Gray star (48x48)

This should finally complete the set for beta 3 with all the last minute changes. If someone can check the key, popups-blocked, rss and the stars icons in, this bug can be closed.

Comment 53

[Reed Loden [:reed]]

Comment on attachment 300323 [details] [diff] [review]
Use warning64x64.png for phishing/malware protection pages - v1

ugh. I landed this icon in the wrong place. New patch coming up.

Comment 54

[Mike Schroepfer]

a+ on everything for b3 - just land it (I'm not going to mark all the flags).

Oh - and Michael this work is awesome.

Comment 55

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300157 [details]
Wrong-way (64x64)

a=beltzner for beta 3

Comment 56

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300158 [details]
Wrong-way (16x16)

a=beltzner for beta 3

Comment 57

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300490 [details]
Key (16x16) (final *g*)

a=beltzner for beta 3

Comment 58

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300491 [details]
Popups-blocked (16x16) (update as requested)

a=beltzner for beta 3

Comment 59

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300492 [details]
RSS (16x16) (as requested)

a=beltzner for beta 3

Comment 60

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300496 [details]
Downloads notification icon (32x32)

a=beltzner for beta 3

Comment 61

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300507 [details]
Star (48x48)

a=beltzner for beta 3

Comment 62

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300511 [details]
Gray star (48x48)

a=beltzner for beta 3

Comment 63

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/Info.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/Info.png,v  <--  Info.png
new revision: 1.5; previous revision: 1.4
done
Checking in browser/themes/gnomestripe/browser/feeds/audioFeedIcon16.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/feeds/audioFeedIcon16.png,v  <--  audioFeedIcon16.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/feeds/feedIcon16.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/feeds/feedIcon16.png,v  <--  feedIcon16.png
new revision: 1.5; previous revision: 1.4
done
Checking in browser/themes/gnomestripe/browser/feeds/videoFeedIcon16.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/feeds/videoFeedIcon16.png,v  <--  videoFeedIcon16.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/gnomestripe/browser/places/starred48.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/starred48.png,v  <--  starred48.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/gnomestripe/browser/places/unstarred48.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/unstarred48.png,v  <--  unstarred48.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/gnomestripe/browser/safebrowsing/warning16x16.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/safebrowsing/warning16x16.png,v  <--  warning16x16.png
new revision: 1.5; previous revision: 1.4
done
Removing browser/themes/gnomestripe/browser/safebrowsing/warning64x64.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/safebrowsing/warning64x64.png,v  <--  warning64x64.png
new revision: delete; previous revision: 1.1
done
Checking in toolkit/themes/gnomestripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/jar.mn,v  <--  jar.mn
new revision: 1.31; previous revision: 1.30
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/blacklist_favicon.png,v
done
Checking in toolkit/themes/gnomestripe/global/icons/blacklist_favicon.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/blacklist_favicon.png,v  <--  blacklist_favicon.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/blacklist_large.png,v
done
Checking in toolkit/themes/gnomestripe/global/icons/blacklist_large.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/icons/blacklist_large.png,v  <--  blacklist_large.png
initial revision: 1.1
done
Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.7; previous revision: 1.6
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/downloads/downloadIcon.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/downloads/downloadIcon.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/downloads/downloadIcon.png,v  <--  downloadIcon.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/passwordmgr/key.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/passwordmgr/key.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/passwordmgr/key.png,v  <--  key.png
initial revision: 1.1
done

Comment 64

[Reed Loden [:reed]]

Attachment: CSS for new blacklist_large.png

Change netError.css to use the new blacklist_large.png. This matches exactly what pinstripe and winstripe do.

Comment 65

[Reed Loden [:reed]]

Comment on attachment 300615 [details] [diff] [review]
CSS for new blacklist_large.png

Super-simple patch to actually use one of the new icons. This matches exactly what winstripe and pinstripe currently do.

Comment 66

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300615 [details] [diff] [review]
CSS for new blacklist_large.png

a=beltzner for super-simple change :)

Comment 67

[Reed Loden [:reed]]

Checking in toolkit/themes/gnomestripe/global/netError.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/netError.css,v  <--  netError.css
new revision: 1.2; previous revision: 1.1
done