413557 - Facebook Toolbar add-on causes CPU and memory usage issues.

Status: RESOLVED WONTFIX

(WebExtensions :: General, defect, P2)

Description

[Carsten Book [:Tomcat]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008012105 Firefox/3.0b3pre

Steps to reproduce:
New Profile
Installed Facebook https://addons.mozilla.org/en-US/firefox/addon/3794
Played a little with this toolbar and in the background i had 3 tabs
- Firefox default Startpage
- AMO Facebook Toolbar Site
- Bugzilla Query http://tinyurl.com/2h9m7q

I click a little around the "share+" button and then i closed firefox. The Bugzilla search was still running , so it can be also related to a shutdown leak or ?

  0 TOTAL                                          23  2070560  1507000    77149 ( 3739.54 +/-  3052.00)  3098764    65017 ( 3225.98 +/-  4853.13)

Comment 1

[Carsten Book [:Tomcat]]

Attachment: leak log

Comment 2

[Damon Sicore (:damons)]

+'ing w/ P3.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I'll try to have a go at this one. Looks really bad since we're leaking lots of windows.

Guess this means I'll have to get a facebook account.

Comment 4

[Peter Van der Beken [:peterv]]

Is this really a problem with the Facebook toolbar? I get a leak by just loading that Bugzilla query and closing Firefox while it's loading, no Facebook toolbar installed. Does this leak without that Bugzilla query?

Comment 5

[Carsten Book [:Tomcat]]

(In reply to comment #4)
> Is this really a problem with the Facebook toolbar? I get a leak by just
> loading that Bugzilla query and closing Firefox while it's loading, no Facebook
> toolbar installed. Does this leak without that Bugzilla query?
> 

No leak without the query with a new build, this seems to be a Firefox Problem in General and not related to the toolbar.

Comment 6

[Peter Van der Beken [:peterv]]

I think the quit-while-loading case is an issue in session restore, I have a patch that seems to fix this one and bug 413741.

Comment 7

[Carsten Book [:Tomcat]]

will retest if, if this is now fixed by 413741

Comment 8

[Andrew McCreight [:mccr8]]

Comment from June 8, 2012 on the AMO page says there is still a memory leak problem.  Has 120k users.

Comment 9

[Kris Maglione [:kmag]]

I don't have a debug build around to run BloatView checks, but I'm not seeing anything too suspicious in about:memory. We've got three Facebook window globals sticking around, but only because they're loaded into hidden iframes. It would be nice if they went away while they weren't in use, since in total they take up ~100MB of memory while they're not needed, but I don't see any other suspicious memory usage.

Comment 10

[Kris Maglione [:kmag]]

Brian, can you have a look at this?

Comment 11

[Brian King [:kinger]]

(In reply to Kris Maglione [:kmag] from comment #10)
> Brian, can you have a look at this?

Yes.

Comment 12

[Kris Maglione [:kmag]]

Brian, have you made any progress on this?

Comment 13

[Brian King [:kinger]]

(In reply to Kris Maglione [:kmag] from comment #12)
> Brian, have you made any progress on this?

No, I haven't had time yet. I will bump it up on my priority list.

I did however do memory leak testing about a month ago, and the only leak I found was the Share window (click the Share button). Apart from that my findings were similar to yours in comment 9.

Comment 14

[Andrew McCreight [:mccr8]]

Kris, could we possibly get this addon removed from AMO or something?  Every comment on its page is talking about how it this addon uses all your CPU and memory...

Comment 15

[Kris Maglione [:kmag]]

I'll look into it. If the comments are true I can downgrade it to preliminary review or set a compatibility override, but I can't remove it entirely.

Comment 16

[Jorge Villalobos [:jorgev] (he/him)]

I think downgrading the add-on on AMO is appropriate given the apparent severity of the problem and lack of response.

Brian, do you have any contacts at FB who can help us get this fixed? Or are you still actively involved in this project?

Comment 17

[Kris Maglione [:kmag]]

To be clear, I don't think the issue in this bug is related to the issues that users are complaining about in reviews. The window globals in question turned out to be (non-leaked) iframes, and while they initially seemed to be consuming a large amount of memory, that issue has, as far as I can tell, been resolved.

I wasn't aware of the complaints in the user reviews until now.

Comment 18

[Kris Maglione [:kmag]]

I'm trying to reproduce the CPU and memory issues, but without success. The same goes for another user who I asked to test. If anyone can provide confirmation and STR I'd be interested to hear them.

Also, co-opting this bug for the issue at hand.

Comment 19

[Andrew McCreight [:mccr8]]

> but I can't remove it entirely.

Yeah, I really just meant downgrading or whatever the usual processes are.  Thanks!

Comment 20

[Nicholas Nethercote [inactive]]

AMO says 49k users now.

Comment 21

[Brian King [:kinger]]

This add-on is no longer being maintained. What's the best way to retire it on AMO?

Comment 22

[Jorge Villalobos [:jorgev] (he/him)]

You can disable the listing from the Status and Versions page. I think that should suffice.

Comment 23

[Brian King [:kinger]]

(In reply to Jorge Villalobos [:jorgev] from comment #22)
> You can disable the listing from the Status and Versions page. I think that
> should suffice.

How specifically?

Comment 24

[Jorge Villalobos [:jorgev] (he/him)]

Actually, I forgot the link was moved:

1) Go to https://addons.mozilla.org/developers/addon/facebook-toolbar/edit
2) On the menu on the left, right above the separator in the middle, click on Disable Add-on.

Comment 25

[Brian King [:kinger]]

The add-on is now disabled.