413613 - remove MOZ_EXTRA_X11CONVERTERS and the code it enables

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Peter Weilbacher]

Follow-up to bug 376790 comment 3:
MOZ_EXTRA_X11CONVERTERS was set when MOZ_ENABLE_COREXFONTS was enabled. It is now set for Gtk2 builds but at least to me it is unclear if the code in intl/uconv/ that it enables is still used anywhere. It was previously used apparently in gfx/src/gtk*...

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

For what it's worth, MOZ_ENABLE_COREXFONTS defaulted to off for toolkit "gtk2", but (by mistake) defaulted to on for "cairo-gtk2" ... so it was turned on by default, by accident, when we enabled cairo.  And in that case, all it did was enable these extra converters.

I think we can safely remove this.

Comment 2

[Peter Weilbacher]

Attachment: remove it

This removes the option from the build system and the related code from the intl/uconv/ directory. A build with these changes indeed still runs.

The list of files to be removed from CVS (included in the patch) with this change is
intl/uconv/ucvibm/nsCP1046ToUnicode.h
intl/uconv/ucvtw/nsUnicodeToBIG5NoAscii.h
intl/uconv/ucvtw2/nsUnicodeToCNS11643p1.h
intl/uconv/ucvtw2/nsUnicodeToCNS11643p2.h
intl/uconv/ucvtw2/nsUnicodeToCNS11643p3.h
intl/uconv/ucvtw2/nsUnicodeToCNS11643p4.h
intl/uconv/ucvtw2/nsUnicodeToCNS11643p5.h
intl/uconv/ucvtw2/nsUnicodeToCNS11643p6.h
intl/uconv/ucvtw2/nsUnicodeToCNS11643p7.h
intl/uconv/ucvibm/nsUnicodeToCP1046.h
intl/uconv/ucvcn/nsUnicodeToGB2312GL.h
intl/uconv/ucvcn/nsUnicodeToGBKNoAscii.h
intl/uconv/ucvja/nsUnicodeToJISx0208.h
intl/uconv/ucvja/nsUnicodeToJISx0212.h
intl/uconv/ucvko/nsUnicodeToJohabNoAscii.h
intl/uconv/ucvko/nsUnicodeToKSC5601.h
intl/uconv/ucvlatin/nsUnicodeToLangBoxArabic16.h
intl/uconv/ucvlatin/nsUnicodeToLangBoxArabic8.h
intl/uconv/ucvko/nsUnicodeToX11Johab.h
intl/uconv/ucvibm/nsCP1046ToUnicode.cpp
intl/uconv/ucvtw/nsUnicodeToBIG5NoAscii.cpp
intl/uconv/ucvtw2/nsUnicodeToCNS11643p1.cpp
intl/uconv/ucvtw2/nsUnicodeToCNS11643p2.cpp
intl/uconv/ucvtw2/nsUnicodeToCNS11643p3.cpp
intl/uconv/ucvtw2/nsUnicodeToCNS11643p4.cpp
intl/uconv/ucvtw2/nsUnicodeToCNS11643p5.cpp
intl/uconv/ucvtw2/nsUnicodeToCNS11643p6.cpp
intl/uconv/ucvtw2/nsUnicodeToCNS11643p7.cpp
intl/uconv/ucvibm/nsUnicodeToCP1046.cpp
intl/uconv/ucvcn/nsUnicodeToGB2312GL.cpp
intl/uconv/ucvcn/nsUnicodeToGBKNoAscii.cpp
intl/uconv/ucvja/nsUnicodeToJISx0208.cpp
intl/uconv/ucvja/nsUnicodeToJISx0212.cpp
intl/uconv/ucvko/nsUnicodeToJohabNoAscii.cpp
intl/uconv/ucvko/nsUnicodeToKSC5601.cpp
intl/uconv/ucvlatin/nsUnicodeToLangBoxArabic16.cpp
intl/uconv/ucvlatin/nsUnicodeToLangBoxArabic8.cpp
intl/uconv/ucvko/nsUnicodeToX11Johab.cpp

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 298910 [details] [diff] [review]
remove it

r+moa+standing ovation=me (no other review is required)

Comment 4

[Peter Weilbacher]

Comment on attachment 298910 [details] [diff] [review]
remove it

Don't know what Simon's "moa" means, but I doubt it means I should ignore the approval requirement...

Comment 5

[Simon Montagu :smontagu]

moa=module owner approval, and no it doesn't supersede the approval requirement :)

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 298910 [details] [diff] [review]
remove it

a=beltzner for 1.9

Comment 7

[Peter Weilbacher]

Patch checked into trunk.