Closed Bug 413686 Opened 12 years ago Closed 12 years ago

Add the Growl license to the branch about:license, and add Camino's growl usage to trunk about:license

Categories

(Camino Graveyard :: General, defect)

PowerPC
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alqahira, Assigned: alqahira)

References

()

Details

(Keywords: fixed1.8.1.12)

Attachments

(2 files, 2 obsolete files)

Our tab drag-drop patch makes use of a few Growl files for animation.  We'll need to update about:license for this.
Flags: camino1.6b3?
If we want to get this before the freeze on Friday, we'll need a patch reviewed. After that, the (branch) tree probably will be closed for a week or two. (I think anyway. I never really paid attention to how that all went down.)
For the trunk patch, I just added the path where the Growl files will live in our hierarchy but didn't change any text.
Attachment #298869 - Flags: review?
For the branch patch, I added the Growl license (toolkit is not using any Growl files on branch) and used the same Camino-specific text we introduced in bug 403164.
Attachment #298870 - Flags: review?(gerv)
Frank, I'm not sure if Gerv is around right now or still recovering. If he's out, can you grab (at least) the branch review from him so we can get this on branch by the end of this week?
Comment on attachment 298869 [details] [diff] [review]
Adds camino/src/extensions to the Growl paths

Gerv, this isn't urgent (yet); I know you're still recovering.
Attachment #298869 - Flags: review? → review?(gerv)
Comment on attachment 298869 [details] [diff] [review]
Adds camino/src/extensions to the Growl paths

>+          (Copyright ©2004-2008 The Mozilla Foundation. 

If you are going to do this in one file, do it in them all.

r=gerv.

Gerv
Comment on attachment 298870 [details] [diff] [review]
Adds the Growl license to the branch


>+    <span class="path">camino/src/extensions/</span>. (This code only ships in
>+    the in the Camino browser or products based on it.)

Oops - remove an "in the" here and in the two other places.

Then r=gerv.

Gerv
Attachment #298870 - Flags: review?(gerv) → review+
Attachment #298869 - Flags: review?(gerv) → review+
On trunk, toolkit's copyright year was correct.  The only change from attachment 298869 [details] [diff] [review] is fixing the copyright year in mail/license.html.  Carrying forward r=gerv.

Requesting 1.9 approval; we need to make these changes so that when Camino starts shipping code from the Growl Project in the very near future, we are properly fulfilling license obligations.
Attachment #298869 - Attachment is obsolete: true
Attachment #298981 - Flags: review+
Attachment #298981 - Flags: approval1.9?
On branch, only mail's copyright year was incorrect, so that is fixed in this version.  I've also removed the extraneous "in the" from my mangled copy-paste in all three files.  Carrying forward r=gerv.

Requesting 1.8.1.12 approval; we need to make these changes so that when Camino starts shipping code from the Growl Project in the very near future, we are properly fulfilling license obligations.
Attachment #298870 - Attachment is obsolete: true
Attachment #298982 - Flags: review+
Attachment #298982 - Flags: approval1.8.1.12?
Comment on attachment 298981 [details] [diff] [review]
Trunk patch v2, with fixed copyright for mail/ also

a=beltzner for 1.9
Attachment #298981 - Flags: approval1.9? → approval1.9+
Comment on attachment 298982 [details] [diff] [review]
Branch patch v2, with fixed paste-o and mail/ copyright

approved for 1.8.1.12, a=dveditz for release-drivers
Attachment #298982 - Flags: approval1.8.1.12? → approval1.8.1.12+
Branch patch checked in for 1.8.1.12:

Checking in mail/license.html;
/cvsroot/mozilla/mail/license.html,v  <--  license.html
new revision: 1.1.2.6; previous revision: 1.1.2.5
done
Checking in toolkit/content/license.html;
/cvsroot/mozilla/toolkit/content/license.html,v  <--  license.html
new revision: 1.1.2.12; previous revision: 1.1.2.11
done
Checking in xpfe/global/resources/content/license.html;
/cvsroot/mozilla/xpfe/global/resources/content/license.html,v  <--  license.html
new revision: 1.1.2.13; previous revision: 1.1.2.12
done
Keywords: fixed1.8.1.12
Checked in on the trunk before M11:

Checking in mail/license.html;
/cvsroot/mozilla/mail/license.html,v  <--  license.html
new revision: 1.9; previous revision: 1.8
done
Checking in toolkit/content/license.html;
/cvsroot/mozilla/toolkit/content/license.html,v  <--  license.html
new revision: 1.17; previous revision: 1.16
done
Checking in xpfe/global/resources/content/license.html;
/cvsroot/mozilla/xpfe/global/resources/content/license.html,v  <--  license.html
new revision: 1.16; previous revision: 1.15
done
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.