413709 - Don't automatically update unofficial builds

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Mark Mentovai]

We should only stuff our update URL into official builds.  Builds other than those that we produce are of course more than welcome to stuff their own update URLs into their builds, but we shouldn't have other people's builds auto-update to official builds by default.  That kind of sucks for unofficial builders.

Comment 1

[Mark Mentovai]

Attachment: Only put our app.update.url into official builds. Disable update UI if there's no app.update.url. Show a tooltip for disabled items to keep people from getting too confused.

Comment 2

[Mark Mentovai]

Attachment: New MainMenu.nib (10.5.1/IB 2.5.6, please redo, don't check in)

This is the accompanying nib change, but since we decided that we shouldn't use 10.5/IB 2.5.6 to build nibs, especially this nib (bug 413123), we don't want to check this one in.

The only change from the checked-in version of MainMenu.nib is that this connects the "Check for Updates…" menu item's target to the new checkForUpdates: selector added to MainController, instead of the one in SUUpdater.  This is done for menu item validation purposes - there's a small comment in the patch that explains it, too.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We need to really beat up on people who set MOZILLA_OFFICIAL in their builds (or let their users be updated to our builds).  There's really no reason for them to be doing it on the trunk anymore, since you get a real build ID all the time there.

Comment 4

[Mark Mentovai]

I don't think we need to beat up on them, but when they say "how come you guys who obviously no nothing about compilers are auto-updating your unoptimized slow official build over my mad optimized build?" and bitch about how they need to repair permissions three times as a result, I don't mind pointing out to them that we played by the rules and they didn't.

More advanced third-party builders might want to provide their own appcast - they can link to it by setting APP_UPDATE_URL during the build.

Comment 5

[Stuart Morgan]

Comment on attachment 298798 [details] [diff] [review]
Only put our app.update.url into official builds.  Disable update UI if there's no app.update.url.  Show a tooltip for disabled items to keep people from getting too confused.

>+		// Allow the application to provide an empty appcast string to
>+		// indicate that update checking should be disabled.
>+		return;

Couldn't we just set SUScheduledCheckIntervalKey to 0 to disable checking (as we do when the user turns off update checking), and not need to change Sparkle?

Comment 6

[Mark Mentovai]

Reason I didn't do that is that then, anyone who ever runs an unofficial build will get their update pref turned off, no questions asked.

Comment 7

[Stuart Morgan]

Comment on attachment 298798 [details] [diff] [review]
Only put our app.update.url into official builds.  Disable update UI if there's no app.update.url.  Show a tooltip for disabled items to keep people from getting too confused.

Excellent point.

I'll make you a new nib tonight if no-one else gets to it first.

Comment 8

[Mark Mentovai]

No one else got to it first.

Comment 9

[Stuart Morgan]

Attachment: 10.4.11 + IB 2.5.4 MainMenu.nib

Oven fresh nibs, get 'em while they're hot.

Comment 10

[Mark Mentovai]

Thanks for the nib, Stuart.

Checked in on the trunk and MOZILLA_1_8_BRANCH before 1.6b3.

Comment 11

[Eiichi]

After landing attachment 298798 [details] [diff] [review], General Preference is highlighted when opening Preferences except History  Preference in my own branch build.
Screenshot forthcoming.

Comment 12

[Eiichi]

Attachment: Screenshot: Selecting Appearance

Comment 13

[Eiichi]

Attachment: Screenshot: Selecting History

Comment 14

[Stuart Morgan]

History has a text field, which will change the focus behavior, but I don't see how that has anything to do with this bug...

Comment 15

[Eiichi]

Sorry, I tested official latest branch (20080129) and I found the same problem.
So I filed a new bug 414741.