414131 - cut / copy / paste / delete menu items on bookmarks are greyed out

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Steve England [:stevee]]

1. New profile, start firefox
2. Right click on a bookmark

Expected
- Cut/Copy/Paste/Delete menu items are appropriately clickable

Actual
- They are always greyed out

Works 20080125_2105_firefox-3.0b3pre.en-US.win32
Broken 20080125_2218_firefox-3.0b3pre.en-US.win32

Checkins to module PhoenixTinderbox between 2008-01-25 21:05 and 2008-01-25 22:17:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1201323900&maxdate=1201328279

Due to bug 404232 I think.

Comment 1

[Mike Schroepfer]

Myk can you take a look?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Looking...

Comment 3

[Myk Melez [:myk] [@mykmelez]]

I found the problem.  Because the places context menu includes edit commands, we have to take it into account when determining whether or not to update the commands on a focus change (i.e. we have to make sure to update the commands when the places context menu gets opened).

I'm working on a fix.  It should be ready shortly...

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

Here's a fix for the problem.  It adds popupshowing and popuphiding event listeners to the places context menu popup and updates the UI visibility state when those events fire.

It adds event listeners via addEventListener rather than by modifying the popupshowing and popuphiding attributes because the places context menu is overlaid onto multiple windows, and we only track edit UI visibility for the browser window.

I also noticed that updateEditUIVisibility was calling goSetCommandEnabled incorrectly; this patch fixes that problem as well.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.937; previous revision: 1.936
done

Comment 6

[Robert [minotaur 11]]

I still see a problem with the context menu. If i right click on a bookmarks folder in the bookmarks menu "Cut", "Copy", "Paste", "Delete" are always enabled and all other entries are greyed out. The context menu on normal bookmarks works as expected.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #6)
> I still see a problem with the context menu. If i right click on a bookmarks
> folder in the bookmarks menu "Cut", "Copy", "Paste", "Delete" are always
> enabled and all other entries are greyed out. The context menu on normal
> bookmarks works as expected.

Looking...

Comment 8

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #7)
> (In reply to comment #6)
> > I still see a problem with the context menu. If i right click on a bookmarks
> > folder in the bookmarks menu "Cut", "Copy", "Paste", "Delete" are always
> > enabled and all other entries are greyed out. The context menu on normal
> > bookmarks works as expected.
> 
> Looking...

This is a regression from bug 413107, which was also checked in yesterday.  The regression is described in bug 413107, comment 7.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #8)
> This is a regression from bug 413107, which was also checked in yesterday.  The
> regression is described in bug 413107, comment 7.

I have filed this as bug 414167.

Comment 10

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3