414167 - typo in menu.xml breaks context menus for bookmark folders

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: fixes typo in menu.xml

A typo in menu.xml breaks the context menus for bookmark folders, making them show additional commands and commands whose enabled state is set incorrectly.  This is a regression from bug 413107.  The fix is trivial and obvious, thus very low risk.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 299476 [details] [diff] [review]
fixes typo in menu.xml

Requesting approval for this very low risk regression fix.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 299476 [details] [diff] [review]
fixes typo in menu.xml

a=beltzner

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Checking in browser/components/places/content/menu.xml;
/cvsroot/mozilla/browser/components/places/content/menu.xml,v  <--  menu.xml
new revision: 1.97; previous revision: 1.96
done

Comment 4

[pal-moz]

Attachment: screenshot

20080126_2155_firefox-3.0b3pre.en-US.win32.zip

"Sort By Name" is grayed out.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #4)
> Created an attachment (id=299529) [details]
> screenshot
> 
> 20080126_2155_firefox-3.0b3pre.en-US.win32.zip
> 
> "Sort By Name" is grayed out.

I see this too, however I only see it when you context-click on an item inside the folder; the command is enabled when you context-click on the folder itself.

Also, I see it in a build from the 25th, so it predates the checkin for bug 413107 (as well as the one for bug 404232).  Thus it isn't a regression from one of those bugs, which is what this bug is about.

I suspect the behavior may be intentional, as it doesn't make sense to sort the individual item by name, but I guess you could make the case that "Sort by Name" on an item in a folder means "sort the items in this folder by name".

Comment 6

[pal-moz]

intentional ?
how about this ?

bug 400447

Comment 7

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #6)
> intentional ?
> how about this ?
> 
> bug 400447

Yes, it may be intentional, especially since the folks commenting on that bug disagree about which option makes the most sense.  Nevertheless, that bug confirms that the Sort by Name problem is not related to this bug, so further discussion about the problem should go there.  Thanks for the reference.

Comment 8

[Mike Lierman]

*** VERIFIED

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3