414230 - Restart required for 'Workweek days only' and 'Task in View' option to take effect

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/2008012709 Calendar/0.8pre

Steps to Reproduce:
1. Enable menu option 'View -> Workweek days only' or 'View -> Task in View'.

Actual Results:
View doesn't change. An application restart is required to allow the changed options to take effect.

Expected Results:
View updates immediately.

Regression range:
Works in Sunbird 0.8pre (2008-01-22-0526)
Fails in Sunbird 0.8pre (2008-01-22-0936)

Checkins during regression range: http://tinyurl.com/2jvaz3 
Caused by Bug 379100.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

It seems the latest nightlies don't contain the patch to bug 413516, which fixes the issue.

Comment 2

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/2008012720 Calendar/0.8pre

Works in Day View and Week View now. Fails in Multiweek View and Month View.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix v1

I see what you mean. I forgot to revert the refresh for multiweek views. This takes care. The problem is that refresh is not being called in certain cases, including when the days off option is changed.

Comment 4

[Stefan Sitter [:ssitter]]

Comment on attachment 299744 [details] [diff] [review]
Fix v1

r=ssitter

This seems almost identical to calendar-month-view.xml 1.5.2.85 except that the values are now stored in temporary variables before assigning to the member variables instead of directly assigning them. Maybe revert this too?

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Done, thanks.

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 6

[Andreas Treumann]

checked in latest nightly build 20080128 -> task id fixed and verified.