Closed Bug 414230 Opened 16 years ago Closed 16 years ago
Restart required for 'Workweek days only' and 'Task in View' option to take effect
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:22.214.171.124pre) Gecko/2008012709 Calendar/0.8pre Steps to Reproduce: 1. Enable menu option 'View -> Workweek days only' or 'View -> Task in View'. Actual Results: View doesn't change. An application restart is required to allow the changed options to take effect. Expected Results: View updates immediately. Regression range: Works in Sunbird 0.8pre (2008-01-22-0526) Fails in Sunbird 0.8pre (2008-01-22-0936) Checkins during regression range: http://tinyurl.com/2jvaz3 Caused by Bug 379100.
It seems the latest nightlies don't contain the patch to bug 413516, which fixes the issue.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:126.96.36.199pre) Gecko/2008012720 Calendar/0.8pre Works in Day View and Week View now. Fails in Multiweek View and Month View.
I see what you mean. I forgot to revert the refresh for multiweek views. This takes care. The problem is that refresh is not being called in certain cases, including when the days off option is changed.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #299744 - Flags: review?(ssitter)
Comment on attachment 299744 [details] [diff] [review] Fix v1 r=ssitter This seems almost identical to calendar-month-view.xml 188.8.131.52 except that the values are now stored in temporary variables before assigning to the member variables instead of directly assigning them. Maybe revert this too?
Attachment #299744 - Flags: review?(ssitter) → review+
Done, thanks. Checked in on HEAD and MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → 0.8
checked in latest nightly build 20080128 -> task id fixed and verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.