379100 - Give the Unifinder an overhaul

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Philipp Kewisch [:Fallen][☁️📆]]

As found at the Hamburg F2F meeting, the unifinder is very buggy and its code should be reworked.

A possible solution would be to create an xbl binding. This would also benefit integration into lightning.

A more fitting name would be nice too.

A list of unifinder bugs: https://bugzilla.mozilla.org/buglist.cgi?short_desc=unifinder&query_format=advanced&product=Calendar&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&order=Reuse+same+sort+as+last+time&short_desc_type=allwordssubstr

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

xbl is not the holy grail! If it's not needed, please don't use it.

Comment 2

[Stefan Sitter [:ssitter]]

(In reply to comment #0)
> A possible solution would be to create an xbl binding. 
> This would also benefit integration into lightning.

Unifinder is now integrated into Lightning. Since this bug is very vague it's not clear what needs to be done for 0.8 due to the wanted‑calendar0.8+ flag.

I suggest to resolve this bug and file new bugs for each specific unifinder issue that needs to be addressed.

Comment 3

[Daniel Boelzle [:dbo]]

We IMO should fix at least that the unifinder
- by default takes too much space; IMO should be hidden unless the user explicitly wants it
- default "All Events" badly hurts (startup) performance

Comment 4

[seshu.parvataneni]

Also there is one more problem with unifinder. When an event is selected from the unifinder the corresponding event is not highlighted. Only the day that the event occurs is highlighted. It would be nice to actually highlight the event and the day. If there are more than one events in a day it would be easier to distinguish which one corresponds to the selected one. Thanks.

Comment 5

[Pete Riley]

(In reply to comment #4)
> When an event is selected from
> the unifinder the corresponding event is not highlighted. Only the day that the
> event occurs is highlighted.

The corresponding event is correctly selected in the month view for me (using Lightning 0.8pre 2007-12-20-04 with WinXP classic theme).

Comment 6

[seshu.parvataneni]

Hi Pete,

Did you try with recurring events? I just realized that the unifinder selects the event if it is not a recurring event. If I select a recurring event then it does not select the event. Only the day that the event occurs on is highlighted. Thanks for taking a look into this.

Comment 7

[Stefan Sitter [:ssitter]]

(In reply to comment #3)
> - by default takes too much space; IMO should be hidden

I don't think so. In my opinion for new users it's more difficult to find the hidden features instead of seeing them after installation and having the possibility to hide it.

> - default "All Events" badly hurts (startup) performance

See existing Bug 323011.

(In reply to comment #6)
> Did you try with recurring events?

See existing Bug 351880.

Comment 8

[Simon Paquet [:sipaq]]

The items listed by Daniel in comment 3 are currently being worked on in other bugs. Removing wanted0.8+ as a complete rewrite is out of the scope for 0.8.

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Unifinder Makeover - v1

Sorry this patch is so large, but I needed to fix this in order for gdata offline to not produce wierd unifinder errors.

This is of course not a magic patch that takes care of all unifinder errors, but I think it should take care of some of them.

This patch contains:
* Small view fixes to not refresh when the date range is not changed
* Correct selection mechanism at least partially
* Remove double/tripple-initialization of the unifinder

Comment 10

[Michael Büttner (no reviews TFN)]

Comment on attachment 298296 [details] [diff] [review]
Unifinder Makeover - v1

r=mickey.

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

QA, this might cause regressions. Please test the unifinder :)

Comment 12

[Stefan Sitter [:ssitter]]

This also regressed Bug 414230.

Comment 13

[Andreas Treumann]

Checked in latest nightly sunbird and lightning builds -> verified.