On Windows, checksetup.pl should mention the correct PPM repo based on the Perl version

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Installation & Upgrading
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

3.0.3
Bugzilla 3.0
Bug Flags:
approval +
blocking3.2 +
approval3.0 +
blocking3.0.4 +

Details

Attachments

(1 attachment)

3.41 KB, patch
Max Kanat-Alexander
: review+
glob
: review+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Perl 5.8.8 requires to use http://theoryx5.uwinnipeg.ca/ppms
Perl 5.10.0 requires to use http://cpan.uwinnipeg.ca/PPMPackages/10xx/

checksetup.pl should reflect that as ActiveState specifies that PPMs are not compatible between 5.8.8 and 5.10.0, so installing the wrong repository will probably generate a lot of trouble.
Flags: blocking3.2?
Flags: blocking3.0.4?

Comment 1

10 years ago
Yes, this is a blocker. While we're at it, we should fix the way the instructions are presented based on your build of 5.8. (Different builds have different PPM versions).
Flags: blocking3.2?
Flags: blocking3.2+
Flags: blocking3.0.4?
Flags: blocking3.0.4+
OS: Windows 2000 → All
Hardware: PC → All
(Assignee)

Updated

10 years ago
Blocks: 388099
(Assignee)

Comment 2

10 years ago
Created attachment 302181 [details] [diff] [review]
patch, v1

Tested with Bugzilla 3.1.3+ on Windows 2000 SP4 with both Perl 5.8.8 build 822 and Perl 5.10.0 build 1002.
Assignee: installation → LpSolit
Status: NEW → ASSIGNED
Attachment #302181 - Flags: review?(mkanat)
Attachment #302181 - Flags: review?(bugzilla)

Comment 3

10 years ago
Comment on attachment 302181 [details] [diff] [review]
patch, v1

Looks good to me, code-wise. I'd like ActiveState and ID to be all lowercase in that function name, though.
Attachment #302181 - Flags: review?(mkanat) → review+
Comment on attachment 302181 [details] [diff] [review]
patch, v1

r=glob
Attachment #302181 - Flags: review?(bugzilla) → review+
(Assignee)

Updated

10 years ago
Flags: approval3.0+
Flags: approval+
(Assignee)

Comment 5

10 years ago
tip:

Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.42; previous revision: 1.41
done

3.0.3:

Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.29.2.3; previous revision: 1.29.2.2
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.