Last Comment Bug 414430 - On Windows, checksetup.pl should mention the correct PPM repo based on the Perl version
: On Windows, checksetup.pl should mention the correct PPM repo based on the Pe...
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Installation & Upgrading (show other bugs)
: 3.0.3
: All All
: -- normal (vote)
: Bugzilla 3.0
Assigned To: Frédéric Buclin
: default-qa
:
Mentors:
Depends on:
Blocks: 388099
  Show dependency treegraph
 
Reported: 2008-01-28 12:28 PST by Frédéric Buclin
Modified: 2008-02-11 11:34 PST (History)
0 users
LpSolit: approval+
mkanat: blocking3.2+
LpSolit: approval3.0+
mkanat: blocking3.0.4+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch, v1 (3.41 KB, patch)
2008-02-08 13:31 PST, Frédéric Buclin
mkanat: review+
glob: review+
Details | Diff | Splinter Review

Description Frédéric Buclin 2008-01-28 12:28:36 PST
Perl 5.8.8 requires to use http://theoryx5.uwinnipeg.ca/ppms
Perl 5.10.0 requires to use http://cpan.uwinnipeg.ca/PPMPackages/10xx/

checksetup.pl should reflect that as ActiveState specifies that PPMs are not compatible between 5.8.8 and 5.10.0, so installing the wrong repository will probably generate a lot of trouble.
Comment 1 Max Kanat-Alexander 2008-01-28 16:44:15 PST
Yes, this is a blocker. While we're at it, we should fix the way the instructions are presented based on your build of 5.8. (Different builds have different PPM versions).
Comment 2 Frédéric Buclin 2008-02-08 13:31:56 PST
Created attachment 302181 [details] [diff] [review]
patch, v1

Tested with Bugzilla 3.1.3+ on Windows 2000 SP4 with both Perl 5.8.8 build 822 and Perl 5.10.0 build 1002.
Comment 3 Max Kanat-Alexander 2008-02-08 15:04:46 PST
Comment on attachment 302181 [details] [diff] [review]
patch, v1

Looks good to me, code-wise. I'd like ActiveState and ID to be all lowercase in that function name, though.
Comment 4 Byron Jones ‹:glob› [PTO until 2016-10-10] 2008-02-10 15:45:39 PST
Comment on attachment 302181 [details] [diff] [review]
patch, v1

r=glob
Comment 5 Frédéric Buclin 2008-02-11 11:34:21 PST
tip:

Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.42; previous revision: 1.41
done

3.0.3:

Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.29.2.3; previous revision: 1.29.2.2
done

Note You need to log in before you can comment on or make changes to this bug.