Closed
Bug 414515
Opened 18 years ago
Closed 18 years ago
Nightlies should not override the module-specific build settings.
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: philor)
Details
(Keywords: perf)
Attachments
(1 file)
|
4.08 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #407794 +++
As sayrer said:
This is bad. At least, it's bad that we do this in nightlies and release builds. It's unlikely that a global setting is good. For example, sqlite should be built with very high optimization, not "-O2".
Nightlies should not override the module-specific build settings.
(And they also shouldn't use random ancient things from 1.8 like --enable-pango or MOZ_PACKAGE_NSIS)
|
Assignee | |
Comment 1•18 years ago
|
||
Thanks, Bugzilla, I'll just attach it now, shall I?
Attachment #299956 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 299956 [details] [diff] [review]
Fix v.1
Yes sir.
Attachment #299956 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
tools/tinderbox-configs/thunderbird/linux/mozconfig 1.5
tools/tinderbox-configs/thunderbird/linux/CLOBBER 1.4
tools/tinderbox-configs/thunderbird/macosx/mozconfig 1.4
tools/tinderbox-configs/thunderbird/macosx/CLOBBER 1.3
tools/tinderbox-configs/thunderbird/win32/mozconfig 1.8
tools/tinderbox-configs/thunderbird/win32/CLOBBER 1.7
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•