414567 - AMO Integration: Search icon should be the same as in the search bar on the navigation toolbar

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[u88484]

Attachment: Screenshot

In the new AMO Integration panel, the search icon should be the same as in the search bar on the navigation toolbar.  See screenshot.

Comment 2

[Madhava Enros [:madhava]]

So, I think what we're saying is use the appropriate one of the following instead:

http://mxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/Search-bar.png

http://mxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/Search-bar.png

http://mxr.mozilla.org/seamonkey/source/browser/themes/gnomestripe/browser/Search-bar.png

and, at some point, the close button, too.

Comment 3

[Madhava Enros [:madhava]]

The icons I mentioned in comment #2 no longer exist, but we should be using the same search and cancel icons that we use throughout firefox for each platform.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

We appear to be using a different icon from the searchbar on on OSX, but the same icon as is used in the searchbox on Vista and XP (though it doesn't quite fit well on Vista) just with a grey background. I suspect that Alex just copied the image over which is why it's there on XP and Vista.

Comment 5

[Mike Connor [:mconnor]]

-> Dave for resolution.

Comment 6

[Dave Townsend [:mossop]]

Attachment: OSX search

Comment 7

[Dave Townsend [:mossop]]

Attachment: OSX cancel search

Comment 8

[Dave Townsend [:mossop]]

Attachment: Windows search

Comment 9

[Dave Townsend [:mossop]]

Attachment: Windows cancel search

Windows needed a bit of additional padding love

Comment 10

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Comment 11

[Dave Townsend [:mossop]]

Attachment: new pinstripe icon file

Comment 12

[Dave Townsend [:mossop]]

Comment on attachment 312090 [details] [diff] [review]
patch rev 1

These are the simple style tweaks necessary to fix up windows and OSX as the above screenshots.

Comment 13

[Dave Townsend [:mossop]]

Checking in toolkit/themes/pinstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.43; previous revision: 1.42
done
Checking in toolkit/themes/pinstripe/mozapps/extensions/searchIcons.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/searchIcons.png,v  <--  searchIcons.png
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.54; previous revision: 1.53
done

Comment 14

[Dave Townsend [:mossop]]

The checkin for bug 427555 reverted this.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dave, so this bug is not Windows only as the OS field says?

Comment 16

[Dave Townsend [:mossop]]

Relanded the icon.

Checking in toolkit/themes/pinstripe/mozapps/extensions/searchIcons.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/searchIcons.png,v  <--  searchIcons.png
new revision: 1.4; previous revision: 1.3
done

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008040604 Minefield/3.0pre ID:2008040604

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008040907 Minefield/3.0pre

Under Windows the height of the search box within the Get Addons panel is too flat when comparing it to the navigation bar search box. Is there already a bug about this issue? I cannot find one. If not, I'll file a new bug.