Closed Bug 414472 Opened 15 years ago Closed 14 years ago

searchIcons.png should have transparent background

Categories

(Firefox :: Theme, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 3

People

(Reporter: takenspc, Assigned: mossop)

References

()

Details

(Keywords: access)

Attachments

(2 files, 1 obsolete file)

Attached image Screenshot (obsolete) —
Currently searchIcons.png has white background, but this isn't match non-white window.
It should have transparent background.
Madhava, I mentioned this a little while ago, need to source any proper images for these, in conjunction with changing that puzzle icon.
s/isn't/doesn't/ :-(
We should probably use the same icon and hover look (including opacity and the cursor) as the Search bar.
Depends on: 414567
Duplicate of this bug: 416012
Duplicate of this bug: 416878
These should be coming in the icon updates according to faaborg, but want to make sure this isn't lost.
Flags: blocking-firefox3?
Component: Extension/Theme Manager → Theme
Flags: blocking-firefox3? → blocking-firefox3+
Keywords: access
Priority: -- → P2
QA Contact: extension.manager → theme
We should cut the puzzle piece since it doesn't mesh with the native style of search boxes on OS X and Vista, and we will receiving a new magnifying glass icon for use across all of our search fields.
(In reply to comment #7)
> We should cut the puzzle piece since it doesn't mesh with the native style of
> search boxes on OS X and Vista, and we will receiving a new magnifying glass
> icon for use across all of our search fields.

Yes totally, I'll file a patch to remove it's use from the UI in the next couple of hours. I feel like I keep saying this, but I promise this time!
This drops the puzzle piece from the UI. When the new icons come in the icon can actually be removed from the file but the css image regions will need to be updated accordingly.
Attachment #307292 - Flags: review?(gavin.sharp)
Attachment #307292 - Flags: review?(gavin.sharp) → review+
Checked in:

Checking in toolkit/mozapps/extensions/content/extensions.xml;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.xml,v  <--  extensions.xml
new revision: 1.58; previous revision: 1.57
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.13; previous revision: 1.12
done
Checking in toolkit/themes/pinstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.38; previous revision: 1.37
done
Checking in toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.47; previous revision: 1.46
done
This is fixed, right?
(In reply to comment #11)
> This is fixed, right?
> 

No. |.searchbox-search| and |.searchbox-cancel| still use searchIcons.png which has white background.
Attached image Screenshot
Current screenshot.
Attachment #299891 - Attachment is obsolete: true
This should be fixed by bug 388811, but in the meantime, let's get new images landed on every platform.  Cc'ing people for Linux and OS X, we will be updating the windows icons in the next drop.  These are the files that need to be updated:

http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/mozapps/extensions/searchIcons.png

http://mxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/mozapps/extensions/searchIcons.png

http://mxr.mozilla.org/seamonkey/source/toolkit/themes/gnomestripe/mozapps/extensions/searchIcons.png (needs to be created)

Just include the search magnifying glass on the left and close button on the right, with a size of 16x32, cut the puzzle piece. 
(In reply to comment #14)
> Just include the search magnifying glass on the left and close button on the
> right, with a size of 16x32, cut the puzzle piece. 

Can we just use the search magnifying glass that the search bar uses and use the gtk stock close icon for the close button?
(In reply to comment #14)
> This should be fixed by bug 388811

The Add-ons manager isn't going to use that widget.
>The Add-ons manager isn't going to use that widget.

Ok, we should use the same icons though.

>Can we just use the search magnifying glass that the search bar uses and use
>the gtk stock close icon for the close button?

This might need to be in toolkit instead of browser.  I'm all in favor of us
having only one search magnifying glass icon per platform.  Bug 308689 uses:

chrome://global/skin/icons/search.png

In terms of close, we shouldn't be using

/toolkit/themes/[theme name]/global/icons/close.png

The correct image for closing tabs is not going to be the correct image for
clearing a search for platform integration with OS X and Vista.  On Linux you
can decide of using a gtk icon is an appropriate use (it very well may not be).

The patch for bug 308689 adds the icon

skin/classic/global/icons/search-textbox-clear.png 
Alex, can you make sure this gets handled for all platforms?
Assignee: nobody → faaborg
With the new icons, is this still a problem?
(In reply to comment #19)
> With the new icons, is this still a problem?
> 

This is still an issue on windows and OSX
Assignee: faaborg → dtownsend
Fixed by bug 414567
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
You need to log in before you can comment on or make changes to this bug.