414472 - searchIcons.png should have transparent background

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Takeshi Kurosawa :takenspc]

Attachment: Screenshot

Currently searchIcons.png has white background, but this isn't match non-white window.
It should have transparent background.

Comment 1

[Dave Townsend [:mossop]]

Madhava, I mentioned this a little while ago, need to source any proper images for these, in conjunction with changing that puzzle icon.

Comment 2

[Takeshi Kurosawa :takenspc]

s/isn't/doesn't/ :-(

Comment 3

[Dão Gottwald [:dao]]

We should probably use the same icon and hover look (including opacity and the cursor) as the Search bar.

Comment 6

[Dave Townsend [:mossop]]

These should be coming in the icon updates according to faaborg, but want to make sure this isn't lost.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

We should cut the puzzle piece since it doesn't mesh with the native style of search boxes on OS X and Vista, and we will receiving a new magnifying glass icon for use across all of our search fields.

Comment 8

[Dave Townsend [:mossop]]

(In reply to comment #7)
> We should cut the puzzle piece since it doesn't mesh with the native style of
> search boxes on OS X and Vista, and we will receiving a new magnifying glass
> icon for use across all of our search fields.

Yes totally, I'll file a patch to remove it's use from the UI in the next couple of hours. I feel like I keep saying this, but I promise this time!

Comment 9

[Dave Townsend [:mossop]]

Attachment: This is not the puzzle piece you are looking for

This drops the puzzle piece from the UI. When the new icons come in the icon can actually be removed from the file but the css image regions will need to be updated accordingly.

Comment 10

[Dave Townsend [:mossop]]

Checked in:

Checking in toolkit/mozapps/extensions/content/extensions.xml;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.xml,v  <--  extensions.xml
new revision: 1.58; previous revision: 1.57
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.13; previous revision: 1.12
done
Checking in toolkit/themes/pinstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.38; previous revision: 1.37
done
Checking in toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.47; previous revision: 1.46
done

Comment 11

[Johnathan Nightingale [:johnath]]

This is fixed, right?

Comment 12

[Takeshi Kurosawa :takenspc]

(In reply to comment #11)
> This is fixed, right?
> 

No. |.searchbox-search| and |.searchbox-cancel| still use searchIcons.png which has white background.

Comment 13

[Takeshi Kurosawa :takenspc]

Attachment: Screenshot

Current screenshot.

Comment 14

[Alex Faaborg [:faaborg] (Firefox UX)]

This should be fixed by bug 388811, but in the meantime, let's get new images landed on every platform.  Cc'ing people for Linux and OS X, we will be updating the windows icons in the next drop.  These are the files that need to be updated:

http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/mozapps/extensions/searchIcons.png

http://mxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/mozapps/extensions/searchIcons.png

http://mxr.mozilla.org/seamonkey/source/toolkit/themes/gnomestripe/mozapps/extensions/searchIcons.png (needs to be created)

Just include the search magnifying glass on the left and close button on the right, with a size of 16x32, cut the puzzle piece. 

Comment 15

[Reed Loden [:reed]]

(In reply to comment #14)
> Just include the search magnifying glass on the left and close button on the
> right, with a size of 16x32, cut the puzzle piece. 

Can we just use the search magnifying glass that the search bar uses and use the gtk stock close icon for the close button?

Comment 16

[Dão Gottwald [:dao]]

(In reply to comment #14)
> This should be fixed by bug 388811

The Add-ons manager isn't going to use that widget.

Comment 17

[Alex Faaborg [:faaborg] (Firefox UX)]

>The Add-ons manager isn't going to use that widget.

Ok, we should use the same icons though.

>Can we just use the search magnifying glass that the search bar uses and use
>the gtk stock close icon for the close button?

This might need to be in toolkit instead of browser.  I'm all in favor of us
having only one search magnifying glass icon per platform.  Bug 308689 uses:

chrome://global/skin/icons/search.png

In terms of close, we shouldn't be using

/toolkit/themes/[theme name]/global/icons/close.png

The correct image for closing tabs is not going to be the correct image for
clearing a search for platform integration with OS X and Vista.  On Linux you
can decide of using a gtk icon is an appropriate use (it very well may not be).

The patch for bug 308689 adds the icon

skin/classic/global/icons/search-textbox-clear.png 

Comment 18

[Mike Connor [:mconnor]]

Alex, can you make sure this gets handled for all platforms?

Comment 19

[Reed Loden [:reed]]

With the new icons, is this still a problem?

Comment 20

[Dave Townsend [:mossop]]

(In reply to comment #19)
> With the new icons, is this still a problem?
> 

This is still an issue on windows and OSX

Comment 21

[Dave Townsend [:mossop]]

Fixed by bug 414567