414620 - Importer does not correctly handle Mac Eudora mail importing

Status: RESOLVED WONTFIX

(Thunderbird :: Migration, defect)

Description

[Geoffrey C. Wenger]

The current Mac Eudora mail importer does not correctly import Mac Eudora mail. Some of the bugs associated with Mac Eudora mail importing are:
Bug 368368
Bug 368371
Bug 368372
Bug 368374
Bug 368605
Bug 401396

Because of these bugs and other complexities associated with correctly handling all cases of importing Mac Eudora email, we (Penelope team at Qualcomm) decided to create an external exporter application that would export mail into a format that's easily understood by Thunderbird.

Comment 1

[Geoffrey C. Wenger]

Attachment: Patch that implements support for launching an external application, which exports Mac Eudora mail into an mbox based format for use by the importer. Note patch was not created with CVS.

Improves importing of Mac Eudora email by launching a free application from Qualcomm that exports Mac Eudora email into unix mbox format (with some differences).
Exporter output:
* Line endings will be CRLF (this is non-mbox, but handled correctly by Mozilla code)
* File creator/type CSOm/MIME
* File extension is .mim
The code in this patch launches the free Mac Eudora exporter application. The Mac exporter application can either be located beside the Mac application bundle (i.e. in the same directory as the application bundle) or inside the application bundle. The exporter application exports email into a temp directory. The exporter writes errors into a text file called "Eudora Exports.txt". The code in this patch waits for the exporter application to complete, parses the results text file, and copies the resulting mailboxes into the correct import location. The code in this patch detects failure of the exporter, handles telling the Mac exporter to quit if import is cancelled, and other details of integration with the Mac exporter. The code in this patch implements a general mechanism for potential future implementations of external exporter applications, but only uses the mechanism for Mac Eudora importing at present.

Comment 2

[David :Bienvenu]

Comment on attachment 300068 [details] [diff] [review]
Patch that implements support for launching an external application, which exports Mac Eudora mail into an mbox based format for use by the importer. Note patch was not created with CVS.

I guess it must have been really hard to get the importer working in process, because this looks like a lot of work :-(

+  PRUnichar *pText = nsnull;
+  
+  if (usesExternalExporter)
+    pText = nsTextFormatter::smprintf( pFmt, name.get() );
+  else
+    pText = nsTextFormatter::smprintf(pFmt, name.get(), count);

this can simply be:

+  PRUnichar *pText = (usesExternalExporter) ? nsTextFormatter::smprintf( pFmt, name.get() )
: nsTextFormatter::smprintf(pFmt, name.get(), count);

is this a tab?

+  nsCOMPtr<nsIFile>			m_exporterDestination;


+  
+  boolean UsesExternalExporter();
+  

that can just be readonly boolean usesExternalImporter;

and then the impl method is GetUsesExternalImporter.

more tabs?
+  if (!m_pThreadData->usesExternalExporter)
+  {
+		m_pThreadData->boxes = m_pMailboxes;
+		m_pThreadData->hasListOfBoxes = PR_TRUE;
+		NS_ADDREF( m_pMailboxes);
+  }

there are also several places you can use

NS_ADDREF(foo = bar);

and NS__IF_ADDREF(foo = bar);

Can you audit those and attach a new patch? Thx!

Comment 3

[Wayne Mery (:wsmwk)]

Comment on attachment 300068 [details] [diff] [review]
Patch that implements support for launching an external application, which exports Mac Eudora mail into an mbox based format for use by the importer. Note patch was not created with CVS.

Geoffrey, possible to drive this in time for beta 2? 

clearing SR as mscott is no longer doing those

Comment 4

[:aceman]

Importing from Eudora was removed from Thunderbird in bug 1243498.
Please see http://kb.mozillazine.org/Importing_from_Eudora_-_Thunderbird on how you can still import from Eudora if you need that.