414728 - statusbar not using cool new embossed text-shadow-effect-thing for statusbar text

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Asa Dotzler [:asa]]

Text in the primary toolbar, the bookmarks toolbar, and the tab strip are all using the new embossed look for text. The status bar isn't. It should.

Comment 1

[Jesse Ruderman]

I don't think this would be worth the perf impact.  It's important to be able to update the status bar quickly.  Maybe once text-shadow is implemented, it will be ok.

Comment 2

[Asa Dotzler [:asa]]

doesn't depend any more on bug 10713 than the bookmark toolbar did. we're faking it.

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

(In reply to comment #2)
> doesn't depend any more on bug 10713 than the bookmark toolbar did. we're
> faking it.
> 
See bug 423736 - because of the perf impact we're not going to accept the current hack.

Comment 4

[Stephen Horlander [:shorlander]]

Considering comment #2 should this be resolved? 

Maybe possible to revisit later when text-shadow is implemented. Hopefully that won't have the same kind of perf impact as using XBL hacks.

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> Considering comment #2 should this be resolved?

Comment 2 doesn't apply anymore.

Comment 6

[Stephen Horlander [:shorlander]]

(In reply to comment #5)
> (In reply to comment #4)
> > Considering comment #2 should this be resolved?
> 
> Comment 2 doesn't apply anymore.
> 

Oops, sorry, I meant comment #3.

Comment 7

[Dão Gottwald [:dao]]

Well, how do you want to resolve it? WONTFIX?
We can just leave it open until bug 10713 is fixed.

Comment 8

[Asa Dotzler [:asa]]

now that we have text-shadow for xul,  can we use it :D

Comment 9

[Markus Stange [:mstange]]

Attachment: patch v1

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Good OSX fit and finish bug, feels like blocking on mconnor for review on this is failure, who else can review here? Ryan?

Comment 11

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 341259 [details] [diff] [review]
patch v1

Be sure to keep an eye on Tp/Tdhtml/Tsspider when this lands.

Comment 12

[Markus Stange [:mstange]]

pushed: http://hg.mozilla.org/mozilla-central/rev/07c7fa8394c5

Comment 13

[Markus Stange [:mstange]]

The perf numbers didn't show any change.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #13)
> The perf numbers didn't show any change.

Under this condition I can verify the embossed text shadow in the status bar with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081013 Minefield/3.1b2pre ID:20081013193009.