statusbar not using cool new embossed text-shadow-effect-thing for statusbar text

VERIFIED FIXED in Firefox 3.1b2

Status

()

Firefox
Theme
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: asa, Assigned: mstange)

Tracking

({polish})

Trunk
Firefox 3.1b2
All
Mac OS X
polish
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3 -
blocking-firefox3.5 -
wanted-firefox3 +
wanted-firefox3.5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Text in the primary toolbar, the bookmarks toolbar, and the tab strip are all using the new embossed look for text. The status bar isn't. It should.

Comment 1

10 years ago
I don't think this would be worth the perf impact.  It's important to be able to update the status bar quickly.  Maybe once text-shadow is implemented, it will be ok.
(Reporter)

Updated

10 years ago
Flags: blocking-firefox3?
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-

Updated

10 years ago
Depends on: 423361
Depends on: 10713
No longer depends on: 423361
(Reporter)

Comment 2

10 years ago
doesn't depend any more on bug 10713 than the bookmark toolbar did. we're faking it.
Depends on: 423361
No longer depends on: 10713
(In reply to comment #2)
> doesn't depend any more on bug 10713 than the bookmark toolbar did. we're
> faking it.
> 
See bug 423736 - because of the perf impact we're not going to accept the current hack.

Updated

10 years ago
Depends on: 10713
Considering comment #2 should this be resolved? 

Maybe possible to revisit later when text-shadow is implemented. Hopefully that won't have the same kind of perf impact as using XBL hacks.

Comment 5

10 years ago
(In reply to comment #4)
> Considering comment #2 should this be resolved?

Comment 2 doesn't apply anymore.
(In reply to comment #5)
> (In reply to comment #4)
> > Considering comment #2 should this be resolved?
> 
> Comment 2 doesn't apply anymore.
> 

Oops, sorry, I meant comment #3.

Comment 7

10 years ago
Well, how do you want to resolve it? WONTFIX?
We can just leave it open until bug 10713 is fixed.

Updated

10 years ago
Depends on: 438517
No longer depends on: 10713
(Reporter)

Comment 8

9 years ago
now that we have text-shadow for xul,  can we use it :D
Flags: blocking-firefox3.1?
(Assignee)

Updated

9 years ago
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Hardware: PC → All
(Assignee)

Comment 9

9 years ago
Created attachment 341259 [details] [diff] [review]
patch v1
Attachment #341259 - Flags: review?(mconnor)
(Assignee)

Updated

9 years ago
Blocks: 458197
Good OSX fit and finish bug, feels like blocking on mconnor for review on this is failure, who else can review here? Ryan?
Flags: wanted-firefox3.1+
Flags: blocking-firefox3.1?
Flags: blocking-firefox3.1-
Keywords: polish
(Assignee)

Updated

9 years ago
Attachment #341259 - Flags: review?(mconnor) → review?(rflint)
Attachment #341259 - Flags: review?(rflint) → review+
Comment on attachment 341259 [details] [diff] [review]
patch v1

Be sure to keep an eye on Tp/Tdhtml/Tsspider when this lands.
(Assignee)

Comment 12

9 years ago
pushed: http://hg.mozilla.org/mozilla-central/rev/07c7fa8394c5
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b2
(Assignee)

Comment 13

9 years ago
The perf numbers didn't show any change.
(In reply to comment #13)
> The perf numbers didn't show any change.

Under this condition I can verify the embossed text shadow in the status bar with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081013 Minefield/3.1b2pre ID:20081013193009.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.