Closed
Bug 414791
Opened 17 years ago
Closed 16 years ago
AMO Manager: relaunching Addons Manager resumes prior extension search
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.1a2
People
(Reporter: tchung, Assigned: dao)
References
Details
(Keywords: ue, Whiteboard: [fixed by bug 449317])
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008012904 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008012904 Minefield/3.0b3pre
If a previous session of addons manager displays results, shutting down and then relaunching Addons Manager, will enable a search again for the results from last session. Should we not resume searching if the window has been closed, and let the user search a clean slate?
Reproducible: Always
Steps to Reproduce:
1. Install latest nightly build
2. open addons manager, search for a keyword (eg. flash)
3. When results appear in the Get Add-ons pane, click the X in the dialog window to close down Addons Manager
4. Relaunch Addons manager, and verify the search for last keyword is automatically searching again (eg. flash)
Actual Results:
I think that if a user closes the addons manager dialog, and restarts it, they should not have the search resume from last time. Otherwise the addons manager automatically resumes connection to AMO to search for the last extension searched on.
Expected Results:
Should not resume searching extension if user closes down Addons Manager
Comment 1•17 years ago
|
||
This was an intentional behaviour from Madhava
Reporter | ||
Comment 2•17 years ago
|
||
Is this going to cause performance issues? why cant we just cache the searches for next time, instead of sending an uninitiated server request?
Comment 3•17 years ago
|
||
I don't see why it would cause much of a perf issue. Re-displaying the previous results was suggested though.
Comment 4•16 years ago
|
||
Why someone would want to see the same results many times? Every time when I open the addons manager to search for something I have to clear the old search. Or to avoid this I have to delete the current search every time before closing the window instead to just close it and forget.
To keep the search term for the session in case the browser is restarted sounds good but if the browser is closed I think it should be cleared automatically.
Updated•16 years ago
|
Product: Firefox → Toolkit
Assignee | ||
Comment 6•16 years ago
|
||
Madhava, can we revisit this?
I think this is unhelpful and unexpected behavior; no other search field does it.
Comment 7•16 years ago
|
||
Boriss is handing add-ons manager UI stuff now.
The original idea behind this as I recall was to keep consistency between what the user saw in the add-ons manager when clicking the restart button and when it popped up after, so something like the following flow:
1. User goes to get add-ons and searches.
2. User installs an add-on.
3. User restarts.
4. Add-ons manager appears to notify of the install, still including the same search results (excluding the installed one).
I think though after that we changed to make it show the extensions panel after the startup (highlighting the new add-on), so maybe the persistance is less useful now and just getting the recommended list each time would be better.
Updated•16 years ago
|
Version: unspecified → Trunk
Comment 8•16 years ago
|
||
I agree with Dao, Dave, Tony, etc - this behavior is unlikely expected or needed. Especially given the changes coming up for the add-ons manager with sharing and feeds, the persistence of search will become even more necessary.
Dao tells me this bug is being fixed with https://bugzilla.mozilla.org/show_bug.cgi?id=414791 .
Comment 9•16 years ago
|
||
(In reply to comment #8)
> Dao tells me this bug is being fixed with
> https://bugzilla.mozilla.org/show_bug.cgi?id=414791 .
Jenny, this is the current bug. I think there was a wrong link in your clipboard.
Assignee | ||
Comment 10•16 years ago
|
||
She meant bug 449317.
Assignee | ||
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [will be fixed by bug 449317] → [fixed by bug 449317]
Target Milestone: --- → mozilla1.9.1a2
Reporter | ||
Comment 11•16 years ago
|
||
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080808020649 Minefield/3.1a2pre. This was fixed in bug 449317.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•