449317 - Use the new search textbox binding in the Add-ons manager

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Btw, I don't think we should be persisting the value. I find this quite irritating every time I open the Add-ons manager after searching. We're not doing this for any other search field.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

AFAIR there was already a bug about this issue which was fixed. No idea why that still happens.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dao, can we do something with bug 419185?

Comment 3

[Dave Townsend [:mossop]]

(In reply to comment #0)
> Btw, I don't think we should be persisting the value. I find this quite
> irritating every time I open the Add-ons manager after searching. We're not
> doing this for any other search field.

Should file a bug on that (assuming there isn't one). It was one of the explicit requests from UX, but we can revisit it now.

I should get to the patch some time this week.

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> (In reply to comment #0)
> > Btw, I don't think we should be persisting the value. I find this quite
> > irritating every time I open the Add-ons manager after searching. We're not
> > doing this for any other search field.
> 
> Should file a bug on that (assuming there isn't one). It was one of the
> explicit requests from UX, but we can revisit it now.

It's bug 414791.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 332465 [details] [diff] [review]
patch

I'll post a new patch without persisting the value, as this allows me to actually change less code.

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch, without persisting the value

Just removing persist="value" wasn't enough; if there's any stored value, that will always be restored. I think the easiest solution is to use a different id for the textbox.

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 332594 [details] [diff] [review]
patch, without persisting the value

Looks excellent, thanks

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/index.cgi/mozilla-central/rev/1434eaf5a557

Comment 9

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080808020649 Minefield/3.1a2pre.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

To have a consistent look on OS X we should try to drive bug 449465 forward.

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080808031528 Minefield/3.1a2pre ID:20080808031528