Fix click and hold code on Mac

VERIFIED FIXED in Firefox 3 beta3

Status

()

Firefox
General
P1
normal
VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: Gavin, Assigned: mano)

Tracking

({regression})

Trunk
Firefox 3 beta3
x86
Mac OS X
regression
Points:
---
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 404109 removed the back/forward buttons, so the code to enable "click and hold" behavior no longer works. We need to fix it.
Flags: blocking-firefox3?
Blocks: 404109
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Target Milestone: --- → Firefox 3 beta4
Priority: P2 → P1
Target Milestone: Firefox 3 beta4 → Firefox 3 beta3

Updated

11 years ago
Keywords: regression
For mac, for now, hide dropmarker, re-enable click and hold such that it shows the new unified menu.

Kevin: bug 404109 enables the "keyhole", so if you could work on getting the appropriate styling hooked up in the CSS and file a patch with approval1.9b3? we can see if it makes sense to take it for beta 3
Created attachment 300423 [details] [diff] [review]
patch
Assignee: nobody → mano
Status: NEW → ASSIGNED
Attachment #300423 - Flags: review?(gavin.sharp)
Attachment #300423 - Flags: review?(gavin.sharp) → review+
Attachment #300423 - Flags: approval1.9b3?
Attachment #300423 - Flags: approval1.9?
Comment on attachment 300423 [details] [diff] [review]
patch

a=beltzner for 1.9 and beta 3
Attachment #300423 - Flags: approval1.9b3?
Attachment #300423 - Flags: approval1.9b3+
Attachment #300423 - Flags: approval1.9?
Attachment #300423 - Flags: approval1.9+
mozilla/browser/themes/pinstripe/browser/browser.css 1.120
mozilla/browser/base/content/browser.js 1.954
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 5

10 years ago
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020418 Firefox/3.0b3.  
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.