404109 - move the Home button to the Bookmarks toolbar, and reset toolbars for Firefox 3

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, enhancement, P1)

Description

[Dão Gottwald [::dao]]

Attachment: screenshot

Would be great if someone could try this on OS X:

https://build.mozilla.org/tryserver-builds/2007-11-16_14:[e-mail]-1195253500/

Note that the home button will only be moved if you haven't customized your toolbars. If you have, you can either move it manually or use "Restore Default Set".

Comment 1

[Dão Gottwald [::dao]]

Attachment: patch

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

wow, filed and implemented before I even got a chance to file :)

Comment 3

[Mike Connor [:mconnor]]

Not a blocker, but likely to happen.

Comment 4

[Dão Gottwald [::dao]]

Attachment: patch v2

With this patch I'm modifying the class name of the button to get the appearance of a bookmark item without duplicating many style rules.

The first patch also didn't look right with Pinstripe.

Comment 5

[Dão Gottwald [::dao]]

https://build.mozilla.org/tryserver-builds/2007-12-04_15:[e-mail]-homebookmark/

Comment 6

[Dão Gottwald [::dao]]

Attachment: patch v3

including the new ids in order to reset the toolbarsets for all users

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 300270 [details] [diff] [review]
patch v3

sr=me, but we need to be _very_ explicit publicly about what we're doing here, both for users and for themers

Comment 8

[Dão Gottwald [::dao]]

Attachment: updated patch v3

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300301 [details] [diff] [review]
updated patch v3

a=beltzner for beta 3

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Attachment: fixed updated patch v3

Needed to fix the "#personal-toolbar >" selectors to be child selectors, to still match the item while wrapped in the personal toolbar. Also fixed a type in setPersonalToolbarStyle that was checking for the old personal toolbar ID.

I'm going to land this now.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Attachment: fixed fixed updated patch v3

Given bug 414811 comment 1, I'm going to stick to using the child selector for now.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/themes/gnomestripe/browser/browser.css 	1.168
mozilla/browser/themes/pinstripe/browser/browser.css 	1.119
mozilla/browser/themes/winstripe/browser/browser.css 	1.161
mozilla/browser/base/content/browser.js 	1.951
mozilla/browser/base/content/browser.xul 	1.417

Comment 13

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/themes/gnomestripe/browser/browser.css 	1.168
mozilla/browser/themes/pinstripe/browser/browser.css 	1.119
mozilla/browser/themes/winstripe/browser/browser.css 	1.161
mozilla/browser/base/content/browser.js 	1.951
mozilla/browser/base/content/browser.xul 	1.417 

Comment 14

[Bill Gianopoulos [:WG9s]]

This causes issues if the user has selected small icons.  The reset causes large icons to be displayed while the preference is left set at small icons.

The preferences for large/small icons and text display need to be reset to the defaults so that the UI does not end up being inconsistent with the preferences.

Comment 15

[Bill Gianopoulos [:WG9s]]

Actually, if there is an easy way to do it, it would be preferable to re-apply the preferences for icons/text display and icon size after the reset.

Comment 16

[Alfred Kayser]

Why are suddenly some id's changed?
#PersonalToolbar  -> #personal-toolbar 
#nav-bar ->  #navigation-toolbar

I see no real reason to change these...

This is awkward for themers as they need then to maintain two sets of id's to
maintain compatibility of their themes between FF2 and FF3.

Comment 17

[Bill Gianopoulos [:WG9s]]

I decided to file a separate bug on this as I realized a more general fix would also cover the case of an absent or corrupt localstore.rdf file.

I filed bug 414836.

Comment 18

[Daniel C]

The code for resetting the customisations doesn't seem to take into account the menubar (File, Edit etc.). I previously moved the search bar to the menubar as there is plenty of space there and I like having a longer locationbar. When starting up the 20080130 nightly however, I now have 2 searchbars, one in the menubar and one in the default place.

Comment 19

[Dão Gottwald [::dao]]

Attachment: don't create duplicate items

I also thought about resetting the menu toolbar, but I think we can avoid that this way.

Comment 20

[Dão Gottwald [::dao]]

Comment on attachment 300402 [details] [diff] [review]
don't create duplicate items

That patch is now in bug 414864.

Comment 21

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #16)
> Why are suddenly some id's changed?

Because we need to reset the toolbar customization state for these new buttons (new back/forward and moved Home button) to affect existing users.

Comment 22

[Ed Hume]

I think the current implementation is unwise.

Currently we have reverted to the Mozilla format: Home button on the Bookmarks Toolbar, with no capacity to add a Home button on any other toolbar.

The problem with this is that not everybody uses bookmarks. I have a daughter, for example, who types in her url's and uses her history to navigate pages. My wife does the same thing. I know that this is a relatively common behavior.

Where my daughter differs from my wife is that my daughter banishes her Bookmarks Toolbar. This new arrangement will be a problem for her: no Home button unless she gives up some precious vertical space, all for a Home button.

I believe, from watching people work, that it will be the less sophisticated users who behave like my daughter. I think we need to provide them with an alternative if they banish the Bookmarks Toolbar. Perhaps an additional instance of the Home button could be available from the Customize window.

Comment 23

[Ed Hume]

Never mind. Turns out you can move the button. Thanks for leaving that capacity in there.

Comment 24

[Francesco Lodolo [:flod]]

(In reply to comment #23)
> Never mind. Turns out you can move the button. Thanks for leaving that capacity
> in there.

I totally agree with comment #22, and I don't think this is enough: most of users don't use (and probably don't know) toolbars customization.

Regarding the interface this is a glitch: all items in the bookmarks toolbar can be deleted using shortcut menu (even "smark bookmarks"), "home" can't be removed since it's a button and not a bookmark (and this is not clear at all).

Last thing: most of localizations use a long name for home button, resulting in a large loss of space in the bookmarks toolbar (the Italian one is 15 letters long).

Comment 25

[David Naylor]

(In reply to comment #23)
> Never mind. Turns out you can move the button. Thanks for leaving that capacity
> in there.
> 

Hm... I can't seem to move the home button now... (or the bookmark field, which I would like to put to the right of my menus). How did you do it?

Comment 26

[Martijn (MozBrowser.nl)]

(In reply to comment #25)
Be sure you have enabled the Bookmarks Toolbar from the menu View > Toolbars. 
The Home-button is by default on this Bookmarks Toolbar. Now right click on the Home button and choose Customize... 
A dialog appears and you can drag the Home button to this dialog to remove it. You can now also move the Bookmark Toolbar Items to another location (I placed it left from the throbber). This is how it also currently works in Firefox 2, but now we also have the option to move the Bookmarks toolbar elsewhere and hide the Bookmarks-toolbar for which I want to thank the Mozilla developers.

Comment 27

[David Naylor]

Sorry for the spam... It must have been an extension conflict somehow, it worked when I launched in safe mode.

Comment 28

[Martijn Wargers (dead)]

(In reply to comment #24)
> Regarding the interface this is a glitch: all items in the bookmarks toolbar
> can be deleted using shortcut menu (even "smark bookmarks"), "home" can't be
> removed since it's a button and not a bookmark (and this is not clear at all).

Hi Francesco, I filed bug 415741 for this.

Comment 29

[Jesse Ruderman]

Bug 417152 suggests reverting this change.

Comment 30

[Valerio Capello]

See also Bug 89350

Comment 31

[Rob S]

Strongly suggest moving Home button back to main toolbar.  You're going to loose a lot of favour with users if their familiar button is gone, and hard to put back (I had to Google to find it!)

Comment 32

[Kris Silver]

I also strongly urge the home button, a navigation button, to stay in the navigation toolbar.  

Moving basic toolbar items sectioned correctly in the appropriate toolbar, onto others, is a massive UI change breaking basic understanding of what buttons are what, and where to find certain kinds of buttons.  Moving a navigation button to the un-required bookmarks manager many do not need or show, is a big mistake.

Many users with the bookmarks toolbar shown will wonder where it is, why has it moved they'll ask.  Many Firefox's out there without the bookmarks toolbar shown will be more confused, and think they've lost the home button altogether.  This is because won't be in the immediate interface, or the customize pallet, which incidentally few novice users use, and shouldn't have to.  

Expecting even a long term Firefox user without the Bookmarks toolbar shown, to blindly guess that's where this basic navigational item has been moved, is un-realistic.

Comment 33

[Jesse Ruderman]

This was made less annoying in bug 417152 and then reverted in bug 422420.  See bug 414829 for some remaining fallout.