Closed Bug 404109 Opened 12 years ago Closed 12 years ago

move the Home button to the Bookmarks toolbar, and reset toolbars for Firefox 3

Categories

(Firefox :: Toolbars and Customization, enhancement, P1)

enhancement

Tracking

()

RESOLVED WONTFIX
Firefox 3 beta3

People

(Reporter: dao, Assigned: dao)

References

(Depends on 1 open bug)

Details

(Keywords: addon-compat)

Attachments

(2 files, 6 obsolete files)

Attached image screenshot
Would be great if someone could try this on OS X:

https://build.mozilla.org/tryserver-builds/2007-11-16_14:52-dgottwald@mozilla.com-1195253500/

Note that the home button will only be moved if you haven't customized your toolbars. If you have, you can either move it manually or use "Restore Default Set".
Attached patch patch (obsolete) — Splinter Review
Flags: blocking-firefox3?
wow, filed and implemented before I even got a chance to file :)
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P4
Not a blocker, but likely to happen.
Flags: wanted-firefox3+
Flags: blocking-firefox3-
Flags: blocking-firefox3+
Target Milestone: --- → Firefox 3 M11
Attached patch patch v2 (obsolete) — Splinter Review
With this patch I'm modifying the class name of the button to get the appearance of a bookmark item without duplicating many style rules.

The first patch also didn't look right with Pinstripe.
Attachment #289077 - Attachment is obsolete: true
Attachment #291624 - Flags: review?(mconnor)
Attachment #291624 - Flags: superreview?(mconnor)
Attachment #291624 - Flags: review?(mconnor)
Attachment #291624 - Flags: review+
Attachment #291624 - Flags: approval1.9?
Attached patch patch v3 (obsolete) — Splinter Review
including the new ids in order to reset the toolbarsets for all users
Attachment #300270 - Flags: review?(gavin.sharp)
Keywords: late-compat
Attachment #300270 - Flags: superreview?(mconnor)
Attachment #300270 - Flags: review?(gavin.sharp)
Attachment #300270 - Flags: review+
Attachment #300270 - Flags: approval1.9?
Attachment #291624 - Attachment is obsolete: true
Attachment #291624 - Flags: superreview?(mconnor)
Attachment #291624 - Flags: approval1.9?
Comment on attachment 300270 [details] [diff] [review]
patch v3

sr=me, but we need to be _very_ explicit publicly about what we're doing here, both for users and for themers
Attachment #300270 - Flags: superreview?(mconnor)
Attachment #300270 - Flags: superreview+
Attachment #300270 - Flags: approval1.9?
Attachment #300270 - Flags: approval1.9+
Attached patch updated patch v3 (obsolete) — Splinter Review
Attachment #300270 - Attachment is obsolete: true
Comment on attachment 300301 [details] [diff] [review]
updated patch v3

a=beltzner for beta 3
Attachment #300301 - Flags: approval1.9b3+
Attached patch fixed updated patch v3 (obsolete) — Splinter Review
Needed to fix the "#personal-toolbar >" selectors to be child selectors, to still match the item while wrapped in the personal toolbar. Also fixed a type in setPersonalToolbarStyle that was checking for the old personal toolbar ID.

I'm going to land this now.
Attachment #300301 - Attachment is obsolete: true
Given bug 414811 comment 1, I'm going to stick to using the child selector for now.
Attachment #300335 - Attachment is obsolete: true
mozilla/browser/themes/gnomestripe/browser/browser.css 	1.168
mozilla/browser/themes/pinstripe/browser/browser.css 	1.119
mozilla/browser/themes/winstripe/browser/browser.css 	1.161
mozilla/browser/base/content/browser.js 	1.951
mozilla/browser/base/content/browser.xul 	1.417
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
mozilla/browser/themes/gnomestripe/browser/browser.css 	1.168
mozilla/browser/themes/pinstripe/browser/browser.css 	1.119
mozilla/browser/themes/winstripe/browser/browser.css 	1.161
mozilla/browser/base/content/browser.js 	1.951
mozilla/browser/base/content/browser.xul 	1.417 
Summary: move the Home button to the Bookmarks toolbar → move the Home button to the Bookmarks toolbar, and reset toolbars for Firefox 3
This causes issues if the user has selected small icons.  The reset causes large icons to be displayed while the preference is left set at small icons.

The preferences for large/small icons and text display need to be reset to the defaults so that the UI does not end up being inconsistent with the preferences.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Actually, if there is an easy way to do it, it would be preferable to re-apply the preferences for icons/text display and icon size after the reset.
Why are suddenly some id's changed?
#PersonalToolbar  -> #personal-toolbar 
#nav-bar ->  #navigation-toolbar

I see no real reason to change these...

This is awkward for themers as they need then to maintain two sets of id's to
maintain compatibility of their themes between FF2 and FF3.
Depends on: 414829
Depends on: 414836
I decided to file a separate bug on this as I realized a more general fix would also cover the case of an absent or corrupt localstore.rdf file.

I filed bug 414836.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
The code for resetting the customisations doesn't seem to take into account the menubar (File, Edit etc.). I previously moved the search bar to the menubar as there is plenty of space there and I like having a longer locationbar. When starting up the 20080130 nightly however, I now have 2 searchbars, one in the menubar and one in the default place.
Status: RESOLVED → REOPENED
Flags: blocking-firefox3- → blocking-firefox3?
Priority: P4 → P1
Resolution: FIXED → ---
Attached patch don't create duplicate items (obsolete) — Splinter Review
I also thought about resetting the menu toolbar, but I think we can avoid that this way.
Attachment #300402 - Flags: review?(gavin.sharp)
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Depends on: 414864
Flags: blocking-firefox3?
Resolution: --- → FIXED
Comment on attachment 300402 [details] [diff] [review]
don't create duplicate items

That patch is now in bug 414864.
Attachment #300402 - Attachment is obsolete: true
Attachment #300402 - Flags: review?(gavin.sharp)
(In reply to comment #16)
> Why are suddenly some id's changed?

Because we need to reset the toolbar customization state for these new buttons (new back/forward and moved Home button) to affect existing users.
I think the current implementation is unwise.

Currently we have reverted to the Mozilla format: Home button on the Bookmarks Toolbar, with no capacity to add a Home button on any other toolbar.

The problem with this is that not everybody uses bookmarks. I have a daughter, for example, who types in her url's and uses her history to navigate pages. My wife does the same thing. I know that this is a relatively common behavior.

Where my daughter differs from my wife is that my daughter banishes her Bookmarks Toolbar. This new arrangement will be a problem for her: no Home button unless she gives up some precious vertical space, all for a Home button.

I believe, from watching people work, that it will be the less sophisticated users who behave like my daughter. I think we need to provide them with an alternative if they banish the Bookmarks Toolbar. Perhaps an additional instance of the Home button could be available from the Customize window.
Never mind. Turns out you can move the button. Thanks for leaving that capacity in there.
(In reply to comment #23)
> Never mind. Turns out you can move the button. Thanks for leaving that capacity
> in there.

I totally agree with comment #22, and I don't think this is enough: most of users don't use (and probably don't know) toolbars customization.

Regarding the interface this is a glitch: all items in the bookmarks toolbar can be deleted using shortcut menu (even "smark bookmarks"), "home" can't be removed since it's a button and not a bookmark (and this is not clear at all).

Last thing: most of localizations use a long name for home button, resulting in a large loss of space in the bookmarks toolbar (the Italian one is 15 letters long).
(In reply to comment #23)
> Never mind. Turns out you can move the button. Thanks for leaving that capacity
> in there.
> 

Hm... I can't seem to move the home button now... (or the bookmark field, which I would like to put to the right of my menus). How did you do it?
(In reply to comment #25)
Be sure you have enabled the Bookmarks Toolbar from the menu View > Toolbars. 
The Home-button is by default on this Bookmarks Toolbar. Now right click on the Home button and choose Customize... 
A dialog appears and you can drag the Home button to this dialog to remove it. You can now also move the Bookmark Toolbar Items to another location (I placed it left from the throbber). This is how it also currently works in Firefox 2, but now we also have the option to move the Bookmarks toolbar elsewhere and hide the Bookmarks-toolbar for which I want to thank the Mozilla developers.
Sorry for the spam... It must have been an extension conflict somehow, it worked when I launched in safe mode.
Depends on: 415741
(In reply to comment #24)
> Regarding the interface this is a glitch: all items in the bookmarks toolbar
> can be deleted using shortcut menu (even "smark bookmarks"), "home" can't be
> removed since it's a button and not a bookmark (and this is not clear at all).

Hi Francesco, I filed bug 415741 for this.
Bug 417152 suggests reverting this change.
Depends on: 417152
See also Bug 89350
Strongly suggest moving Home button back to main toolbar.  You're going to loose a lot of favour with users if their familiar button is gone, and hard to put back (I had to Google to find it!)
I also strongly urge the home button, a navigation button, to stay in the navigation toolbar.  

Moving basic toolbar items sectioned correctly in the appropriate toolbar, onto others, is a massive UI change breaking basic understanding of what buttons are what, and where to find certain kinds of buttons.  Moving a navigation button to the un-required bookmarks manager many do not need or show, is a big mistake.

Many users with the bookmarks toolbar shown will wonder where it is, why has it moved they'll ask.  Many Firefox's out there without the bookmarks toolbar shown will be more confused, and think they've lost the home button altogether.  This is because won't be in the immediate interface, or the customize pallet, which incidentally few novice users use, and shouldn't have to.  

Expecting even a long term Firefox user without the Bookmarks toolbar shown, to blindly guess that's where this basic navigational item has been moved, is un-realistic.
This was made less annoying in bug 417152 and then reverted in bug 422420.  See bug 414829 for some remaining fallout.
Resolution: FIXED → WONTFIX
Blocks: 424517
No longer blocks: 424517
You need to log in before you can comment on or make changes to this bug.