414803 - AMO Manager: Can install same extension twice using Addons Manager & AMO

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Tony Chung [:tchung]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008012904 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008012904 Minefield/3.0b3pre

It is possible to install the same Addon twice -- once from AMO Manager, and immediately afterwards from AMO; all before restarting minefield.   Doesnt repro if you perform steps the other way (AMO first, then AMO manager afterwards)

Reproducible: Always

Steps to Reproduce:
1. Install latest nightly
2. Open AMO Manager, and search for compatible addon (eg. simple mail)
3. in Get Addons, install the compatible extension.  Look for "Install Complete"
4. Dont' restart, but go to browser to addons.mozilla.org, and search for the same extension you just installed (eg. simple mail)
5. Go back to Addons Manager, and click on Extensions, Installation
6. Verify it looks like its been installed successfully, and shows up as "Incompatible" extension.  
7. in Extensions, Click "Cancel" button, to cancel the extension before restart.
8. Verify the extension still appears as installed, and the dialog switches to "Disable" or "Uninstall"

** See screenshot.   This doesnt repro if you try installing from AMO first, and then searching for the compatible extension in AMO Manager.  The results just dont appear.
Actual Results:  
Shouldn't be able to install the same extension via AMO after installing in AMO Manager

Expected Results:  
Able to install same extension in AMO after installing in AMO manager first.

Comment 1

[Tony Chung [:tchung]]

Attachment: Twice installed Addon screenshot

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Is this new? What happens if you try to install the same add on twice from AMO?

Not blocking (as it doesn't sound like there's too many ill effects, save the UI oddity, and it's not a very common case) but we should investigate.

Comment 3

[Dave Townsend [:mossop]]

If I'm reading this correctly the bug is that clicking cancel in step 7 isn't cancelling the extension install, is that correct? I cannot reproduce that, the addon goes away fine.

Or am I missing a step? Nowhere do you mention where the second attempt to install happens.

Comment 4

[u279076]

(In reply to comment #3)
> If I'm reading this correctly the bug is that clicking cancel in step 7 isn't
> cancelling the extension install, is that correct? I cannot reproduce that, the
> addon goes away fine.
> 
> Or am I missing a step? Nowhere do you mention where the second attempt to
> install happens.
> 

I am seeing this bug with some Songbird testing as well.  I confirmed that it is happening with the latest Minefield nightly.  Here are my STR...

STR:
1. Open Mineifield
2. Navigate to AMO
3. Click on one of the featured addons from the front page to install it
4. Restart Minefield
5. Navigate back to AMO and repeat step 3 and 4.

You can do this continuously with not checking of whether the addon is already installed or not.

Comment 5

[Dave Townsend [:mossop]]

Tony, can you please respond to comment 3. I can't quite get my head around what the problem you are describing is.

Comment 6

[Dave Townsend [:mossop]]

(In reply to comment #4)
> You can do this continuously with not checking of whether the addon is already
> installed or not.

This is a separate issue I think. It is possible we might want to tell the user they are attempting to install the same version of an add-on that is already installed, but I'm not sure there is a lot of benefit to that.

Comment 7

[Tony Chung [:tchung]]

(In reply to comment #5)
> Tony, can you please respond to comment 3. I can't quite get my head around
> what the problem you are describing is.

Gah.  I cant reproduce this anymore.  This seems to be working correctly in 3.1 and 3.0.2 nightlies.   But basically, you would see that canceling the installation, and switching back to the extensions tab immediately, the screenshot would have appeared with the message.   

But now it looks like its correctly reverting back to the right UI.   I'll reopen the bug if i see it again.