414811 - No "small icons" on Mac

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Note this also affects the Home button when customizing the toolbar now that bug 404109 has landed.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #0)
> Note this also affects the Home button when customizing the toolbar now that
> bug 404109 has landed.

Hrm, I guess that might be intentional, given that the patch explicitly calls unsetPersonalToolbarStyle from BrowserCustomizeToolbar(). That's a weird glitch that we should probably fix.

Comment 2

[Dão Gottwald [:dao]]

Well, setPersonalToolbarStyle won't be called as you move the button (but only after you're done), so I figured it's better to just use the legacy button while customizing.
That's also why I was using |#personal-toolbar > #home-button| rather than |#personal-toolbar #home-button|.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

It just looks odd to see the personal toolbar increase in size when you choose "customize" (since the "normal" button is much taller than the text-only label).

Comment 4

[Dão Gottwald [:dao]]

We could do something along the lines of attachment 296825 [details] [diff] [review] to keep track of the home button's position and update its class name.

Comment 5

[Mike Connor [:mconnor]]

WONTFIX, this is intended.  Need to add CSS to hide the small icons checkbox.

Comment 6

[Kevin Gerich]

I was thinking when we land the Bulbous Back Button default appearance, we could use the "small icons" option to switch to a smaller version of the back/forward buttons, like what we have in the theme now. What do you think?

Comment 7

[Mike Connor [:mconnor]]

Hmm, that's an interesting idea, but I think it might be an odd mix of expectations... lemme think about that...

Comment 8

[:Gavin Sharp [email: [e-mail]]]

I filed bug 414902 about the home icon specifically.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

>I was thinking when we land the Bulbous Back Button default appearance, we
>could use the "small icons" option to switch to a smaller version of the
>back/forward buttons, like what we have in the theme now. What do you think?

Yeah, I'm totally on board with this idea and I previously proposed it on the Windows bug as well (bug 411725).  While the keyhole design has the advantages of making firefox look new, building product identity, and making the back button easier to hit, and while it seems to be getting in general a positive reaction so far, some people still really hate it.  The solution of "let's make a pref" is often inferior to choosing the correct default, but in this case I think the change is polarizing enough that we should use a pref to help mitigate risk.

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

Filed the spin off bug 415002 about letting users choose if they want to use keyhole.

Comment 12

[Asa Dotzler [:asa]]

So this is fixed now. Small icons shows small icons and large icons shows keyhole large icons. Can we resolve this?

Comment 13

[Alex Faaborg [:faaborg] (Firefox UX)]

Either resolved or wontfixed, depending on your definition of small icons.  Setting to wontfix since a lot of bugs will likely be duplicates of this one.