"print.use_native_print_dialog" preferences is pointless

RESOLVED FIXED in mozilla1.9.1b1

Status

()

--
trivial
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: bzbarsky, Assigned: wolfiR)

Tracking

Trunk
mozilla1.9.1b1
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

We don't use it for anything.  It's just taking up space in memory (since we do set it in all.js) and confusing people into thinking that they have a choice.

Updated

11 years ago
Blocks: 414947

Updated

11 years ago
No longer blocks: 414947

Comment 1

11 years ago
As one of those confused people, I agree, let's go ahead and kill it!

Updated

10 years ago
Duplicate of this bug: 454218
(Assignee)

Comment 3

10 years ago
BTW, same for print.extend_native_print_dialog
(Assignee)

Comment 4

10 years ago
Created attachment 337857 [details] [diff] [review]
patch
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
(Assignee)

Comment 5

10 years ago
Comment on attachment 337857 [details] [diff] [review]
patch

argl, that one contains some non-related stuff, sorry
Attachment #337857 - Attachment is obsolete: true
(Assignee)

Comment 6

10 years ago
Created attachment 337858 [details] [diff] [review]
real patch
(Assignee)

Updated

10 years ago
Attachment #337858 - Flags: review?(gavin.sharp)
(Assignee)

Updated

10 years ago
OS: Linux → All
Comment on attachment 337858 [details] [diff] [review]
real patch

>diff --git a/js/tests/e4x/Regress/regress-308111.js b/js/tests/e4x/Regress/regress-308111.js

Are you sure these changes don't affect the bug this was trying to test? Probably best to just leave them, they're just used as dummy data here.

>diff --git a/modules/libpref/src/init/all.js b/modules/libpref/src/init/all.js

>-pref("print.extend_native_print_dialog", true);

Shouldn't you also be removing http://mxr.mozilla.org/mozilla-central/source/embedding/components/printingui/src/win/nsPrintDialogUtil.cpp#856 if you're going to remove this?
(Assignee)

Comment 8

10 years ago
Created attachment 337896 [details] [diff] [review]
patch #2
[Checkin: Comment 10]

print.extend_native_print_dialog is not that unused it seems. For some weird reason I haven't found that code snippet in my first search.
So I leave extend_native_print_dialog untouched and also the JS test.
Attachment #337858 - Attachment is obsolete: true
Attachment #337858 - Flags: review?(gavin.sharp)
(Assignee)

Updated

10 years ago
Attachment #337896 - Flags: review?(gavin.sharp)
Comment on attachment 337896 [details] [diff] [review]
patch #2
[Checkin: Comment 10]

r=me, but I'm not sure why you picked me to review this :)
Attachment #337896 - Flags: review?(gavin.sharp) → review+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Comment on attachment 337896 [details] [diff] [review]
patch #2
[Checkin: Comment 10]

http://hg.mozilla.org/mozilla-central/rev/d2e445b98a77
Attachment #337896 - Attachment description: patch #2 → patch #2 [Checkin: Comment 10]
Severity: normal → trivial
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
You need to log in before you can comment on or make changes to this bug.