Closed
Bug 414901
Opened 16 years ago
Closed 16 years ago
Back out scriptable IO
Categories
(Core :: XPCOM, defect, P1)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
(Keywords: addon-compat, dev-doc-complete)
Attachments
(1 file)
95.29 KB,
patch
|
benjamin
:
review+
benjamin
:
superreview+
beltzner
:
approval1.9b3+
|
Details | Diff | Splinter Review |
Due to some problems with it (bug 396051 as well as bug 399242) I think we should not include the scriptable IO apis in 1.9. The former bug describes some api issues that I think are more important to fix before people start to use it and I would rather have better more robust APIs that have to fix issues with it later.
Flags: blocking1.9?
Updated•16 years ago
|
Assignee: nobody → enndeakin
OS: Mac OS X → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla1.9beta3
Updated•16 years ago
|
Attachment #300414 -
Flags: approval1.9b3?
Comment 1•16 years ago
|
||
Comment on attachment 300414 [details] [diff] [review] back out patch a=beltzner, fixes a beta3 blocker
Attachment #300414 -
Flags: approval1.9b3? → approval1.9b3+
Updated•16 years ago
|
Flags: blocking1.9? → blocking1.9+
Assignee | ||
Updated•16 years ago
|
Attachment #300414 -
Flags: superreview?(benjamin)
Attachment #300414 -
Flags: review?(benjamin)
Updated•16 years ago
|
Attachment #300414 -
Flags: superreview?(benjamin)
Attachment #300414 -
Flags: superreview+
Attachment #300414 -
Flags: review?(benjamin)
Attachment #300414 -
Flags: review+
Assignee | ||
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 2•16 years ago
|
||
So did this broke context menus? Failed to load XPCOM component: /home/smaug/mozilla/mozilla_cvs/mozilla/ff_build/dist/bin/components/nsScriptableIO.js Error: IO is not defined Source File: chrome://browser/content/utilityOverlay.js Line: 450
Assignee | ||
Comment 3•16 years ago
|
||
Hmmm. Looks like there's a bunch of places where IO.newURI was being used. We should either just unbackout IO again or fix up the newURI calls to use the IOService instead.
Comment 4•16 years ago
|
||
Until bug 415218 is fixed, Gavin requested that I back out the back out so that nightlies aren't completely broken for everybody. When this gets backed out again for good, please remember to remove xpcom/io/nsIScriptableStreams.idl and add components/nsScriptableIO.js to browser/installer/removed-files.in and family.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 5•16 years ago
|
||
I backed out the back out of the back out. Checking in browser/installer/removed-files.in; /cvsroot/mozilla/browser/installer/removed-files.in,v <-- removed-files.in new revision: 1.33; previous revision: 1.32 done Checking in browser/installer/unix/packages-static; /cvsroot/mozilla/browser/installer/unix/packages-static,v <-- packages-static new revision: 1.150; previous revision: 1.149 done Checking in browser/installer/windows/packages-static; /cvsroot/mozilla/browser/installer/windows/packages-static,v <-- packages-static new revision: 1.151; previous revision: 1.150 done Checking in xpcom/build/nsXPComInit.cpp; /cvsroot/mozilla/xpcom/build/nsXPComInit.cpp,v <-- nsXPComInit.cpp new revision: 1.257; previous revision: 1.256 done Checking in xpcom/io/Makefile.in; /cvsroot/mozilla/xpcom/io/Makefile.in,v <-- Makefile.in new revision: 1.96; previous revision: 1.95 done Removing xpcom/io/nsIScriptableStreams.idl; /cvsroot/mozilla/xpcom/io/nsIScriptableStreams.idl,v <-- nsIScriptableStreams.idl new revision: delete; previous revision: 1.3 done Checking in xpcom/io/nsLocalFileOS2.cpp; /cvsroot/mozilla/xpcom/io/nsLocalFileOS2.cpp,v <-- nsLocalFileOS2.cpp new revision: 1.102; previous revision: 1.101 done Checking in xpcom/io/nsLocalFileOS2.h; /cvsroot/mozilla/xpcom/io/nsLocalFileOS2.h,v <-- nsLocalFileOS2.h new revision: 1.35; previous revision: 1.34 done Checking in xpcom/io/nsLocalFileOSX.cpp; /cvsroot/mozilla/xpcom/io/nsLocalFileOSX.cpp,v <-- nsLocalFileOSX.cpp new revision: 1.58; previous revision: 1.57 done Checking in xpcom/io/nsLocalFileOSX.h; /cvsroot/mozilla/xpcom/io/nsLocalFileOSX.h,v <-- nsLocalFileOSX.h new revision: 1.16; previous revision: 1.15 done Checking in xpcom/io/nsLocalFileUnix.cpp; /cvsroot/mozilla/xpcom/io/nsLocalFileUnix.cpp,v <-- nsLocalFileUnix.cpp new revision: 1.140; previous revision: 1.139 done Checking in xpcom/io/nsLocalFileUnix.h; /cvsroot/mozilla/xpcom/io/nsLocalFileUnix.h,v <-- nsLocalFileUnix.h new revision: 1.29; previous revision: 1.28 done Checking in xpcom/io/nsLocalFileWin.cpp; /cvsroot/mozilla/xpcom/io/nsLocalFileWin.cpp,v <-- nsLocalFileWin.cpp new revision: 1.179; previous revision: 1.178 done Checking in xpcom/io/nsLocalFileWin.h; /cvsroot/mozilla/xpcom/io/nsLocalFileWin.h,v <-- nsLocalFileWin.h new revision: 1.30; previous revision: 1.29 done Checking in xpcom/io/nsScriptableInputStream.cpp; /cvsroot/mozilla/xpcom/io/nsScriptableInputStream.cpp,v <-- nsScriptableInputStream.cpp new revision: 1.17; previous revision: 1.16 done Checking in xpcom/io/nsScriptableInputStream.h; /cvsroot/mozilla/xpcom/io/nsScriptableInputStream.h,v <-- nsScriptableInputStream.h new revision: 1.13; previous revision: 1.12 done Removing xpcom/io/nsScriptableOutputStream.cpp; /cvsroot/mozilla/xpcom/io/nsScriptableOutputStream.cpp,v <-- nsScriptableOutputStream.cpp new revision: delete; previous revision: 1.4 done Removing xpcom/io/nsScriptableOutputStream.h; /cvsroot/mozilla/xpcom/io/nsScriptableOutputStream.h,v <-- nsScriptableOutputStream.h new revision: delete; previous revision: 1.3 done Checking in suite/installer/removed-files.in; /cvsroot/mozilla/suite/installer/removed-files.in,v <-- removed-files.in new revision: 1.16; previous revision: 1.15 done Checking in suite/installer/windows/packages; /cvsroot/mozilla/suite/installer/windows/packages,v <-- packages new revision: 1.47; previous revision: 1.46 done Checking in netwerk/base/public/Makefile.in; /cvsroot/mozilla/netwerk/base/public/Makefile.in,v <-- Makefile.in new revision: 1.125; previous revision: 1.124 done Removing netwerk/base/public/nsIScriptableIO.idl; /cvsroot/mozilla/netwerk/base/public/nsIScriptableIO.idl,v <-- nsIScriptableIO.idl new revision: delete; previous revision: 1.3 done Checking in netwerk/base/src/Makefile.in; /cvsroot/mozilla/netwerk/base/src/Makefile.in,v <-- Makefile.in new revision: 1.101; previous revision: 1.100 done Removing netwerk/base/src/nsScriptableIO.js; /cvsroot/mozilla/netwerk/base/src/nsScriptableIO.js,v <-- nsScriptableIO.js new revision: delete; previous revision: 1.3 done Checking in netwerk/test/Makefile.in; /cvsroot/mozilla/netwerk/test/Makefile.in,v <-- Makefile.in new revision: 1.99; previous revision: 1.98 done Removing netwerk/test/chrome/Makefile.in; /cvsroot/mozilla/netwerk/test/chrome/Makefile.in,v <-- Makefile.in new revision: delete; previous revision: 1.4 done Removing netwerk/test/chrome/test_scriptableio.xul; /cvsroot/mozilla/netwerk/test/chrome/test_scriptableio.xul,v <-- test_scriptableio.xul new revision: delete; previous revision: 1.3 done
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Comment 6•16 years ago
|
||
I found at least 1 extension (ClipMarks) that was broke with this change. Not critical, but I will do some evangelism on it and mark it as a compatibility issue.
Keywords: late-compat
Comment 7•16 years ago
|
||
I guess the documentation that was added for bug 380813 should be reverted, or at least marked as "not in Firefox 3"?
Keywords: dev-doc-needed
Comment 8•16 years ago
|
||
I've added a warning to the documentation for nsIScriptableIO that it has been removed from Firefox.
Updated•16 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
Hi, I'm new here and need some help. It looks like xulrunner-1.9bpre4 no longer has nsIScriptableIO API. I'm running prism-0.8 which has this line: IO.getFile("Profile", null) That now throws "IO not defined". This thread seems to suggest nsIScriptableIO is being phased out, so what's the new alternative? Thanks!
Comment 10•16 years ago
|
||
You actually need to use the "old" ways. See the code snippets here: http://developer.mozilla.org/en/docs/Code_snippets:File_I/O#Getting_special_files You want the "ProfD" folder.
Assignee | ||
Updated•16 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•