AMO integration for SeaMonkey

RESOLVED FIXED

Status

SeaMonkey
General
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: mcsmurf, Assigned: mossop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

4.25 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

10 years ago
+++ This bug was initially created as a clone of Bug #414674 +++

Set up the AMO integration pane in the Add-ons manager from bug 404024 in SeaMonkey. Also see Bug 414674 for more infos.

Comment 1

10 years ago
IIRC, Mossop said he might look into adding it for all of SeaMonkey, Thunderbird and Sunbird once he has fulfilled the FF deadlines. Given the long tail of followups on the original bug, I guess he's happy about help, though (if we can afford it - we are busy with lots of stuff as well).
(Assignee)

Comment 2

10 years ago
I can certainly take this some time next week after the b3 freeze deadline. Otherwise it should only be adding the preferences that were added to firefox and packaging the nsAMORepository.js file

Comment 3

9 years ago
Is someone looking into this? It should be easy to do, I guess, just needs someone to do a patch like the one in bug 414674...
(Assignee)

Comment 4

9 years ago
Sorry, time got away from me and this vanished from my radar. I can knock this together tomorrow I think.
Assignee: general → dtownsend
(Assignee)

Comment 5

9 years ago
Created attachment 320902 [details] [diff] [review]
patch rev 1

This seems to do the job. I'm not all the well up on the Seamonkey review requirements so please pass on to someone more appropriate if I've got it wrong.
Attachment #320902 - Flags: superreview?
Attachment #320902 - Flags: review?
(Assignee)

Updated

9 years ago
Attachment #320902 - Flags: superreview?(neil)
Attachment #320902 - Flags: superreview?
Attachment #320902 - Flags: review?(neil)
Attachment #320902 - Flags: review?

Comment 6

9 years ago
Comment on attachment 320902 [details] [diff] [review]
patch rev 1

>Index: suite/browser/browser-prefs.js
>===================================================================
>+pref("extensions.getAddons.browseAddons", "https://%LOCALE%.add-ons.mozilla.com/%LOCALE%/%APP%");
>+pref("extensions.getAddons.recommended.browseURL", "https://%LOCALE%.add-ons.mozilla.com/%LOCALE%/%APP%/recommended");
>+pref("extensions.getAddons.search.browseURL", "https://%LOCALE%.add-ons.mozilla.com/%LOCALE%/%APP%/search?q=%TERMS%");

Nit: Please use add-ons.mozilla.org instead of .com for us in those prefs, it redirects to the same target anyway, but it would be good to keep mozilla.com URLs to MoCo-specific stuff only as far as possible.

Updated

9 years ago
Attachment #320902 - Flags: superreview?(neil)
Attachment #320902 - Flags: superreview+
Attachment #320902 - Flags: review?(neil)
Attachment #320902 - Flags: review+
(Assignee)

Comment 7

9 years ago
Landed, fixed those URL nits on checkin.

Checking in browser/browser-prefs.js;
/cvsroot/mozilla/suite/browser/browser-prefs.js,v  <--  browser-prefs.js
new revision: 1.94; previous revision: 1.93
done
Checking in installer/unix/packages;
/cvsroot/mozilla/suite/installer/unix/packages,v  <--  packages
new revision: 1.16; previous revision: 1.15
done
Checking in installer/windows/packages;
/cvsroot/mozilla/suite/installer/windows/packages,v  <--  packages
new revision: 1.56; previous revision: 1.55
done
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.