Closed
Bug 414945
Opened 18 years ago
Closed 18 years ago
Home button styling incorrect on startup when placed in the navigation toolbar
Categories
(Firefox :: General, defect, P1)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 3 beta3
People
(Reporter: Gavin, Assigned: dao)
References
Details
Attachments
(1 file, 1 obsolete file)
|
12.28 KB,
patch
|
Gavin
:
review+
beltzner
:
approval1.9b3+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
I had to disable the call to gHomeButton.setPersonalToolbarStyle in delayedStartup to fix the Txul/Twinopen regression from bug 404109 (see http://bonsai.mozilla.org/cvsquery.cgi?dir=mozilla%2Fbrowser&who=gavin%25gavinsharp.com&whotype=match&date=explicit&mindate=2008-01-30+10%3A23&maxdate=2008-01-30+12%3A30 ). Dao had a good idea to solve this without the startup hit: persist the class attribute.
Flags: blocking-firefox3?
|
Assignee | |
Updated•18 years ago
|
Assignee: nobody → dao
|
|
Assignee | |
Comment 1•18 years ago
|
||
|
|
Assignee | |
Comment 2•18 years ago
|
||
Attachment #300484 -
Attachment is obsolete: true
Attachment #300497 -
Flags: review?(gavin.sharp)
|
Reporter | |
Comment 3•18 years ago
|
||
Comment on attachment 300497 [details] [diff] [review]
patch
Awesome, thanks!
Attachment #300497 -
Flags: review?(gavin.sharp)
Attachment #300497 -
Flags: review+
Attachment #300497 -
Flags: approval1.9b3?
|
||
Updated•18 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P1
Target Milestone: --- → Firefox 3 beta3
|
|
||
Comment 4•18 years ago
|
||
Comment on attachment 300497 [details] [diff] [review]
patch
a=beltzner for beta 3
Attachment #300497 -
Flags: approval1.9b3?
Attachment #300497 -
Flags: approval1.9b3+
Attachment #300497 -
Flags: approval1.9+
|
|
Reporter | |
Comment 5•18 years ago
|
||
mozilla/toolkit/content/customizeToolbar.js 1.41
mozilla/browser/base/content/browser.js 1.955
mozilla/browser/base/content/browser.xul 1.421
mozilla/browser/themes/gnomestripe/browser/browser.css 1.170
mozilla/browser/themes/winstripe/browser/browser.css 1.162
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 7•18 years ago
|
||
Verified fix on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3) Gecko/2008020513 Firefox/3.0b3 and
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020418 Firefox/3.0b3
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•