Closed Bug 415026 Opened 13 years ago Closed 13 years ago
IME is always enabled in a page has content
If a page has contentEditable=true, the all content enables IME. Even if the document has HTML Editor, we need to check the current node being editable.
Oops, I posted old patch, sorry for the spam.
+ if (isEditable && aContent->HasFlag(NODE_IS_EDITABLE)) Isn't it enough to just check NODE_IS_EDITABLE?
(In reply to comment #2) > + if (isEditable && aContent->HasFlag(NODE_IS_EDITABLE)) > > Isn't it enough to just check NODE_IS_EDITABLE? No. textarea and input returns TRUE for it. They are support ime-mode now. So, aContent->GetDesiredIMEState() must be called for them. However, ime-mode doesn't support contentEditable element. So, we must not call it in HTML editors.
Then if we have a document which has some contenteditable content, and aContent is in a textarea in the same document but not in a contenteditable region, we're going to return early without checking ime-mode.
Ugh... You're right.
We should check whether the content is editable in nsIContent::GetDesiredIMEState(). If it is non-editable, should be IME_STATUS_DISABLE. If it has editable parent, we should use the state for most editable ancestor's. If the parent is not editable, use IME_STATUS_ENABLE.
roc: would you check the new patch?
Comment on attachment 301239 [details] [diff] [review] Patch rv2.0 Thanks. This feature is a part of a marketing key point for Mozilla Japan. The risk is low, I need to land this.
Attachment #301239 - Flags: approval1.9?
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
13 years ago
Depends on: 416551
regression. sometimes, cannot change input mode. (cannot input JAPANSESE) "HANKAKU/ZENKAKU" dose not work.
see bug 416551.
13 years ago
Depends on: 427245
11 years ago
You need to log in before you can comment on or make changes to this bug.