Closed
Bug 415026
Opened 17 years ago
Closed 17 years ago
IME is always enabled in a page has contentEditable=true
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
People
(Reporter: masayuki, Assigned: masayuki)
References
()
Details
(Keywords: inputmethod)
Attachments
(1 file, 2 obsolete files)
2.97 KB,
patch
|
roc
:
review+
roc
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
If a page has contentEditable=true, the all content enables IME. Even if the document has HTML Editor, we need to check the current node being editable.
Attachment #300590 -
Flags: superreview?(roc)
Attachment #300590 -
Flags: review?(roc)
Assignee | ||
Comment 1•17 years ago
|
||
Oops, I posted old patch, sorry for the spam.
Attachment #300590 -
Attachment is obsolete: true
Attachment #300638 -
Flags: superreview?(roc)
Attachment #300638 -
Flags: review?(roc)
Attachment #300590 -
Flags: superreview?(roc)
Attachment #300590 -
Flags: review?(roc)
+ if (isEditable && aContent->HasFlag(NODE_IS_EDITABLE))
Isn't it enough to just check NODE_IS_EDITABLE?
Assignee | ||
Comment 3•17 years ago
|
||
(In reply to comment #2)
> + if (isEditable && aContent->HasFlag(NODE_IS_EDITABLE))
>
> Isn't it enough to just check NODE_IS_EDITABLE?
No. textarea and input returns TRUE for it. They are support ime-mode now. So, aContent->GetDesiredIMEState() must be called for them. However, ime-mode doesn't support contentEditable element. So, we must not call it in HTML editors.
Then if we have a document which has some contenteditable content, and aContent is in a textarea in the same document but not in a contenteditable region, we're going to return early without checking ime-mode.
Assignee | ||
Comment 5•17 years ago
|
||
Ugh... You're right.
Assignee | ||
Comment 6•17 years ago
|
||
We should check whether the content is editable in nsIContent::GetDesiredIMEState(). If it is non-editable, should be IME_STATUS_DISABLE. If it has editable parent, we should use the state for most editable ancestor's. If the parent is not editable, use IME_STATUS_ENABLE.
Attachment #300638 -
Attachment is obsolete: true
Attachment #301239 -
Flags: superreview?(roc)
Attachment #301239 -
Flags: review?(roc)
Attachment #300638 -
Flags: superreview?(roc)
Attachment #300638 -
Flags: review?(roc)
Assignee | ||
Comment 7•17 years ago
|
||
roc:
would you check the new patch?
Attachment #301239 -
Flags: superreview?(roc)
Attachment #301239 -
Flags: superreview+
Attachment #301239 -
Flags: review?(roc)
Attachment #301239 -
Flags: review+
Assignee | ||
Comment 8•17 years ago
|
||
Comment on attachment 301239 [details] [diff] [review]
Patch rv2.0
Thanks.
This feature is a part of a marketing key point for Mozilla Japan. The risk is low, I need to land this.
Attachment #301239 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #301239 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 9•17 years ago
|
||
checked-in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 10•17 years ago
|
||
regression.
sometimes, cannot change input mode. (cannot input JAPANSESE)
"HANKAKU/ZENKAKU" dose not work.
Assignee | ||
Comment 11•17 years ago
|
||
see bug 416551.
Comment 12•17 years ago
|
||
thanks.
Assignee | ||
Updated•15 years ago
|
Keywords: inputmethod
You need to log in
before you can comment on or make changes to this bug.
Description
•