The default bug view has changed. See this FAQ.

Redirect unsupported locales to one that works

RESOLVED FIXED in 3.2

Status

addons.mozilla.org Graveyard
Public Pages
--
major
RESOLVED FIXED
9 years ago
a year ago

People

(Reporter: Atsushi Sakai, Assigned: clouserw)

Tracking

PowerPC
Mac OS X

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; ja; rv:1.9b3pre) Gecko/2008013104 Minefield/3.0b3pre Firefox/3.0b
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; ja-JP-mac; rv:1.9b3pre) Gecko/2008013104 Minefield/3.0b3pre

Get Add-ons does not work with ja-JP-mac (Japanese for Mac OS X) locale.

Reproducible: Always

Steps to Reproduce:
1. Use Firefox with ja-JP-mac locale.
2. Open Tools -> Add-ons -> Get Add-ons
3.
Actual Results:  

Get Add-ons does not work.

Expected Results:  
Get Add-ons works.

The cause of this bug is that
https://services.addons.mozilla.org/ja-JP-mac/firefox/api/list/featured/all/10
and
https://services.addons.mozilla.org/ja-JP-mac/firefox/api/search/add-ons
is redirected to invalid URL.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → 3.0

Comment 1

9 years ago
addons.mozilla.org doesn't support the ja-JP-mac locale (hence the API doesn't
either, since it uses the same data).  

addons has this problem with the redirection too: if you go to 
https://addons.mozilla.org/ja-JP-mac/firefox/
you get redirected to
https://addons.mozilla.org/en-US/firefox/ja-JP-mac/firefox/
which 404s. 

I'm trying to work out if we should fall back to en-US - or if there's even a
way to distinguish between a request for an unsupported locale/app for a page
that is valid in en-US and a request for a page that just isn't valid.

Updated

9 years ago
Status: NEW → ASSIGNED
Hmm, www.mozilla.com/www.mozilla.org has supported this since very early on. I wonder why AMO never added support for this locale. Making this into a general "support ja-JP-mac" bug.
Status: ASSIGNED → NEW
Component: API → Public Pages
QA Contact: api → web-ui
Summary: Get Add-ons does not work with ja-JP-mac locale → Support ja-JP-mac locale
This should be solved at a global app level -- Wil can you take a look?
Assignee: nobody → clouserw
Target Milestone: --- → 3.2
(Assignee)

Comment 4

9 years ago
ja-JP-mac is not the problem here.  It happens with any locale FF supports and AMO doesn't.
(Assignee)

Updated

9 years ago
Summary: Support ja-JP-mac locale → Redirect unsupported locales to one that works
(In reply to comment #2)
> Hmm, www.mozilla.com/www.mozilla.org has supported this since very early on. I
> wonder why AMO never added support for this locale.

It's because nobody volunteered yet to translate it :)
(In reply to comment #5)
> It's because nobody volunteered yet to translate it :)

No, it's because AMO doesn't special-case it like we do. "ja-JP-mac" is the same thing as "ja", as far as localizing goes.
(In reply to comment #6)
> > It's because nobody volunteered yet to translate it :)
> 
> No, it's because AMO doesn't special-case it like we do. "ja-JP-mac" is the
> same thing as "ja", as far as localizing goes.

Ah, thanks for the additional info. Gotta love the special cases *sigh*.
(Assignee)

Comment 8

9 years ago
Created attachment 300745 [details] [diff] [review]
add unsupported locale redirection

This patch adds support for the ja-JP-mac special case and it also makes a best guess effort on locales that AMO doesn't support (like ar).  Unsupported locales are redirected to en-US.
Attachment #300745 - Flags: review?
(Assignee)

Comment 9

9 years ago
Comment on attachment 300745 [details] [diff] [review]
add unsupported locale redirection

laura@mozilla and lthomson@mozilla didn't match anything so I'm giving up and going with fligtar. <3
Attachment #300745 - Flags: review? → review?(fligtar)

Updated

9 years ago
Attachment #300745 - Flags: review+
(Assignee)

Comment 10

9 years ago
Thanks, this is fixed in r9893
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Attachment #300745 - Flags: review?(fligtar)
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.