415101 - wrong bookmark and tags edited from the star menu

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Dietrich Ayala (:dietrich)]

[09:25am] Aleksej: Is there a bug on a wrong bookmark being opened in the editor on starring?
[09:25am] dietrich_: Aleksej: not that i know of. can you reproduce it?
[09:25am] dietrich_: does it happen every time, or just with a specific bookmark?
[09:25am] Aleksej: dietrich_: I’ve seen it twice now… at least
[09:25am] dietrich_: regression range?
[09:26am] Aleksej: today
[09:26am] Aleksej: But I didn't use 2008013004.
[09:26am] Aleksej: When I star something and press Edit, sometimes(?) the tags entered for the previous one appear.
[09:26am] Aleksej: If I delete them… (at least the second time it happened) the previous bookmark becomes tagless.

Comment 1

[[:Aleksej]]

Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b3pre) Gecko/2008013104 Minefield/3.0b3pre

1. Go to http://www.mozilla.org/
2. Star the page and press the Edit button, optionally adding some tags.
3. Go to http://www.mozilla.com/ (in a new tab or by following a link).
4. Star it, call/see the editor.

Actual results:
http://www.mozilla.org/ properties (tags, if you added them) are displayed in the fields (and apply to .org if edited).

Expected results:
That should have been http://www.mozilla.com/ properties.

Comment 2

[Asaf Romano (gone)]

This happens because a change event is dispatched on the name picker when the panel is initialized, this calls onNamePickerChange which then calls getItemTitle... which throws if itemId is set to -1... The solution is to bail out early in onNamePickerChange if the panel is not yet initialized.

Comment 3

[Asaf Romano (gone)]

Attachment: patch

see last comment.

Comment 4

[Asaf Romano (gone)]

Attachment: patch

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 300701 [details] [diff] [review]
patch

r=me. however, as i mentioned in irc: we can probably do more to prevent dataloss in exception scenarios like this.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300701 [details] [diff] [review]
patch

a=beltzner for beta 3

Comment 7

[Asaf Romano (gone)]

mozilla/browser/components/places/content/editBookmarkOverlay.js 1.20

Comment 8

[Dietrich Ayala (:dietrich)]

filed bug 415136 about being more defensive here.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3 ID:2008020511

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv