defensively clear data from the add-bookmark panel when hiding it




11 years ago
7 months ago


(Reporter: dietrich, Unassigned)



Firefox Tracking Flags

(Not tracked)




11 years ago
see bug 415101, where an exception caused the panel to be partially initialized with data of the last-edited bookmark. discussion below.

[11:48am] dietrich_: ManoOffice: why is the *last edited* bookmark properties shown in the panel in the STR for that bug?
[11:48am] ManoOffice: dietrich_: because we don't finish initializing the panel?
[11:48am] ManoOffice: because exceptions are hard errors?
[11:48am] dietrich_: shouldn't we clear all that when de-initializing the panel?
[11:49am] ManoOffice: what do you mean by de-initializing?
[11:49am] dietrich_: when hiding it
[11:49am] ManoOffice: we only add the overlay once
[11:49am] ManoOffice: we don't clear textfields and such when you hide the popup
[11:49am] dietrich_: exactly my point 
[11:49am] ManoOffice: that's not necessary
[11:49am] dietrich_: well clearly would've helped here...
[11:49am] ManoOffice: how?
[11:49am] ManoOffice: by showing empty fields?
[11:49am] ManoOffice: that would actually break more stuff
[11:50am] dietrich_: [09:26am] Aleksej: If I delete them… (at least the second time it happened)
[11:50am] dietrich_: the previous bookmark becomes tagless.
[11:50am] dietrich_: wouldn't have that dataloss aspect though, right?
[11:50am] ManoOffice: not really
[11:50am] Aleksej: hm
[11:50am] ManoOffice: for that we need to clear this._uri
[11:51am] ManoOffice: not the textfield itself
[11:51am] dietrich_: whatever, that's what i meant by "clear all that"
[11:51am] Aleksej: Note that I described it better in the comment.
[11:51am] ManoOffice: and we can do that in uninitPanel if you want, but i don't think we are going to catch all dataloss issues when something goes wrong like in this bug
[11:52am] ManoOffice: file a follow up please
[11:52am] ManoOffice: i don't want to change more code before beta there
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Component: Places → Bookmarks & History
QA Contact: places → bookmarks

Comment 2

7 months ago
Per policy at If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Last Resolved: 7 months ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.