415114 - Bookmarks Toolbar folder has a name of "(no title)" in Library dialog, is fine in Add Bookmarks dialog.

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Zehe (:MarcoZ)]

When opening the Library dialog (Bookmarks/Show All Bookmarks), the folder that contains the items on the Bookmarks Toolbar is named "(no title)". It is the first node under the "All Bookmarks" item when that item is expanded in the left tree view.

On the other hand, if adding a bookmark with the Add Bookmarks dialog (CTRL+D), and selecting a folder, the Bookmarks Toolbar is correctly offered as Bookmarks Toolbar in the dropdown.

Comment 1

[Michael Monreal [:micmon]]

I was seeing the same for some time but I just re-added the text myself. Does this affect all users?

Comment 2

[Simon Bünzli]

Interestingly, the name is correctly displayed in the (read-only) properties at the bottom of the Library.

A note: Right-clicking and then selecting Properties results in a dialog titled |Properties of ""| as opposed to the other two top level folders whose dialogs read |Properties of "(null)"|. Could this difference be due to an accidental renaming (as suggested in bug 421530 comment #4) or an otherwise corrupted places.sqlite?

Besides: The same "(no title)" is also displayed in the bookmarks sidebar.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marco, have you tried to rename this folder via the properties dialog? Perhaps you have set a null value? Do you have this affected places.sqlite available and can upload?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This happens when opening the property dialog of one of these folders. The given name is always empty. Pressing ok will change the folder names to "(no title)". It can be undone by given its original name.

Is it by design or should we better deny renaming these three folders? I think the latter one is a good decision because using json to backup the bookmarks will miss them otherwise?

Comment 5

[Simon Bünzli]

Steps to Reproduce:
1. Right-click on the Bookmarks Toolbar folder and select Properties
2. Give it any name (default is blank/"(null)")
3. Edit again and remove the name

Expected result:
Either the folder's name at step 2 is "Bookmarks Toolbar" or when entering an empty string it's reset to "(null)" instead of "" (only the later results in "(no title)"). Or, of course, we don't allow renaming in the first place (*nod to Henrik*).

Comment 6

[Simon Bünzli]

Inspecting places.sqlite shows that there are two entries for the bookmarks toolbar (and for the other two static folders):

* id=1, parent=0, title=NULL
|- id=3, parent=1, title=Bookmarks Toolbar
|- id=6, parent=1, title=NULL
  |- id=9, parent=6, title=All Bookmarks
    |- id=10, parent=9, title="" (<- originally was NULL)

Note that the entry with id=10 has type=1 (BOOKMARK!) while the others are all of type=2 (FOLDER). And in the Library, both entries 3 and 10 are used, depending on where the title is to be displayed...

Is this as designed (allowing to rename the folders)?

Comment 7

[Marco Bonardo [:mak]]

Fixed by bug 484019 and bug 479348

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

There is no way to get into this state anymore. Verified fixed on OS X and Windows with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090711 Minefield/3.6a1pre ID:20090711031617

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5 ID:20090624012136

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv