421530 - Properties dialogs of root bookmark folders are titled "Properties for "(null)"" in bookmarks sidebar

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[[:Aleksej]]

Mozilla/5.0 (X11; U; Linux i686 (x86_64); eo; rv:1.9b5pre) Gecko/2008030704 Minefield/3.0b5pre

In the Library, properties dialogs of these folders are titled “Properties for "(null)"”:

* Tags
* Bookmarks Toolbar
* Bookmarks Menu
* Unfiled Bookmarks

Unaffected folders:
* All Bookmarks
* Smart Bookmarks

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Last week I did a regression test and afterwards not only the properties dialog reports "(null)" but also the folder name itself within the Library was titled that way. I think that I still have that broken places.sqlite at home which I could attach later today.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #1)
> Last week I did a regression test and afterwards not only the properties dialog
> reports "(null)" but also the folder name itself within the Library was titled
> that way. I think that I still have that broken places.sqlite at home which I
> could attach later today.

This places.sqlite is really broken. The title column has NULL inside for all three folders. So something went definitely wrong during my regression tests. The file is already uploaded by attachment 308704 [details] [diff] [review].

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

This will not block the final release of Firefox 3.

Comment 4

[PikeUK]

I think this needs to be higher than trivial, once you've gone to properties and clicked save changes, the root shows as "(no title)" and there's no obvious way to fix it.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yes. It is displayed as (no title) but you can still change the name via the properties dialog. You have to reopen the Library window to take the changes effect. They wont be shown immediately. IMO we shouldn't allow users to modify the name of these bookmarks because we reference them on multiple places and no idea if they will be backuped and restored correctly.

Comment 7

[[:Aleksej]]

Mozilla/5.0 (X11; U; Linux i686; eo; rv:1.9) Gecko/2008052912 Firefox/3.0
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1a1pre) Gecko/2008070802 Minefield/3.1a1pre

It looks like there is no Properties dialog anymore, and the bug does not happen in the editing pane. Resolving WORKSFORME.

Comment 8

[PikeUK]

I'm still seeing this in the context menu properties window (but not the view/editing area of the libraries window):

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a1pre) Gecko/2008070803 Minefield/3.1a1pre

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Pike, what do you mean with "context menu properties window"? As what I can see with the following version is the same as what Aleksej said for the steps given in comment 0.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1pre) Gecko/2008070903 Minefield/3.1a1pre ID:2008070903

Comment 10

[PikeUK]

(In reply to comment #9)
> Pike, what do you mean with "context menu properties window"? As what I can see
> with the following version is the same as what Aleksej said for the steps given
> in comment 0.

On my Win2K machine with latest mozilla-central nightly I still have the "Properties" option on the context menu for "Unsorted Bookmarks", and it still has the "(null)" problem. Trying the same thing on my Vista machine though doesn't have the "Properties" option anymore. I'll try to figure out why that is tomorrow and file a new bug if necessary.

Comment 11

[PikeUK]

(In reply to comment #10)
> I'll try to figure out why that
> is tomorrow and file a new bug if necessary.

It looks like my places.sqlite file must have gotten corrupted somewhere down the line (probably while I was testing this bug). I exported my bookmarks to HTML then removed my places.sqlite and bookmarkbackups folder and then reimported the HTML file. Now the Properties option for the special folders is gone on this machine too, so I can confirm this is fixed for me as well. Sorry for the spam.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This problem still persists. All bookmark root folders show "(null)" as name within the bookmarks properties dialog. Marco, shouldn't we better hide the properties menu entry for root folders?

Comment 13

[Marco Bonardo [:mak]]

we should make them read only and show correct info... Hwv this is only valid in the sidebar, isn't it? In Library there is no "properties"

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yes, the Library issue was solved a while back. But with the modification to a read only field for this dialog isn't it useless UI?

Comment 15

[Marco Bonardo [:mak]]

Fixed by bug 484019 and bug 479348

(In reply to comment #14)
> Yes, the Library issue was solved a while back. But with the modification to a
> read only field for this dialog isn't it useless UI?

It is, but that should go into a new bug if matters.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Filed bug 503693 for that. Marking this bug as verified fixed.

Comment 17

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv