Closed Bug 415367 Opened 15 years ago Closed 15 years ago
Tab extension not working due to use of ":" in chrome URIs
Reversing direction of the dependency (Given that all the patches are in Bug 413250).
It seems like branch already handles this correctly: <http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/chrome/src/nsChromeRegistry.cpp&rev=1.338.2.8&root=/cvsroot&mark=689-692#668> I'm preparing a patch for trunk with a unit test.
Assignee: nobody → ehsan.akhgari
This gets fixed by Bug 415338. Although that doesn't have a test.
The unit test of the previous patch was mistakenly included in the patch, and was not the unit test that I got to pass. Here is the updated patch with the correct unit test which passes with the patch applied.
OK, this doesn't affect branch, sorry for the bug spam. But it still affects trunk and should be fixed for beta 3 because it can break many extensions.
No longer blocks: 414327
Status: NEW → ASSIGNED
(In reply to comment #1) > Reversing direction of the dependency (Given that all the patches are in Bug > 413250). By convention we make regressions "block" the causing bug, not the other way around. You can argue either way, but sticking with convention makes it less likely regressions will be missed when patches are ported to branches.
Since the patch in bug 415338 got approval I've checked it in.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
The unit test should still be worth considering I guess.
Comment on attachment 301039 [details] [diff] [review] Unit test r/sr=dveditz
Comment on attachment 301039 [details] [diff] [review] Unit test This unit test should be used to make sure bugs such as this one don't appear in the future. Seeking approval to land this test.
Comment on attachment 301039 [details] [diff] [review] Unit test You don't ever need approval for tests.
RCS file: /cvsroot/mozilla/chrome/test/unit/test_bug415367.js,v done Checking in chrome/test/unit/test_bug415367.js; /cvsroot/mozilla/chrome/test/unit/test_bug415367.js,v <-- test_bug415367.js initial revision: 1.1 done
You need to log in before you can comment on or make changes to this bug.