Closed Bug 415388 Opened 15 years ago Closed 15 years ago

[FIX]"ASSERTION: Should be in an update while destroying frames" with document.write into iframe

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jruderman, Assigned: bzbarsky)

References

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

testcase
280 bytes, text/html
Details
I had this hanging out in one of my trees....
1.49 KB, patch
jst
: review+
jst
: superreview+
mtschrep
: approval1.9+
Details | Diff | Splinter Review 
Loading the testcase triggers:

###!!! ASSERTION: Should be in an update while destroying frames: 'mUpdateCount != 0', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 9453

Reduced from layout/reftests/bugs/388980-1-ref.html, which also triggers the assertion, so in-testsuite+.
Flags: in-testsuite+
Attached file testcase — 

    
  
Blocks: 385276

    
    

    
  


  
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED

        Attachment #301177 -
        Flags: superreview?(jst)

        Attachment #301177 -
        Flags: review?(jst)

    
  
OS: Mac OS X → All
Hardware: PC → All
Summary: "ASSERTION: Should be in an update while destroying frames" with document.write into iframe → [FIX]"ASSERTION: Should be in an update while destroying frames" with document.write into iframe

        Attachment #301177 -
        Flags: superreview?(jst)

        Attachment #301177 -
        Flags: superreview+

        Attachment #301177 -
        Flags: review?(jst)

        Attachment #301177 -
        Flags: review+

    
    

    
  
Comment on attachment 301177 [details] [diff] [review]
I had this hanging out in one of my trees....

Requesting approval.  This should be fairly safe, and fixes an assertion that Jesse ran into...

        Attachment #301177 -
        Flags: approval1.9?

    
  

        Attachment #301177 -
        Flags: approval1.9? → approval1.9+

    
    

    
  
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.