Closed Bug 415392 Opened 17 years ago Closed 16 years ago

Omnibus ad-blocking bug for February 2008

Categories

(Camino Graveyard :: Annoyance Blocking, defect)

Product:
Camino Graveyard
Component:
Annoyance Blocking
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: alqahira, Assigned: alqahira)

Details

(Keywords: fixed1.8.1.13)

Attachments

(1 file)

February Omnibus Fixes
4.86 KB, patch
sfraser_bugs
: superreview+
Details | Diff | Splinter Review 
New month, new bug, new ads to block!
The BBC (news.bbc.co.uk) is changing the ID's of the containers used for publicity.

div[id^="bbccom_"] {display:none !important;}
takes care of those.
The previous version was in bug 398120: div[id^="ad1"],...
On both freep.com and desmoinesregister.com, a bunch of Flash ads are slipping through from gcirm.*.gcion.com domains. At least one should be visible across the top here:

http://www.desmoinesregister.com/apps/pbcs.dll/article?AID=/20080229/NEWS/80229003/-1/SiteMap

and you may see a second one in the article content.

cl
Big nasty Flash floater on

http://imdb.com/title/tt0119345/

that I'm pretty sure came from this code somehow:

<div id="wrapper">
 <!-- sid : 75316 : FLOATING --><script language="JavaScript" src="http://ia.imdb.com/media/imdb/01/J/02"></script><script language="JavaScript" src="http://ia.imdb.com/media/imdb/01/J/04"></script>

<script language="JavaScript">document.writeln(cb4('\n<scr'+'ipt language="JavaScript">\n<!--\n\nfunction hide_select_Floater() {\n	// alert(\'hiding input boxes\');\n	var selects = document.body.getElementsByTagName(\'select\');\n	var count = selects.length;\n	for (i=0;i<count;i++) {\n		selects[i].style.display = \'none\';\n	}\n}\n\nfunction show_select_Floater() {\n	// alert(\'showing input boxes\');\n	var selects = document.body.getElementsByTagName(\'select\');\n	var count = selects.length;\n	for (i=0;i<count;i++) {\n		selects[i].style.display = \'inline\';\n	}\n}\n\nvar bamfTop = 0;\nvar bamfLeft = 0;\nbamfTop = (document.body.clientHeight/2) - (500/2);\nbamfLeft = (document.body.clientWidth/2) - (500/2);\n\n\ntry {\n	hide_select_Floater();\n	document.writeln(\'<div id="swf_Floater" align="center" style="position:absolute; top:\'+bamfTop+\'; left:\'+bamfLeft+\'; z-index:100;"> <table cellpadding="0" cellspacing="0" > <tr><td align="center"><object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,0,0" width="500" height="500" id="Floater"><param name="movie" value="http://ia.imdb.com/media/imdb/01/I/12/53/94/10.swf"><PARAM name="flashvars" value="clickTAG=/ri/AWAKE_FLOATER//75316/http://www.geniusproducts.com/awake/"><param name="play" value="true"><param name="quality" value="high"><param name="allowScriptAccess" value="always"><param name="bgcolor" value="#FFFFFF"><PARAM name="wmode" value="transparent"><embed src="http://ia.imdb.com/media/imdb/01/I/12/53/94/10.swf" flashvars="clickTAG=/ri/AWAKE_FLOATER//75316/http://www.geniusproducts.com/awake/" quality="high" play="true" bgcolor="#FFFFFF" width="500" height="500" name="Floater" allowScriptAccess="always"  wmode="transparent"  type="application/x-shockwave-flash" pluginspage="http://www.macromedia.com/go/getflashplayer"></embed></object></td></tr> <tr><td style="height: 0;"><IMG SRC="http://ad.doubleclick.net/ad/N3828.iMDB/B2743140.7;sz=1x1;ord=[timestamp]?" BORDER=0 WIDTH=1 HEIGHT=1 ALT="Click Here"></td></tr> </table> </div> \');\n	object_reload(\'Floater\');\n} catch (err) {}\n\nfunction hideme()\n{\n	if ((document.all)) {\n		show_select_Floater();\n		document.all[\'swf_Floater\'].style.display = \'none\';\n	} else {\n		var elem = document.getElementById(\'swf_Floater\');\n		if (elem) {\n			elem.style.display = \'none\';\n		}\n	}\n}\n//-->\n</scr'+'ipt>\n'));</script>


I don't see anything there on a fresh profile other than a banner at the top and a square at the right side that we block :-(
(In reply to comment #9)
> I don't see anything there on a fresh profile other than a banner at the top
> and a square at the right side that we block :-(

Yeah, I can't reproduce it consistently either, but the Flash itself is coming from

http://ia.imdb.com/media/imdb/01/I/12/53/94/10.swf

and it looks to me like ia.imdb.com is purely an adserver.

cl
(In reply to comment #11)
> and it looks to me like ia.imdb.com is purely an adserver.

Unfortunately, that's not the case at all; its their media server, but it also serves UI (including Flash-based navigation UI that replaces the HTML navbar from time to time) and all the pictures, etc.  They've done a very good job of making many of their Flash ads impossible to block.

We can try to block <div id="swf_Floater">, but I don't know if that's something that could also be used legitimately.
(In reply to comment #3)
> The BBC (news.bbc.co.uk) is changing the ID's of the containers used for
> publicity.
> 
> div[id^="bbccom_"] {display:none !important;}
> takes care of those.

I must have a set of super-ad-blocking Caminos, because I can't see those divs in any Camino, even with ad-blocking off, and I can't find any other rule that seems to be blocking them.
(In reply to comment #14)

They are in the source code. Apparently no publicity is being served, right now.
 

(In reply to comment #13)

> We can try to block <div id="swf_Floater">, but I don't know if that's
> something that could also be used legitimately.
> 
That would be dangerous to block in general. There is a JS-script somewhere to inject Flash in the pages; iirc it uses 'swf_' as prefix on classes for a wrapper element.


(In reply to comment #15)
> They are in the source code. Apparently no publicity is being served, right
> now.

I did see them in the source; I forgot to mention that I did see the big empty <div>s in Firefox, though.  Bizarre.

(In reply to comment #7)
> On both freep.com and desmoinesregister.com, a bunch of Flash ads are slipping
> through from gcirm.*.gcion.com domains. At least one should be visible across
> the top here:

The ones that they seem to be serving me are all blocked by the embed[type="application/x-shockwave-flash"][src*="/RealMedia/ads/"]
rule.
Ref bbc.co.uk
This AM, I got a real ad (top, flash banner from doubleclick) in FX 2. It is blocked in Camino, but the wrapping div leaves the big hole.
This fixes everything mentioned, except the imdb thing we've already discussed and comment 12.

Since we're about ready to switch over to the trunk, and CSS is case-sensitive on the trunk, I also added a couple of mixed-case equivalents for existing rules that I hit while working on this patch.
Attachment #308368 - Flags: superreview?(sfraser_bugs)
Attachment #308368 - Flags: superreview?(sfraser_bugs) → superreview+
Checked in on the trunk and MOZILLA_1_8_BRANCH.

If we end up doing a 1.5.6, we can look at this then.
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: camino1.5.6?
Keywords: fixed1.8.1.13
Resolution: --- → FIXED
Camino 1.5.6 is not happening.
Flags: camino1.5.6? → camino1.5.6-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: