Closed Bug 415397 Opened 16 years ago Closed 16 years ago

URLs with (un)escaped characters can't be deleted

Categories

(Firefox :: Address Bar, defect, P3)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3 beta5

People

(Reporter: zeniko, Assigned: Mardak)

References

Details

(Keywords: privacy, regression, Whiteboard: [fixed by bug 419656]) 

Steps to Reproduce:
1. Do a "Bugs Filed Today" search on this Bugzilla
2. Hit Ctrl+L, Down and Delete
3. Hit Esc, Esc and Down again

Expected result:
The address has been purged from history.

Actual result:
There was no disk churning for once... OTOH the deleted address reappears as if nothing had happened at step 2.

Probably a regression from bug 407974.
Flags: blocking-firefox3?
This is related to bug 391691, so figuring out a fix might help both bugs.

FYI: The db contains both entries:
requestee=edilee%40gmail.com
and
requestee=edilee@gmail.com

Both can appear depending on how the user types in the url.
Oh, and for the example from comment 0, it's the chfield=[Bug%20creation] vs chfield=%5BBug%20creation%5D
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P3
Depends on: 415460
Bug 415460 will store URIs the same way they're displayed as well as fixing bug 391691 so there's only one copy to delete.
Assignee: nobody → edilee
OS: Windows XP → All
Hardware: PC → All
Whiteboard: [has fix in bug 415460]
No longer depends on: 415460
So bug 415460 didn't land with its original patch so bug 391691 still exists.

One potential source of this problem is fixed by bug 419656 which will provide the front-end the original escaped URL so that delete is used with the original escaped URL which is in the database. (The UI would then be in charge of making sure to display the unescaped version instead of the backend providing the unescaped version.)
Whiteboard: [has fix in bug 415460]
Blocks: 407974
Whiteboard: [fixed by bug 419656]
Depends on: 419656
Checking in toolkit/components/places/tests/unit/test_413784.js;
/cvsroot/mozilla/toolkit/components/places/tests/unit/test_413784.js,v  <--  test_413784.js
new revision: 1.4; previous revision: 1.3
done
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta5
You need to log in before you can comment on or make changes to this bug.