Closed Bug 415403 Opened 13 years ago Closed 13 years ago

Show matches for all search words for location bar autocomplete

Categories

(Firefox :: Address Bar, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 3 beta5

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(3 files, 3 obsolete files)

Bug 401869 provides the backend to match multiple words split by spaces. Bug 407944 provides the ability to select multiple words.

Combine the two to get match all select all!
Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
If we go the other path of using multiple spans.. we'll need bug 407946.
Depends on: 407946
Flags: blocking-firefox3?
Attached patch v2 (obsolete) — Splinter Review
Attachment #302448 - Flags: review?(gavin.sharp)
Comment on attachment 302448 [details] [diff] [review]
v2

I suppose just to keep things clear, this needs bug 407946. I'll do what I do for dietrich when I have multiple patches in the pipeline.. I'll "r?" then "r? reviewer" later.

But then I suppose that isn't really pipelining to hide latencies anymore ;) :p
Attachment #302448 - Flags: review?(gavin.sharp) → review?
Attached image bubbles
Here's an interesting take.. First is 1px, second is 2px, last is 0px. I added in the 1px border so that when it curves, it actually covers the text.

html|*.ac-emphasize-text {
  margin: -1px !important;
  border: 1px solid transparent;
  padding: 0;
/*  font-weight: bold;*/
  -moz-border-radius: .5em;
  text-decoration: underline;
}

.ac-title html|*.ac-emphasize-text {
  background: rgba(0, 0, 0, .3);
}

.ac-url html|*.ac-emphasize-text {
  background: rgba(51, 102, 51, .3);
}
Comment on attachment 302452 [details]
screenshot of v2

Looks great, but I can't give you a formal ui-r+
Attachment #302452 - Flags: ui-review?(faaborg)
The bubbles would look good if - if searching for r wouldn't highlight featu[r]es, u[r]l, and so on.
Searching human text is very complicated and couldn't Google's refined algorithms be borrowed here? For example when I search for c programming I don't want results on o[c]aml programming or at least the full word match should be prioritized.
Finally the whole locationbar search and new easier places are developed because people are using Google instead of bookmarks right? But people use Google because it's smart for example what a full word match means varies by language. It would be hard to reinvent these algorithms or do without
IMO the bubbles don't fit too well into the rectangular autocomplete items. What about removing the rounded corners? And I'd remove the distracting underlines as well, as they make words with many descenders harder to read.

Besides: Please make sure not to use any more non-standard colors if you can help it (cf. bug 409974). AFAICT all OSes provide standard colors for highlighted text including a matching background!
Styling is a different bug (I don't have the number to hand). Let's keep this one about being able to apply that style to multiple items in a single line, which does block.
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
I'm assuming the styling bug is bug 407861.
Whiteboard: [has patch][needs review gavin][needs bug 407946]
Attached patch v2.1 (obsolete) — Splinter Review
Now with more let and unbitrotting from bug 407946 changes.
Attachment #302448 - Attachment is obsolete: true
Attachment #305679 - Flags: review?
Attachment #302448 - Flags: review?
Comment on attachment 305679 [details] [diff] [review]
v2.1

Requesting r? on the blocking-firefox3 P2 bug to get it on the radar.
Attachment #305679 - Flags: review? → review?(gavin.sharp)
Blocks: 392143
Attached patch v2.2Splinter Review
Update to changes from bug 407946.. Super simple! ;)
Attachment #301074 - Attachment is obsolete: true
Attachment #305679 - Attachment is obsolete: true
Attachment #306700 - Flags: review?(gavin.sharp)
Attachment #305679 - Flags: review?(gavin.sharp)
Blocks: 420437
Blocks: 405745
Comment on attachment 306700 [details] [diff] [review]
v2.2

Clearing r? until dependencies are ready.
Attachment #306700 - Flags: review?(gavin.sharp) → review?
Comment on attachment 306700 [details] [diff] [review]
v2.2

Bug 407946 is ready to review, so I'll just request this simple change now.. even though it'll be overwritten by bug 420437 changes
Attachment #306700 - Flags: review? → review?(gavin.sharp)
Attachment #306700 - Flags: review?(gavin.sharp) → review+
Whiteboard: [has patch][needs review gavin][needs bug 407946] → [has patch][needs bug 407946]
Comment on attachment 306700 [details] [diff] [review]
v2.2

a1.9b5? for landing after bug 407946.

stephend: "Type 'h /' into the location bar and make sure both h and / of Http://... are emphasized"
Attachment #306700 - Flags: approval1.9b5?
Comment on attachment 306700 [details] [diff] [review]
v2.2

a=beltzner
Attachment #306700 - Flags: approval1.9b5? → approval1.9b5+
(In reply to comment #17)
> (From update of attachment 306700 [details] [diff] [review])
> a1.9b5? for landing after bug 407946.
> 
> stephend: "Type 'h /' into the location bar and make sure both h and / of
> Http://... are emphasized"

in-litmus+:

https://litmus.mozilla.org/show_test.cgi?id=5208


Flags: in-litmus? → in-litmus+
Checking in toolkit/content/widgets/autocomplete.xml;
/cvsroot/mozilla/toolkit/content/widgets/autocomplete.xml,v  <--  autocomplete.xml
new revision: 1.127; previous revision: 1.126
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][needs bug 407946]
Target Milestone: --- → Firefox 3 beta5
Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008032204 Minefield/3.0b5pre

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032204 Minefield/3.0b5pre

-and-

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008032204 Minefield/3.0b5pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.